feat(binding): Expose remove_device_data

FirelightFlagboy · FirelightFlagboy · commit 1f7f082ed5c6 · 2025-12-19T12:46:58.000Z
Closes #11892
diff --git a/bindings/electron/src/index.d.ts b/bindings/electron/src/index.d.ts
@@ -3202,6 +3202,15 @@ export type PkiGetAddrError =
   | PkiGetAddrErrorInternal
 
 
+// RemoveDeviceDataError
+export interface RemoveDeviceDataErrorFailedToRemoveData {
+    tag: "RemoveDeviceDataErrorFailedToRemoveData"
+    error: string
+}
+export type RemoveDeviceDataError =
+  | RemoveDeviceDataErrorFailedToRemoveData
+
+
 // RemoveDeviceError
 export interface RemoveDeviceErrorInternal {
     tag: "RemoveDeviceErrorInternal"
@@ -5186,6 +5195,10 @@ export function pkiRemoveLocalPending(
     config: ClientConfig,
     id: string
 ): Promise<Result<null, RemoveDeviceError>>
+export function removeDeviceData(
+    config: ClientConfig,
+    device_id: string
+): Promise<Result<null, RemoveDeviceDataError>>
 export function showCertificateSelectionDialogWindowsOnly(
 ): Promise<Result<X509CertificateReference | null, ShowCertificateSelectionDialogError>>
 export function testCheckMailbox(
diff --git a/bindings/electron/src/meths.rs b/bindings/electron/src/meths.rs
@@ -13879,6 +13879,26 @@ fn variant_pki_get_addr_error_rs_to_js<'a>(
     Ok(js_obj)
 }
 
+// RemoveDeviceDataError
+
+#[allow(dead_code)]
+fn variant_remove_device_data_error_rs_to_js<'a>(
+    cx: &mut impl Context<'a>,
+    rs_obj: libparsec::RemoveDeviceDataError,
+) -> NeonResult<Handle<'a, JsObject>> {
+    let js_obj = cx.empty_object();
+    let js_display = JsString::try_new(cx, &rs_obj.to_string()).or_throw(cx)?;
+    js_obj.set(cx, "error", js_display)?;
+    match rs_obj {
+        libparsec::RemoveDeviceDataError::FailedToRemoveData { .. } => {
+            let js_tag =
+                JsString::try_new(cx, "RemoveDeviceDataErrorFailedToRemoveData").or_throw(cx)?;
+            js_obj.set(cx, "tag", js_tag)?;
+        }
+    }
+    Ok(js_obj)
+}
+
 // RemoveDeviceError
 
 #[allow(dead_code)]
@@ -25470,6 +25490,65 @@ fn pki_remove_local_pending(mut cx: FunctionContext) -> JsResult<JsPromise> {
     Ok(promise)
 }
 
+// remove_device_data
+fn remove_device_data(mut cx: FunctionContext) -> JsResult<JsPromise> {
+    crate::init_sentry();
+    let config = {
+        let js_val = cx.argument::<JsObject>(0)?;
+        struct_client_config_js_to_rs(&mut cx, js_val)?
+    };
+    let device_id = {
+        let js_val = cx.argument::<JsString>(1)?;
+        {
+            let custom_from_rs_string = |s: String| -> Result<libparsec::DeviceID, _> {
+                libparsec::DeviceID::from_hex(s.as_str()).map_err(|e| e.to_string())
+            };
+            match custom_from_rs_string(js_val.value(&mut cx)) {
+                Ok(val) => val,
+                Err(err) => return cx.throw_type_error(err),
+            }
+        }
+    };
+    let channel = cx.channel();
+    let (deferred, promise) = cx.promise();
+
+    // TODO: Promises are not cancellable in Javascript by default, should we add a custom cancel method ?
+    let _handle = crate::TOKIO_RUNTIME
+        .lock()
+        .expect("Mutex is poisoned")
+        .spawn(async move {
+            let ret = libparsec::remove_device_data(config, device_id).await;
+
+            deferred.settle_with(&channel, move |mut cx| {
+                let js_ret = match ret {
+                    Ok(ok) => {
+                        let js_obj = JsObject::new(&mut cx);
+                        let js_tag = JsBoolean::new(&mut cx, true);
+                        js_obj.set(&mut cx, "ok", js_tag)?;
+                        let js_value = {
+                            #[allow(clippy::let_unit_value)]
+                            let _ = ok;
+                            JsNull::new(&mut cx)
+                        };
+                        js_obj.set(&mut cx, "value", js_value)?;
+                        js_obj
+                    }
+                    Err(err) => {
+                        let js_obj = cx.empty_object();
+                        let js_tag = JsBoolean::new(&mut cx, false);
+                        js_obj.set(&mut cx, "ok", js_tag)?;
+                        let js_err = variant_remove_device_data_error_rs_to_js(&mut cx, err)?;
+                        js_obj.set(&mut cx, "error", js_err)?;
+                        js_obj
+                    }
+                };
+                Ok(js_ret)
+            });
+        });
+
+    Ok(promise)
+}
+
 // show_certificate_selection_dialog_windows_only
 fn show_certificate_selection_dialog_windows_only(mut cx: FunctionContext) -> JsResult<JsPromise> {
     crate::init_sentry();
@@ -29902,6 +29981,7 @@ pub fn register_meths(cx: &mut ModuleContext) -> NeonResult<()> {
     cx.export_function("pkiEnrollmentInfo", pki_enrollment_info)?;
     cx.export_function("pkiEnrollmentSubmit", pki_enrollment_submit)?;
     cx.export_function("pkiRemoveLocalPending", pki_remove_local_pending)?;
+    cx.export_function("removeDeviceData", remove_device_data)?;
     cx.export_function(
         "showCertificateSelectionDialogWindowsOnly",
         show_certificate_selection_dialog_windows_only,
diff --git a/bindings/generator/api/common.py b/bindings/generator/api/common.py
@@ -176,6 +176,10 @@ class Handle(U32BasedType):
     pass
 
 
+class AnyhowError(StrBasedType):
+    custom_to_rs_string = DISPLAY_TO_STRING
+
+
 class ApiVersion(StrBasedType):
     custom_from_rs_string = "|s: String| -> Result<_, String> { libparsec::ApiVersion::try_from(s.as_str()).map_err(|e| e.to_string()) }"
     custom_to_rs_string = DISPLAY_TO_STRING
diff --git a/bindings/generator/api/device.py b/bindings/generator/api/device.py
@@ -19,6 +19,7 @@
     VariantItemUnit,
     X509CertificateReference,
 )
+from .config import ClientConfig
 
 
 class AvailableDeviceType(Variant):
@@ -129,6 +130,16 @@ async def archive_device(
     raise NotImplementedError
 
 
+class RemoveDeviceDataError(ErrorVariant):
+    class FailedToRemoveData: ...
+
+
+async def remove_device_data(
+    config: ClientConfig, device_id: DeviceID
+) -> Result[None, RemoveDeviceDataError]:
+    raise NotImplementedError
+
+
 class UpdateDeviceError(ErrorVariant):
     class StorageNotAvailable:
         pass
diff --git a/bindings/web/src/meths.rs b/bindings/web/src/meths.rs
@@ -15198,6 +15198,27 @@ fn variant_pki_get_addr_error_rs_to_js(
     Ok(js_obj)
 }
 
+// RemoveDeviceDataError
+
+#[allow(dead_code)]
+fn variant_remove_device_data_error_rs_to_js(
+    rs_obj: libparsec::RemoveDeviceDataError,
+) -> Result<JsValue, JsValue> {
+    let js_obj = Object::new().into();
+    let js_display = &rs_obj.to_string();
+    Reflect::set(&js_obj, &"error".into(), &js_display.into())?;
+    match rs_obj {
+        libparsec::RemoveDeviceDataError::FailedToRemoveData { .. } => {
+            Reflect::set(
+                &js_obj,
+                &"tag".into(),
+                &"RemoveDeviceDataErrorFailedToRemoveData".into(),
+            )?;
+        }
+    }
+    Ok(js_obj)
+}
+
 // RemoveDeviceError
 
 #[allow(dead_code)]
@@ -23733,6 +23754,43 @@ pub fn pkiRemoveLocalPending(config: Object, id: String) -> Promise {
     }))
 }
 
+// remove_device_data
+#[allow(non_snake_case)]
+#[wasm_bindgen]
+pub fn removeDeviceData(config: Object, device_id: String) -> Promise {
+    future_to_promise(libparsec::WithTaskIDFuture::from(async move {
+        let config = config.into();
+        let config = struct_client_config_js_to_rs(config)?;
+
+        let device_id = {
+            let custom_from_rs_string = |s: String| -> Result<libparsec::DeviceID, _> {
+                libparsec::DeviceID::from_hex(s.as_str()).map_err(|e| e.to_string())
+            };
+            custom_from_rs_string(device_id).map_err(|e| TypeError::new(e.as_ref()))
+        }?;
+        let ret = libparsec::remove_device_data(config, device_id).await;
+        Ok(match ret {
+            Ok(value) => {
+                let js_obj = Object::new().into();
+                Reflect::set(&js_obj, &"ok".into(), &true.into())?;
+                let js_value = {
+                    let _ = value;
+                    JsValue::null()
+                };
+                Reflect::set(&js_obj, &"value".into(), &js_value)?;
+                js_obj
+            }
+            Err(err) => {
+                let js_obj = Object::new().into();
+                Reflect::set(&js_obj, &"ok".into(), &false.into())?;
+                let js_err = variant_remove_device_data_error_rs_to_js(err)?;
+                Reflect::set(&js_obj, &"error".into(), &js_err)?;
+                js_obj
+            }
+        })
+    }))
+}
+
 // show_certificate_selection_dialog_windows_only
 #[allow(non_snake_case)]
 #[wasm_bindgen]
diff --git a/client/src/plugins/libparsec/definitions.ts b/client/src/plugins/libparsec/definitions.ts
@@ -84,6 +84,7 @@ export enum UserProfile {
 }
 export type AccountAuthMethodID = string
 export type AccountVaultItemOpaqueKeyID = string
+export type AnyhowError = string
 export type ApiVersion = string
 export type DeviceID = string
 export type DeviceLabel = string
@@ -3807,6 +3808,18 @@ export interface PkiGetAddrErrorInternal {
 export type PkiGetAddrError =
   | PkiGetAddrErrorInternal
 
+// RemoveDeviceDataError
+export enum RemoveDeviceDataErrorTag {
+    FailedToRemoveData = 'RemoveDeviceDataErrorFailedToRemoveData',
+}
+
+export interface RemoveDeviceDataErrorFailedToRemoveData {
+    tag: RemoveDeviceDataErrorTag.FailedToRemoveData
+    error: string
+}
+export type RemoveDeviceDataError =
+  | RemoveDeviceDataErrorFailedToRemoveData
+
 // RemoveDeviceError
 export enum RemoveDeviceErrorTag {
     Internal = 'RemoveDeviceErrorInternal',
@@ -6131,6 +6144,10 @@ export interface LibParsecPlugin {
         config: ClientConfig,
         id: PKIEnrollmentID
     ): Promise<Result<null, RemoveDeviceError>>
+    removeDeviceData(
+        config: ClientConfig,
+        device_id: DeviceID
+    ): Promise<Result<null, RemoveDeviceDataError>>
     showCertificateSelectionDialogWindowsOnly(
     ): Promise<Result<X509CertificateReference | null, ShowCertificateSelectionDialogError>>
     testCheckMailbox(
diff --git a/libparsec/src/device.rs b/libparsec/src/device.rs
@@ -1,11 +1,13 @@
 // Parsec Cloud (https://parsec.cloud) Copyright (c) BUSL-1.1 2016-present Scille SAS
 
-use std::path::Path;
+use std::{path::Path, sync::Arc};
 
+use crate::config::ClientConfig;
 pub use libparsec_platform_device_loader::{
     ArchiveDeviceError, AvailableDevice, AvailableDeviceType, ListAvailableDeviceError,
     ListPkiLocalPendingError, UpdateDeviceError,
 };
+pub use libparsec_platform_storage::RemoveDeviceDataError;
 use libparsec_types::prelude::*;
 
 mod strategy {
@@ -393,6 +395,15 @@ pub async fn archive_device(
     libparsec_platform_device_loader::archive_device(config_dir, device_path).await
 }
 
+pub async fn remove_device_data(
+    config: ClientConfig,
+    device_id: DeviceID,
+) -> Result<(), RemoveDeviceDataError> {
+    let config: Arc<libparsec_client::ClientConfig> = config.into();
+
+    libparsec_platform_storage::remove_device_data(&config.data_base_dir, device_id).await
+}
+
 pub async fn update_device_change_authentication(
     config_dir: &Path,
     current_auth: DeviceAccessStrategy,
diff --git a/libparsec/src/lib.rs b/libparsec/src/lib.rs
@@ -46,6 +46,8 @@ pub use validation::*;
 pub use workspace::*;
 pub use workspace_history::*;
 
+pub use libparsec_types::anyhow::Error as AnyhowError;
+
 pub mod internal {
     pub use libparsec_client::{
         claimer_retrieve_info, AnyClaimRetrievedInfoCtx, Client, ClientConfig,
