Skip to content

Client pki list does not validate submitted request #11567

@FirelightFlagboy

Description

@FirelightFlagboy

The code at

pub async fn list_enrollments(
cmds: &AuthenticatedCmds,
) -> Result<Vec<PkiEnrollmentListItem>, PkiEnrollmentListError> {
use authenticated_cmds::latest::pki_enrollment_list::{Rep, Req};
let rep = cmds.send(Req).await?;
match rep {
Rep::Ok { enrollments } => Ok(enrollments),
Rep::AuthorNotAllowed => Err(PkiEnrollmentListError::AuthorNotAllowed),
rep @ Rep::UnknownStatus { .. } => {
Err(anyhow::anyhow!("Unexpected server response: {:?}", rep).into())
}
}
}

Only list the value from the server without doing any validation (do we trust the request)

Metadata

Metadata

Labels

A-ClientArea: Parsec desktop applicationC-PKICategory: Smartcard or PKI support in ParsecI-RustImpact: Rust-related stuff

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions