[Bug]: Error in the pre_install script for twinkle-tray

[Mahir007]

Prerequisites

• I have written a descriptive issue title.
• I have searched all issues/PRs to ensure it has not already been reported or fixed.
• I have verified that I am using the latest version of Scoop and corresponding bucket.

Package Name

twinkle-tray

Expected/Current Behaviour

When updating (or newly installing) the twinkle-tray package, an error is shown stating that the pre_install script failed because it could not find a path written in the manifest.

Steps to Reproduce

PS> scoop update twinkle-tray
twinkle-tray: 1.16.4 -> 1.16.5
Updating one outdated app:
Updating 'twinkle-tray' (1.16.4 -> 1.16.5)
Downloading new version
Twinkle.Tray.v1.16.5.exe (81.3 MB) [==========================================================================] 100%
Checking hash of Twinkle.Tray.v1.16.5.exe ... ok.
Uninstalling 'twinkle-tray' (1.16.4)
Removing shim 'twinkle-tray.shim'.
Removing shim 'twinkle-tray.exe'.
Unlinking ~\scoop\apps\twinkle-tray\current
Installing 'twinkle-tray' (1.16.5) [64bit] from 'extras' bucket
Loading Twinkle.Tray.v1.16.5.exe from cache
Extracting Twinkle.Tray.v1.16.5.exe ... done.
Running pre_install script...Remove-Item:
Line |
   2 |  Remove-Item "$dir\`$PLUGINSDIR", "$dir\`$R0" -Force -Recurse
     |  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | Cannot find path 'C:\Users\mahir\scoop\apps\twinkle-tray\1.16.5\$R0' because it does not exist.
done.
Linking ~\scoop\apps\twinkle-tray\current => ~\scoop\apps\twinkle-tray\1.16.5
Creating shim for 'twinkle-tray'.
Making C:\Users\mahir\scoop\shims\twinkle-tray.exe a GUI binary.
Creating shortcut for Twinkle Tray (Twinkle Tray.exe)
'twinkle-tray' (1.16.5) was installed successfully!

Possible Solution

The pre_install script in the manifest should be updated as the location of the uninstaller has changed.

Scoop and Buckets Version

PS> scoop --version
Current Scoop version:
859d1db5 (HEAD -> master, tag: v0.5.2, origin/master, origin/HEAD) chore(release): Bump to version 0.5.2 (#6080)

'main' bucket:
93a1c85f2 (HEAD -> master, origin/master, origin/HEAD) traefik: Update to version 3.3.0

'extras' bucket:
3738fc019 (HEAD -> master, origin/master, origin/HEAD) metasploit-framework: Update to version 6.4.44-20250106113701

'versions' bucket:
753ae47b7 (HEAD -> master, origin/master, origin/HEAD) vscode-insiders: Update to version 1.97.0-1736139904601

'nerd-fonts' bucket:
4cd5e93a (HEAD -> master, origin/master, origin/HEAD) LXGWNeoZhiSong: Update to version 1.022

'nonportable' bucket:
869ecf2 (HEAD -> master, origin/master, origin/HEAD) vokoscreenng-np: Update to version 4.4.0

'games' bucket:
04de3000b (HEAD -> master, origin/master, origin/HEAD) xenia-canary: Update to version 20250106113235-13badbb

Scoop Config

PS> scoop config

last_update         scoop_branch scoop_repo                              alias
-----------         ------------ ----------                              -----
06/01/2025 15:09:50 master       https://github.com/ScoopInstaller/Scoop @{reinstall=scoop-reinstall}

PowerShell Version

PS> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      7.4.6
PSEdition                      Core
GitCommitId                    7.4.6
OS                             Microsoft Windows 10.0.26100
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

Additional Softwares

No response

[Mahir007]

As of version v1.16.7, this issue still occurs:

PS> scoop update twinkle-tray
twinkle-tray: 1.16.6 -> 1.16.7
Updating one outdated app:
Updating 'twinkle-tray' (1.16.6 -> 1.16.7)
Downloading new version
Twinkle.Tray.v1.16.7.exe (82.0 MB) [==========================================================================] 100%
Checking hash of Twinkle.Tray.v1.16.7.exe ... ok.
Uninstalling 'twinkle-tray' (1.16.6)
Removing shim 'twinkle-tray.shim'.
Removing shim 'twinkle-tray.exe'.
Unlinking ~\scoop\apps\twinkle-tray\current
Installing 'twinkle-tray' (1.16.7) [64bit] from 'extras' bucket
Loading Twinkle.Tray.v1.16.7.exe from cache
Extracting Twinkle.Tray.v1.16.7.exe ... done.
Running pre_install script...Remove-Item:
Line |
   2 |  Remove-Item "$dir\`$PLUGINSDIR", "$dir\`$R0" -Force -Recurse
     |  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | Cannot find path 'C:\Users\mahir\scoop\apps\twinkle-tray\1.16.7\$R0' because it does not exist.
done.
Linking ~\scoop\apps\twinkle-tray\current => ~\scoop\apps\twinkle-tray\1.16.7
Creating shim for 'twinkle-tray'.
Making C:\Users\mahir\scoop\shims\twinkle-tray.exe a GUI binary.
Creating shortcut for Twinkle Tray (Twinkle Tray.exe)
'twinkle-tray' (1.16.7) was installed successfully!

The PR I've created (#14686) fixes this issue successfully without any new errors.