-
Notifications
You must be signed in to change notification settings - Fork 1.6k
gperf: Add version 3.1-6 #16426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gperf: Add version 3.1-6 #16426
Conversation
WalkthroughAdds a new manifest Changes
Sequence Diagram(s)sequenceDiagram
participant Maintainer
participant Bucket as "bucket/gperf.json"
participant CI as "Auto-update/Checkver"
participant Mirror as "Download URL"
rect rgb(230, 245, 255)
Maintainer->>Bucket: Add manifest (v3.1-6, metadata, arch blocks)
end
rect rgb(245, 255, 230)
CI->>Bucket: Run checkver (parse PKGBUILD via regex)
CI-->>Maintainer: Report normalized version
CI->>Bucket: Use autoupdate template
CI->>Mirror: Construct arch-specific download URL
Mirror-->>CI: Serve artifact + SHA-256
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All changes look good. Wait for review from human collaborators. gperf
|
|
Duplicates ScoopInstaller/Main#6888. |
I close it |
|
/verify |
|
All changes look good. Wait for review from human collaborators. gperf
|
|
/verify |
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with gperf
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bucket/gperf.json(1 hunks)
🔇 Additional comments (3)
bucket/gperf.json (3)
1-31: Clarify the status of the duplicate PR issue before merging.The PR objectives note that reviewer aliesbelik flagged this as a duplicate of ScoopInstaller/Main#6888, and you acknowledged this. Verify whether:
- The Main repository PR has been closed/abandoned
- This PR in Extras is the intended location (and the Main PR should be closed)
- Whether this PR should proceed or be consolidated with the Main PR
This should be resolved before approval to prevent duplicate package entries across repositories.
5-5: GNU gperf 3.1 is released under GPL-3 or later, and the SPDX identifier "GPL-3.0-or-later" correctly represents this license. The specified license in the code is accurate and properly aligned with the GNU gperf project's actual licensing.
17-21: Regex pattern verified and working correctly.The checkver regex successfully extracts version
3.1and package release6from the MSYS2 PKGBUILD file, producing the expected combined format3.1-6. No issues detected.
|
/verify |
|
All changes look good. Wait for review from human collaborators. gperf
|
|
i`m ready |
|
Closing this PR as per #16425 (comment). |
<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit