Skip to content

Conversation

@wentywenty
Copy link

@wentywenty wentywenty commented Oct 21, 2025

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Summary by CodeRabbit

  • New Features
    • Added gperf package support with multi-architecture downloads for 64-bit and 32-bit.
    • Enabled automated version detection and templated updates to simplify package maintenance.

@wentywenty
Copy link
Author

#16425

@coderabbitai
Copy link

coderabbitai bot commented Oct 21, 2025

Walkthrough

Adds a new manifest bucket/gperf.json describing gperf v3.1-6 with metadata, architecture-specific download URLs and checksums, and configurations for automated version checking and autoupdate.

Changes

Cohort / File(s) Summary
New manifest addition
bucket/gperf.json
Adds gperf package manifest (v3.1-6) with description, homepage, license, 64-bit and 32-bit architecture blocks (download URLs and SHA-256), binary name, checkver regex/normalize, and autoupdate templates for both architectures.

Sequence Diagram(s)

sequenceDiagram
  participant Maintainer
  participant Bucket as "bucket/gperf.json"
  participant CI as "Auto-update/Checkver"
  participant Mirror as "Download URL"

  rect rgb(230, 245, 255)
  Maintainer->>Bucket: Add manifest (v3.1-6, metadata, arch blocks)
  end

  rect rgb(245, 255, 230)
  CI->>Bucket: Run checkver (parse PKGBUILD via regex)
  CI-->>Maintainer: Report normalized version
  CI->>Bucket: Use autoupdate template
  CI->>Mirror: Construct arch-specific download URL
  Mirror-->>CI: Serve artifact + SHA-256
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐇 I hopped a path to JSON land,

fetched checksums with careful hand,
two builds tucked in tidy rows,
version-checked where river flows,
gperf now ready — here it stands.

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues Check ✅ Passed The code changes fulfill the requirements from linked issue #16425. The PR adds a manifest file (bucket/gperf.json) for the gperf package version 3.1-6, which meets the stated criteria: correct package name (gperf), version handling (3.1-6), architecture-specific downloads for both 64-bit and 32-bit builds with SHA-256 hashes, appropriate binary naming (gperf.exe), and automated version checking and update capabilities through checkver and autoupdate sections. The changeset implements all necessary coding requirements specified in the issue.
Out of Scope Changes Check ✅ Passed The changeset adds only one file—bucket/gperf.json—which is a manifest file directly addressing the requirement in linked issue #16425 to package gperf. There are no modifications to unrelated files, no additional changes beyond the scope of the request, and no extraneous updates that deviate from the stated objective of adding the gperf package manifest. All changes are properly scoped to fulfill the linked issue.
Description Check ✅ Passed The PR description includes all required sections from the template: it closes issue #16425, confirms the use of conventional PR title format, and indicates the author has read the Contributing Guide. While the description is minimal and doesn't include extensive implementation details, it fulfills the essential requirements outlined in the template. The checked boxes and issue reference provide sufficient context for reviewers.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Title check ✅ Passed The title clearly summarizes the main change: adding a new gperf package manifest file at version 3.1-6, which aligns with the raw summary and PR objectives.
✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

gperf

  • Lint
  • Description
  • License
  • Hashes

Check the full log for details.

@aliesbelik
Copy link
Collaborator

Duplicates ScoopInstaller/Main#6888.

@wentywenty
Copy link
Author

wentywenty commented Oct 21, 2025

Duplicates ScoopInstaller/Main#6888.

I close it

@wentywenty
Copy link
Author

/verify

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

gperf

  • Lint
  • Description
  • License
  • Hashes

Check the full log for details.

@wentywenty wentywenty changed the title gperf: add version 3.1 gperf: add version 3.1-6 Oct 22, 2025
@wentywenty
Copy link
Author

/verify

@github-actions
Copy link
Contributor

Your changes did not pass all checks.

Please address the issues in the manifest and comment starting with /verify to rerun the checks.

gperf

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c9d12eb and e1b0747.

📒 Files selected for processing (1)
  • bucket/gperf.json (1 hunks)
🔇 Additional comments (3)
bucket/gperf.json (3)

1-31: Clarify the status of the duplicate PR issue before merging.

The PR objectives note that reviewer aliesbelik flagged this as a duplicate of ScoopInstaller/Main#6888, and you acknowledged this. Verify whether:

  1. The Main repository PR has been closed/abandoned
  2. This PR in Extras is the intended location (and the Main PR should be closed)
  3. Whether this PR should proceed or be consolidated with the Main PR

This should be resolved before approval to prevent duplicate package entries across repositories.


5-5: GNU gperf 3.1 is released under GPL-3 or later, and the SPDX identifier "GPL-3.0-or-later" correctly represents this license. The specified license in the code is accurate and properly aligned with the GNU gperf project's actual licensing.


17-21: Regex pattern verified and working correctly.

The checkver regex successfully extracts version 3.1 and package release 6 from the MSYS2 PKGBUILD file, producing the expected combined format 3.1-6. No issues detected.

@wentywenty
Copy link
Author

/verify

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

gperf

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@wentywenty
Copy link
Author

i`m ready

@z-Fng z-Fng removed the not ready label Oct 28, 2025
@z-Fng z-Fng changed the title gperf: add version 3.1-6 gperf: Add version 3.1-6 Jan 6, 2026
@z-Fng z-Fng added not-meet-criteria This package doesn't fully meet the essential criteria to be accepted in Extras bucket. and removed not-meet-criteria This package doesn't fully meet the essential criteria to be accepted in Extras bucket. labels Jan 6, 2026
@z-Fng
Copy link
Member

z-Fng commented Jan 6, 2026

Closing this PR as per #16425 (comment).

@z-Fng z-Fng closed this Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request]: gperf

4 participants