zulufx25*: add version 25.32.21 (jdk and jre)#584
zulufx25*: add version 25.32.21 (jdk and jre)#584minichiello wants to merge 1 commit intoScoopInstaller:masterfrom
Conversation
WalkthroughTwo new package manifests are added for Zulu OpenJFX distributions (versions 25.32.21) targeting Windows x64 systems. Both files define metadata, download sources, extraction parameters, environment variable configuration, and automated version checking/update rules via Azul's metadata API. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with zulufx25-jdk
zulufx25-jre
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@bucket/zulufx25-jdk.json`:
- Around line 20-25: The checkver block's URL in the checkver object leaves the
java_version parameter empty which breaks Azul API queries; update the "url"
value inside the checkver object (the URL string used by checkver) to set
java_version=25 (e.g., replace "java_version=" with "java_version=25") so the
check for the zulufx25-jdk release returns correct results; target the
"checkver" -> "url" string in the zulufx25-jdk.json file.
- Around line 26-37: The autoupdate hash URL in the "autoupdate" ->
"architecture" -> "64bit" block contains an empty java_version parameter
("java_version=") which prevents SHA-256 retrieval; update that URL's query to
use "java_version=25" so it matches the package version used by this manifest
(change the java_version value in the hash URL string in zulufx25-jdk.json to
25, mirroring the pattern used in zulufx22-jdk.json).
In `@bucket/zulufx25-jre.json`:
- Around line 26-37: Update the autoupdate hash URL to include the correct Java
version: change the query parameter in the autoupdate -> architecture -> "64bit"
-> hash.url from "java_version=" to "java_version=25" so the Azul API returns
the SHA-256 hash for this JRE package.
- Around line 20-25: The checkver block's URL has an empty java_version
parameter which breaks Azul API queries; update the "checkver" -> "url" value to
include java_version=25 (e.g., replace "java_version=" with "java_version=25")
so the check uses Java 25, keeping the rest of the URL, the "jsonpath" and the
existing "regex"
("(?<name>zulu(?<version>[\\d.]+)-ca-fx-jre(?<java>[\\d.]+)-win)_x64.zip") and
"replace" behavior intact.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: bed0bd50-56d5-46fb-bc36-4fd155fea5fa
📒 Files selected for processing (2)
bucket/zulufx25-jdk.jsonbucket/zulufx25-jre.json
| "checkver": { | ||
| "url": "https://api.azul.com/metadata/v1/zulu/packages/?java_version=&os=windows&arch=x64&archive_type=zip&java_package_type=jdk&javafx_bundled=true&crac_supported=false&release_type=PSU&latest=true&include_fields=sha256_hash&page_size=1", | ||
| "jsonpath": "$..download_url", | ||
| "regex": "(?<name>zulu(?<version>[\\d.]+)-ca-fx-jdk(?<java>[\\d.]+)-win)_x64.zip", | ||
| "replace": "${version}" | ||
| }, |
There was a problem hiding this comment.
Critical: Empty java_version parameter will break version checking.
The checkver URL has java_version= (empty) at line 21, which will cause the Azul API call to fail or return incorrect results. Based on the version 25.32.21 and the pattern established in bucket/zulufx22-jdk.json, this should be java_version=25.
🔧 Proposed fix
- "url": "https://api.azul.com/metadata/v1/zulu/packages/?java_version=&os=windows&arch=x64&archive_type=zip&java_package_type=jdk&javafx_bundled=true&crac_supported=false&release_type=PSU&latest=true&include_fields=sha256_hash&page_size=1",
+ "url": "https://api.azul.com/metadata/v1/zulu/packages/?java_version=25&os=windows&arch=x64&archive_type=zip&java_package_type=jdk&javafx_bundled=true&crac_supported=false&release_type=PSU&latest=true&include_fields=sha256_hash&page_size=1",As per the pattern in bucket/zulufx22-jdk.json (lines 20-25), which uses java_version=22 for the corresponding Java 22 distribution.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@bucket/zulufx25-jdk.json` around lines 20 - 25, The checkver block's URL in
the checkver object leaves the java_version parameter empty which breaks Azul
API queries; update the "url" value inside the checkver object (the URL string
used by checkver) to set java_version=25 (e.g., replace "java_version=" with
"java_version=25") so the check for the zulufx25-jdk release returns correct
results; target the "checkver" -> "url" string in the zulufx25-jdk.json file.
| "autoupdate": { | ||
| "architecture": { | ||
| "64bit": { | ||
| "url": "https://cdn.azul.com/zulu/bin/$matchName_x64.zip", | ||
| "extract_dir": "$matchName_x64", | ||
| "hash": { | ||
| "url": "https://api.azul.com/metadata/v1/zulu/packages/?java_version=&os=windows&arch=x64&archive_type=zip&java_package_type=jdk&javafx_bundled=true&crac_supported=false&release_type=PSU&latest=true&include_fields=sha256_hash&page_size=1", | ||
| "jp": "$..sha256_hash" | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Critical: Empty java_version parameter will break hash retrieval.
The autoupdate hash URL has java_version= (empty) at line 32, which will prevent the SHA-256 hash from being retrieved from the Azul API during automated updates. This should be java_version=25 to match the package version.
🔧 Proposed fix
- "url": "https://api.azul.com/metadata/v1/zulu/packages/?java_version=&os=windows&arch=x64&archive_type=zip&java_package_type=jdk&javafx_bundled=true&crac_supported=false&release_type=PSU&latest=true&include_fields=sha256_hash&page_size=1",
+ "url": "https://api.azul.com/metadata/v1/zulu/packages/?java_version=25&os=windows&arch=x64&archive_type=zip&java_package_type=jdk&javafx_bundled=true&crac_supported=false&release_type=PSU&latest=true&include_fields=sha256_hash&page_size=1",As per the pattern in bucket/zulufx22-jdk.json (lines 26-37), which uses java_version=22 in the autoupdate hash URL.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@bucket/zulufx25-jdk.json` around lines 26 - 37, The autoupdate hash URL in
the "autoupdate" -> "architecture" -> "64bit" block contains an empty
java_version parameter ("java_version=") which prevents SHA-256 retrieval;
update that URL's query to use "java_version=25" so it matches the package
version used by this manifest (change the java_version value in the hash URL
string in zulufx25-jdk.json to 25, mirroring the pattern used in
zulufx22-jdk.json).
| "checkver": { | ||
| "url": "https://api.azul.com/metadata/v1/zulu/packages/?java_version=&os=windows&arch=x64&archive_type=zip&java_package_type=jre&javafx_bundled=true&crac_supported=false&release_type=PSU&latest=true&include_fields=sha256_hash&page_size=1", | ||
| "jsonpath": "$..download_url", | ||
| "regex": "(?<name>zulu(?<version>[\\d.]+)-ca-fx-jre(?<java>[\\d.]+)-win)_x64.zip", | ||
| "replace": "${version}" | ||
| }, |
There was a problem hiding this comment.
Critical: Empty java_version parameter will break version checking.
The checkver URL has java_version= (empty) at line 21, which will cause the Azul API call to fail or return incorrect results. Based on the version 25.32.21 and the pattern established in bucket/zulufx22-jre.json, this should be java_version=25.
🔧 Proposed fix
- "url": "https://api.azul.com/metadata/v1/zulu/packages/?java_version=&os=windows&arch=x64&archive_type=zip&java_package_type=jre&javafx_bundled=true&crac_supported=false&release_type=PSU&latest=true&include_fields=sha256_hash&page_size=1",
+ "url": "https://api.azul.com/metadata/v1/zulu/packages/?java_version=25&os=windows&arch=x64&archive_type=zip&java_package_type=jre&javafx_bundled=true&crac_supported=false&release_type=PSU&latest=true&include_fields=sha256_hash&page_size=1",As per the pattern in bucket/zulufx22-jre.json (lines 20-25), which uses java_version=22 for the corresponding Java 22 distribution.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "checkver": { | |
| "url": "https://api.azul.com/metadata/v1/zulu/packages/?java_version=&os=windows&arch=x64&archive_type=zip&java_package_type=jre&javafx_bundled=true&crac_supported=false&release_type=PSU&latest=true&include_fields=sha256_hash&page_size=1", | |
| "jsonpath": "$..download_url", | |
| "regex": "(?<name>zulu(?<version>[\\d.]+)-ca-fx-jre(?<java>[\\d.]+)-win)_x64.zip", | |
| "replace": "${version}" | |
| }, | |
| "checkver": { | |
| "url": "https://api.azul.com/metadata/v1/zulu/packages/?java_version=25&os=windows&arch=x64&archive_type=zip&java_package_type=jre&javafx_bundled=true&crac_supported=false&release_type=PSU&latest=true&include_fields=sha256_hash&page_size=1", | |
| "jsonpath": "$..download_url", | |
| "regex": "(?<name>zulu(?<version>[\\d.]+)-ca-fx-jre(?<java>[\\d.]+)-win)_x64.zip", | |
| "replace": "${version}" | |
| }, |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@bucket/zulufx25-jre.json` around lines 20 - 25, The checkver block's URL has
an empty java_version parameter which breaks Azul API queries; update the
"checkver" -> "url" value to include java_version=25 (e.g., replace
"java_version=" with "java_version=25") so the check uses Java 25, keeping the
rest of the URL, the "jsonpath" and the existing "regex"
("(?<name>zulu(?<version>[\\d.]+)-ca-fx-jre(?<java>[\\d.]+)-win)_x64.zip") and
"replace" behavior intact.
| "autoupdate": { | ||
| "architecture": { | ||
| "64bit": { | ||
| "url": "https://cdn.azul.com/zulu/bin/$matchName_x64.zip", | ||
| "extract_dir": "$matchName_x64", | ||
| "hash": { | ||
| "url": "https://api.azul.com/metadata/v1/zulu/packages/?java_version=&os=windows&arch=x64&archive_type=zip&java_package_type=jre&javafx_bundled=true&crac_supported=false&release_type=PSU&latest=true&include_fields=sha256_hash&page_size=1", | ||
| "jp": "$..sha256_hash" | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Critical: Empty java_version parameter will break hash retrieval.
The autoupdate hash URL has java_version= (empty) at line 32, which will prevent the SHA-256 hash from being retrieved from the Azul API during automated updates. This should be java_version=25 to match the package version.
🔧 Proposed fix
"url": "https://api.azul.com/metadata/v1/zulu/packages/?java_version=&os=windows&arch=x64&archive_type=zip&java_package_type=jre&javafx_bundled=true&crac_supported=false&release_type=PSU&latest=true&include_fields=sha256_hash&page_size=1",
+ "url": "https://api.azul.com/metadata/v1/zulu/packages/?java_version=25&os=windows&arch=x64&archive_type=zip&java_package_type=jre&javafx_bundled=true&crac_supported=false&release_type=PSU&latest=true&include_fields=sha256_hash&page_size=1",As per the pattern in bucket/zulufx22-jre.json (lines 26-37), which uses java_version=22 in the autoupdate hash URL.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "autoupdate": { | |
| "architecture": { | |
| "64bit": { | |
| "url": "https://cdn.azul.com/zulu/bin/$matchName_x64.zip", | |
| "extract_dir": "$matchName_x64", | |
| "hash": { | |
| "url": "https://api.azul.com/metadata/v1/zulu/packages/?java_version=&os=windows&arch=x64&archive_type=zip&java_package_type=jre&javafx_bundled=true&crac_supported=false&release_type=PSU&latest=true&include_fields=sha256_hash&page_size=1", | |
| "jp": "$..sha256_hash" | |
| } | |
| } | |
| } | |
| } | |
| "autoupdate": { | |
| "architecture": { | |
| "64bit": { | |
| "url": "https://cdn.azul.com/zulu/bin/$matchName_x64.zip", | |
| "extract_dir": "$matchName_x64", | |
| "hash": { | |
| "url": "https://api.azul.com/metadata/v1/zulu/packages/?java_version=25&os=windows&arch=x64&archive_type=zip&java_package_type=jre&javafx_bundled=true&crac_supported=false&release_type=PSU&latest=true&include_fields=sha256_hash&page_size=1", | |
| "jp": "$..sha256_hash" | |
| } | |
| } | |
| } | |
| } |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@bucket/zulufx25-jre.json` around lines 26 - 37, Update the autoupdate hash
URL to include the correct Java version: change the query parameter in the
autoupdate -> architecture -> "64bit" -> hash.url from "java_version=" to
"java_version=25" so the Azul API returns the SHA-256 hash for this JRE package.
1 participant
Add:
zulufx25-jdk
zulufx25-jre
Summary by CodeRabbit
New Features