Skip to content

Commit 6d95eaf

Browse files
committed
chore: fix PR comments
1 parent 2dcd30f commit 6d95eaf

File tree

4 files changed

+19
-23
lines changed

4 files changed

+19
-23
lines changed

packages/ui-webc/src/components/tabs-tab/readme.md

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,6 @@
33
<!-- Auto Generated Below -->
44

55

6-
## Properties
7-
8-
| Property | Attribute | Description | Type | Default |
9-
| -------- | --------- | ----------- | --------- | ------- |
10-
| `active` | `active` | | `boolean` | `false` |
11-
12-
136
----------------------------------------------
147

158
*Built with [StencilJS](https://stenciljs.com/)*

packages/ui-webc/src/components/tabs-tab/tabs-tab.tsx

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Component, h, Prop } from "@stencil/core";
1+
import { Component, h } from "@stencil/core";
22

33
@Component({
44
tag: "scout-tabs-tab",
@@ -8,9 +8,6 @@ import { Component, h, Prop } from "@stencil/core";
88
},
99
})
1010
export class ScoutTabsTab {
11-
@Prop()
12-
active: boolean = false;
13-
1411
render() {
1512
return (
1613
<button class="button-native" type="button">

packages/ui-webc/src/components/tabs/readme.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,20 +10,20 @@ of which tab is active and displays an indicator under the active tab. Use
1010
`ScoutTabsTab` components to define the individual tabs.
1111

1212
Currently there is no support for navigational tabs. Navigation has to be
13-
handled programatically for now.
13+
handled programmatically for now.
1414

1515
## Properties
1616

17-
| Property | Attribute | Description | Type | Default |
18-
| -------- | --------- | ----------- | -------- | ------- |
19-
| `value` | `value` | | `number` | `0` |
17+
| Property | Attribute | Description | Type | Default |
18+
| -------- | --------- | --------------------------------------------- | -------- | ------- |
19+
| `value` | `value` | Zero-based index of the currently active tab. | `number` | `0` |
2020

2121

2222
## Events
2323

24-
| Event | Description | Type |
25-
| ------------- | ----------- | --------------------------------- |
26-
| `scoutChange` | | `CustomEvent<{ value: number; }>` |
24+
| Event | Description | Type |
25+
| ------------- | --------------------------------------------------------------------------------------------------------------------------------------------------- | --------------------------------- |
26+
| `scoutChange` | Emitted when the active tab changes as a result of a user click. The `value` in the event detail is the zero-based index of the newly selected tab. | `CustomEvent<{ value: number; }>` |
2727

2828

2929
----------------------------------------------

packages/ui-webc/src/components/tabs/tabs.tsx

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import {
1818
* `ScoutTabsTab` components to define the individual tabs.
1919
*
2020
* Currently there is no support for navigational tabs. Navigation has to be
21-
* handled programatically for now.
21+
* handled programmatically for now.
2222
*/
2323
@Component({
2424
tag: "scout-tabs",
@@ -30,18 +30,24 @@ import {
3030
export class ScoutTabs implements ComponentInterface {
3131
@Element() el: HTMLElement;
3232

33+
/**
34+
* Zero-based index of the currently active tab.
35+
*/
3336
@Prop()
3437
public value: number = 0;
3538

39+
/**
40+
* Emitted when the active tab changes as a result of a user click.
41+
* The `value` in the event detail is the zero-based index of the newly selected tab.
42+
*/
43+
@Event()
44+
public scoutChange: EventEmitter<{ value: number }>;
45+
3646
@State()
3747
private widths: number[] = [];
38-
3948
@State()
4049
private lefts: number[] = [];
4150

42-
@Event()
43-
public scoutChange: EventEmitter<{ value: number }>;
44-
4551
render() {
4652
return (
4753
<Host>

0 commit comments

Comments
 (0)