Skip to content

feat: add conditional node to the smart_scraper_graph #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 16, 2024
Merged

feat: add conditional node to the smart_scraper_graph #754

merged 3 commits into from
Oct 16, 2024

Conversation

@ekinsenler
Copy link
Contributor

@ekinsenler ekinsenler commented Oct 15, 2024

implemented a structured way to parse the graph config and map to the conditions. Currently, this is only to check None returned answers, Future implementation might involve the check for the schema match against the returned result.

graph_config = {
    "llm": {
        "api_key": os.getenv("GROQ_APIKEY"),
        "model": "groq/gemma-7b-it",
    },
    "verbose": True,
    "headless": True,
    "reattempt": True
}

VinciGit00
VinciGit00 reviewed Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@VinciGit00 VinciGit00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can you add to the pyproject.toml the requirement and in examples/extras an example?

VinciGit00
VinciGit00 approved these changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@VinciGit00 VinciGit00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok now is ok thank you

@VinciGit00 VinciGit00 changed the base branch from main to pre/beta October 16, 2024 15:52
@VinciGit00 VinciGit00 merged commit aaa011c into ScrapeGraphAI:pre/beta Oct 16, 2024
3 checks passed
@github-actions
Copy link

github-actions bot commented Oct 16, 2024

🎉 This PR is included in version 1.27.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Oct 26, 2024

🎉 This PR is included in version 1.27.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VinciGit00 VinciGit00 VinciGit00 approved these changes

Assignees

No one assigned

Labels

released on @dev released on @stable

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ekinsenler @VinciGit00