Skip to content

Commit f76e996

Browse files
committed
Add python style optional parameters
1 parent 5749a20 commit f76e996

File tree

2 files changed

+10
-7
lines changed

2 files changed

+10
-7
lines changed

howlongtobeatpy/howlongtobeatpy/HowLongToBeat.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ async def async_search(self, game_name: str, search_modifiers: SearchModifiers =
4949
return None
5050
html_result = await HTMLRequests.send_async_web_request(game_name, search_modifiers)
5151
if html_result is not None:
52-
return self.__parse_web_result(game_name, html_result, None, similarity_case_sensitive)
52+
return self.__parse_web_result(game_name, html_result, input_similarity_case_sensitive = similarity_case_sensitive)
5353
return None
5454

5555
def search(self, game_name: str, search_modifiers: SearchModifiers = SearchModifiers.NONE,
@@ -65,7 +65,7 @@ def search(self, game_name: str, search_modifiers: SearchModifiers = SearchModif
6565
return None
6666
html_result = HTMLRequests.send_web_request(game_name, search_modifiers)
6767
if html_result is not None:
68-
return self.__parse_web_result(game_name, html_result, None, similarity_case_sensitive)
68+
return self.__parse_web_result(game_name, html_result, input_similarity_case_sensitive = similarity_case_sensitive)
6969
return None
7070

7171
# ------------------------------------------
@@ -118,7 +118,7 @@ def search_from_id(self, game_id: int):
118118
# ------------------------------------------
119119

120120
def __parse_web_result(self, game_name: str, html_result, game_id=None,
121-
similarity_case_sensitive: bool = True):
121+
input_similarity_case_sensitive: bool = True):
122122
"""
123123
Function that call the HTML parser to get the data
124124
@param game_name: The original game name received as input
@@ -128,11 +128,11 @@ def __parse_web_result(self, game_name: str, html_result, game_id=None,
128128
"""
129129
if game_id is None:
130130
parser = JSONResultParser(game_name, HTMLRequests.GAME_URL, self.minimum_similarity, game_id,
131-
similarity_case_sensitive, self.auto_filter_times)
131+
input_similarity_case_sensitive, self.auto_filter_times)
132132
else:
133-
# If the search is by id, ignore class minimum_similarity and set it to 0.0
133+
# If the search is by id, minimum_similarity and similarity_case_sensitive are reset inside
134134
# The result is filtered by ID anyway, so the similarity shouldn't count too much
135-
# Also ignore similarity_case_sensitive and leave default value
136-
parser = JSONResultParser(game_name, HTMLRequests.GAME_URL, 0.0, game_id, False, self.auto_filter_times)
135+
parser = JSONResultParser(game_name, HTMLRequests.GAME_URL, self.minimum_similarity,
136+
input_game_id = game_id, input_auto_filter_times = self.auto_filter_times)
137137
parser.parse_json_result(html_result)
138138
return parser.results

howlongtobeatpy/howlongtobeatpy/JSONResultParser.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,9 @@ def __init__(self, input_game_name: str, input_game_url: str,
2828
self.similarity_case_sensitive = input_similarity_case_sensitive
2929
self.auto_filter_times = input_auto_filter_times
3030
self.game_id = input_game_id
31+
if self.game_id is not None:
32+
self.minimum_similarity = 0
33+
self.similarity_case_sensitive = False
3134
self.base_game_url = input_game_url
3235
# Init object
3336
self.game_name = input_game_name

0 commit comments

Comments
 (0)