fix: CI failures — remove JS lint, fix static files, format code

- Remove obsolete javascript-lint.yaml (no package.json after React removal)
- Remove TypeScript test job from docker-test.yaml (no npm in container)
- Simplify test-runner.yml to Python-only, add migrate + collectstatic
  before integration tests to fix missing staticfiles manifest
- Fix settings.py to create config directory before writing screenly.conf
- Apply ruff formatting to all Python files

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: vpetersson

.github/workflows/docker-test.yaml

@@ -36,14 +36,7 @@ on:
   workflow_call:
 
 jobs:
-  run-typescript-tests:
-    uses: ./.github/workflows/test-runner.yml
-    with:
-      test-type: 'typescript'
-      python-version: '3.11'
-
   run-python-tests:
     uses: ./.github/workflows/test-runner.yml
     with:
-      test-type: 'python'
       python-version: '3.11'

.github/workflows/javascript-lint.yaml

@@ -3,10 +3,6 @@ name: Test Runner
 on:
   workflow_call:
     inputs:
-      test-type:
-        description: 'Type of tests to run (typescript or python)'
-        required: true
-        type: string
       python-version:
         description: 'Python version to use'
         required: false
@@ -15,7 +11,7 @@ on:
 
 jobs:
   run-tests:
-    name: Run ${{ inputs.test-type }} tests
+    name: Run python tests
     runs-on: ubuntu-24.04
     env:
       COMPOSE_FILE: docker-compose.test.yml
@@ -49,34 +45,26 @@ jobs:
         run: |
           docker compose up -d --build
 
-      - name: Run TypeScript tests
-        if: inputs.test-type == 'typescript'
-        run: |
-          docker compose exec anthias-test \
-            npm install
-          docker compose exec anthias-test \
-            npm run test
-
       - name: Run Python unit tests
-        if: inputs.test-type == 'python'
         run: |
           docker compose exec anthias-test \
             python -m pytest tests/ -m "not integration" --ignore=tests/test_scheduler.py --ignore=tests/test_viewer.py -x
 
       - name: Setup integration test environment
-        if: inputs.test-type == 'python'
         run: |
           docker compose exec anthias-test \
             bash ./bin/prepare_test_environment.sh
+          docker compose exec anthias-test \
+            python -m django migrate --run-syncdb
+          docker compose exec anthias-test \
+            python -m django collectstatic --noinput --clear
 
       - name: Run Python integration tests
-        if: inputs.test-type == 'python'
         run: |
           docker compose exec anthias-test \
             python -m pytest tests/test_app.py -m integration -v
 
       - name: Upload coverage reports to Codecov
-        if: inputs.test-type == 'python'
         uses: codecov/codecov-action@v5
         env:
           CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

.github/workflows/test-runner.yml

@@ -15,9 +15,7 @@ def connect(self) -> None:
         if channel_layer is not None:
             from asgiref.sync import async_to_sync
 
-            async_to_sync(channel_layer.group_add)(
-                'viewer', self.channel_name
-            )
+            async_to_sync(channel_layer.group_add)('viewer', self.channel_name)
         logger.info('Viewer WebSocket connected')
 
     def disconnect(self, close_code: int) -> None:
@@ -33,10 +31,14 @@ def disconnect(self, close_code: int) -> None:
         logger.info('Viewer WebSocket disconnected')
 
     def viewer_command(self, event: dict) -> None:
-        self.send(text_data=json.dumps({
-            'command': event['command'],
-            'data': event.get('data'),
-        }))
+        self.send(
+            text_data=json.dumps(
+                {
+                    'command': event['command'],
+                    'data': event.get('data'),
+                }
+            )
+        )
 
 
 class UIConsumer(WebsocketConsumer):
@@ -48,9 +50,7 @@ def connect(self) -> None:
         if channel_layer is not None:
             from asgiref.sync import async_to_sync
 
-            async_to_sync(channel_layer.group_add)(
-                'ui', self.channel_name
-            )
+            async_to_sync(channel_layer.group_add)('ui', self.channel_name)
 
     def disconnect(self, close_code: int) -> None:
         from channels.layers import get_channel_layer
@@ -59,9 +59,7 @@ def disconnect(self, close_code: int) -> None:
         if channel_layer is not None:
             from asgiref.sync import async_to_sync
 
-            async_to_sync(channel_layer.group_discard)(
-                'ui', self.channel_name
-            )
+            async_to_sync(channel_layer.group_discard)('ui', self.channel_name)
 
     def ui_update(self, event: dict) -> None:
         self.send(text_data=json.dumps(event.get('data', {})))

anthias_app/consumers.py

@@ -4,7 +4,8 @@
 
 
 def send_to_viewer(
-    command: str, data: str | None = None,
+    command: str,
+    data: str | None = None,
 ) -> None:
     try:
         from asgiref.sync import async_to_sync

anthias_app/messaging.py

@@ -69,7 +69,9 @@ def shutdown_anthias() -> None:
 
 
 def _run_periodic(
-    func, interval_seconds: int, name: str,
+    func,
+    interval_seconds: int,
+    name: str,
 ) -> threading.Thread:
     def loop():
         while True:

anthias_app/tasks.py

@@ -24,9 +24,7 @@ def schedule(request):
 @authorized
 def asset_tables(request):
     context = _get_asset_context()
-    return render(
-        request, 'anthias_app/assets/tables.html', context
-    )
+    return render(request, 'anthias_app/assets/tables.html', context)
 
 
 @authorized

anthias_app/views_ui.py

@@ -9,7 +9,9 @@
 
 from anthias_django.routing import websocket_urlpatterns  # noqa: E402
 
-application = ProtocolTypeRouter({
-    'http': django_asgi_app,
-    'websocket': URLRouter(websocket_urlpatterns),
-})
+application = ProtocolTypeRouter(
+    {
+        'http': django_asgi_app,
+        'websocket': URLRouter(websocket_urlpatterns),
+    }
+)

anthias_django/asgi.py

@@ -22,9 +22,7 @@ def api_client():
 
 
 def _create_asset(api_client, data):
-    return api_client.post(
-        ASSET_LIST_V2_URL, data=data, format='json'
-    ).data
+    return api_client.post(ASSET_LIST_V2_URL, data=data, format='json').data
 
 
 @pytest.mark.django_db
@@ -69,14 +67,8 @@ def test_create_video_asset_with_non_zero_duration_fails(
         response = api_client.post(
             ASSET_LIST_V2_URL, data=test_data, format='json'
         )
-        assert (
-            response.status_code
-            == status.HTTP_500_INTERNAL_SERVER_ERROR
-        )
-        assert (
-            'Duration must be zero for video assets'
-            in str(response.data)
-        )
+        assert response.status_code == status.HTTP_500_INTERNAL_SERVER_ERROR
+        assert 'Duration must be zero for video assets' in str(response.data)
         assert mock_rename.call_count == 1
         assert mock_validate_uri.call_count == 1
 

api/tests/test_assets.py

@@ -89,9 +89,7 @@ def test_patch_invalid_auth_backend(
         )
         assert response.status_code == status.HTTP_400_BAD_REQUEST
         assert 'auth_backend' in response.data
-        assert 'is not a valid choice' in str(
-            response.data['auth_backend']
-        )
+        assert 'is not a valid choice' in str(response.data['auth_backend'])
         settings_mock.load.assert_not_called()
         settings_mock.save.assert_not_called()
 
@@ -133,10 +131,7 @@ def test_patch_success(
             device_settings_url, data=data, format='json'
         )
         assert response.status_code == status.HTTP_200_OK
-        assert (
-            response.data['message']
-            == 'Settings were successfully saved.'
-        )
+        assert response.data['message'] == 'Settings were successfully saved.'
         settings_mock.load.assert_called_once()
         settings_mock.save.assert_called_once()
         assert settings_mock.__setitem__.call_count == 5
@@ -214,21 +209,12 @@ def test_enable_basic_auth(
             device_settings_url, data=data, format='json'
         )
         assert response.status_code == status.HTTP_200_OK
-        assert (
-            response.data['message']
-            == 'Settings were successfully saved.'
-        )
+        assert response.data['message'] == 'Settings were successfully saved.'
         settings_mock.load.assert_called_once()
         settings_mock.save.assert_called_once()
-        settings_mock.__setitem__.assert_any_call(
-            'auth_backend', 'auth_basic'
-        )
-        settings_mock.__setitem__.assert_any_call(
-            'user', 'testuser'
-        )
-        settings_mock.__setitem__.assert_any_call(
-            'password', expected_hashed
-        )
+        settings_mock.__setitem__.assert_any_call('auth_backend', 'auth_basic')
+        settings_mock.__setitem__.assert_any_call('user', 'testuser')
+        settings_mock.__setitem__.assert_any_call('password', expected_hashed)
         send_to_viewer_mock.assert_called_once_with('reload')
 
     @patch('api.views.v2.settings')
@@ -273,15 +259,10 @@ def test_disable_basic_auth(
             device_settings_url, data=data, format='json'
         )
         assert response.status_code == status.HTTP_200_OK
-        assert (
-            response.data['message']
-            == 'Settings were successfully saved.'
-        )
+        assert response.data['message'] == 'Settings were successfully saved.'
         settings_mock.load.assert_called_once()
         settings_mock.save.assert_called_once()
-        settings_mock.__setitem__.assert_any_call(
-            'auth_backend', ''
-        )
+        settings_mock.__setitem__.assert_any_call('auth_backend', '')
         send_to_viewer_mock.assert_called_once_with('reload')
 
         response = api_client.get(device_settings_url)
@@ -324,15 +305,10 @@ def test_patch_default_assets(
             format='json',
         )
         assert response.status_code == status.HTTP_200_OK
-        assert (
-            response.data['message']
-            == 'Settings were successfully saved.'
-        )
+        assert response.data['message'] == 'Settings were successfully saved.'
         settings_mock.load.assert_called_once()
         settings_mock.save.assert_called_once()
-        settings_mock.__setitem__.assert_any_call(
-            'default_assets', True
-        )
+        settings_mock.__setitem__.assert_any_call('default_assets', True)
         add_default_assets_mock.assert_called_once()
         remove_default_assets_mock.assert_not_called()
         send_to_viewer_mock.assert_called_once_with('reload')
@@ -367,15 +343,10 @@ def test_patch_default_assets(
             format='json',
         )
         assert response.status_code == status.HTTP_200_OK
-        assert (
-            response.data['message']
-            == 'Settings were successfully saved.'
-        )
+        assert response.data['message'] == 'Settings were successfully saved.'
         settings_mock.load.assert_called_once()
         settings_mock.save.assert_called_once()
-        settings_mock.__setitem__.assert_any_call(
-            'default_assets', False
-        )
+        settings_mock.__setitem__.assert_any_call('default_assets', False)
         remove_default_assets_mock.assert_called_once()
         add_default_assets_mock.assert_not_called()
         send_to_viewer_mock.assert_called_once_with('reload')
@@ -390,20 +361,14 @@ def setup(self):
 
     @patch('api.views.v2.is_balena_app')
     @patch('api.views.v2.getenv')
-    def test_balena_environment(
-        self, mock_getenv, mock_is_balena
-    ):
+    def test_balena_environment(self, mock_getenv, mock_is_balena):
         mock_is_balena.side_effect = lambda: True
         mock_getenv.side_effect = lambda x: {
             'BALENA_DEVICE_UUID': 'test-device-uuid',
             'BALENA_APP_ID': 'test-app-id',
             'BALENA_APP_NAME': 'test-app-name',
-            'BALENA_SUPERVISOR_VERSION': (
-                'test-supervisor-version'
-            ),
-            'BALENA_HOST_OS_VERSION': (
-                'test-host-os-version'
-            ),
+            'BALENA_SUPERVISOR_VERSION': ('test-supervisor-version'),
+            'BALENA_HOST_OS_VERSION': ('test-host-os-version'),
             'BALENA_DEVICE_NAME_AT_INIT': 'test-device-name',
         }.get(x)
 
@@ -414,12 +379,8 @@ def test_balena_environment(
             'balena_device_id': 'test-device-uuid',
             'balena_app_id': 'test-app-id',
             'balena_app_name': 'test-app-name',
-            'balena_supervisor_version': (
-                'test-supervisor-version'
-            ),
-            'balena_host_os_version': (
-                'test-host-os-version'
-            ),
+            'balena_supervisor_version': ('test-supervisor-version'),
+            'balena_host_os_version': ('test-host-os-version'),
             'balena_device_name_at_init': 'test-device-name',
         }