Added AsyncDataSource and specified it as the parameter for AsyncConnector::fetch().

Author: Bilge

src/Connector/AsyncConnector.php

@@ -13,9 +13,9 @@ interface AsyncConnector
     /**
      * Fetches data asynchronously from the specified data source.
      *
-     * @param DataSource $source Data source.
+     * @param AsyncDataSource $source Data source.
      *
      * @return Promise<mixed> Data.
      */
-    public function fetchAsync(DataSource $source): Promise;
+    public function fetchAsync(AsyncDataSource $source): Promise;
 }

src/Connector/AsyncDataSource.php

@@ -0,0 +1,21 @@
+<?php
+declare(strict_types=1);
+
+namespace ScriptFUSION\Porter\Connector;
+
+use Amp\Promise;
+
+/**
+ * Specifies a data source and the necessary parameters required to fetch it asynchronously.
+ */
+interface AsyncDataSource
+{
+    /**
+     * Computes the hash code for this object's state. The computed hash must be the same when the object state
+     * is unchanged or is still considered equivalent for cache key purposes, otherwise the hash code must always
+     * be different for different states.
+     *
+     * @return Promise<string> Hash code.
+     */
+    public function computeHash(): Promise;
+}

src/Connector/ImportConnector.php

@@ -87,11 +87,11 @@ function () use ($source) {
     /**
      * Fetches data asynchronously from the specified data source.
      *
-     * @param DataSource $source Data source.
+     * @param AsyncDataSource $source Data source.
      *
      * @return Promise<mixed> Data.
      */
-    public function fetchAsync(DataSource $source): Promise
+    public function fetchAsync(AsyncDataSource $source): Promise
     {
         return retryAsync(
             $this->maxFetchAttempts,

src/Specification/Specification.php

@@ -23,9 +23,7 @@ abstract class Specification
 
     private $maxFetchAttempts = self::DEFAULT_FETCH_ATTEMPTS;
 
-    /**
-     * @var RecoverableExceptionHandler
-     */
+    /** @var RecoverableExceptionHandler */
     private $recoverableExceptionHandler;
 
     public function __construct()

test/Integration/Connector/ImportConnectorTest.php

@@ -6,6 +6,7 @@
 use Mockery\Adapter\Phpunit\MockeryPHPUnitIntegration;
 use Mockery\MockInterface;
 use PHPUnit\Framework\TestCase;
+use ScriptFUSION\Porter\Connector\AsyncDataSource;
 use ScriptFUSION\Porter\Connector\Connector;
 use ScriptFUSION\Porter\Connector\DataSource;
 use ScriptFUSION\Porter\Connector\ImportConnector;
@@ -28,11 +29,15 @@ final class ImportConnectorTest extends TestCase
     /** @var DataSource|MockInterface */
     private $source;
 
+    /** @var AsyncDataSource|MockInterface */
+    private $asyncSource;
+
     protected function setUp()
     {
         parent::setUp();
 
         $this->source = \Mockery::mock(DataSource::class);
+        $this->asyncSource = \Mockery::mock(AsyncDataSource::class);
     }
 
     /**
@@ -135,7 +140,7 @@ public function testAsyncUserRecoverableExceptionHandler(): void
         );
 
         try {
-            wait($connector->fetchAsync($this->source));
+            wait($connector->fetchAsync($this->asyncSource));
         } catch (FailingTooHardException $exception) {
             // This is fine.
         }
@@ -158,7 +163,7 @@ public function testAsyncResourceRecoverableExceptionHandler(): void
         $connector->setRecoverableExceptionHandler(self::createAsyncRecoverableExceptionHandler());
 
         try {
-            wait($connector->fetchAsync($this->source));
+            wait($connector->fetchAsync($this->asyncSource));
         } catch (FailingTooHardException $exception) {
             // This is fine.
         }
@@ -183,7 +188,7 @@ public function testAsyncUserAndResourceRecoverableExceptionHandlers(): void
         $connector->setRecoverableExceptionHandler(self::createAsyncRecoverableExceptionHandler());
 
         try {
-            wait($connector->fetchAsync($this->source));
+            wait($connector->fetchAsync($this->asyncSource));
         } catch (FailingTooHardException $exception) {
             // This is fine.
         }

test/MockFactory.php

@@ -9,6 +9,7 @@
 use Amp\Promise;
 use Mockery\MockInterface;
 use ScriptFUSION\Porter\Connector\AsyncConnector;
+use ScriptFUSION\Porter\Connector\AsyncDataSource;
 use ScriptFUSION\Porter\Connector\Connector;
 use ScriptFUSION\Porter\Connector\DataSource;
 use ScriptFUSION\Porter\Connector\ImportConnector;
@@ -72,7 +73,7 @@ public static function mockResource(Provider $provider, \Iterator $return = null
             ->shouldReceive('fetchAsync')
                 ->andReturnUsing(static function (ImportConnector $connector): Iterator {
                     return new Producer(static function (\Closure $emit) use ($connector): \Generator {
-                        yield $emit([yield $connector->fetchAsync(\Mockery::mock(DataSource::class))]);
+                        yield $emit([yield $connector->fetchAsync(\Mockery::mock(AsyncDataSource::class))]);
                     });
                 })
                 ->byDefault()