change on_error to only return message

Author: Elektryk-Andrzej

Code/ContextSystem/Contexts/Control/AttemptStatement.cs

@@ -2,7 +2,6 @@
 using SER.Code.ContextSystem.BaseContexts;
 using SER.Code.ContextSystem.Interfaces;
 using SER.Code.ContextSystem.Structures;
-using SER.Code.Extensions;
 using SER.Code.Helpers.ResultSystem;
 using SER.Code.TokenSystem.Tokens;
 
@@ -12,10 +11,10 @@ namespace SER.Code.ContextSystem.Contexts.Control;
 public class AttemptStatement : StatementContext, IExtendableStatement, IKeywordContext
 {
     public string KeywordName => "attempt";
-    public string Description => "Runs everything inside the statement, and if something throws an exception (error), " +
-                                 "the statement skips everything after it and jumps straight to the " +
-                                 $"{typeof(OnErrorStatement).FriendlyTypeName(true)} " +
-                                 "after it if provided.";
+    public string Description => 
+        "Runs everything inside the statement, and if something throws an exception (error), the error will not " +
+        "terminate the script. If there is an 'on_error' statement, it will be executed.";
+    
     public string[] Arguments => [];
     public string? Example =>
         """

Code/ContextSystem/Contexts/Control/OnErrorStatement.cs

@@ -8,27 +8,28 @@
 using SER.Code.TokenSystem.Tokens.VariableTokens;
 using SER.Code.ValueSystem;
 using SER.Code.VariableSystem.Bases;
-using SER.Code.VariableSystem.Variables;
 
 namespace SER.Code.ContextSystem.Contexts.Control;
 
 [UsedImplicitly]
 public class OnErrorStatement : StatementContext, IStatementExtender, IKeywordContext, IAcceptOptionalVariableDefinitionsContext
 {
     public string KeywordName => "on_error";
-    public string Description => "Catches an exception thrown inside of a " +
-                                 typeof(AttemptStatement).FriendlyTypeName(true);
+    public string Description =>
+        $"Catches an exception thrown inside of a {typeof(AttemptStatement).FriendlyTypeName(true)}";
+    
     public string[] Arguments => [];
-    public string? Example =>
+    public string Example =>
         """
         &collection = EmptyCollection
         attempt
             Print {CollectionFetch &collection 2}
-            # throws because there's nothing at index 2
+            # ERROR: there's nothing at index 2
         on_error
-            with *exception
+            with $message
             
-            Print "Error!: {ExceptionInfo *exception message}"
+            # this will print the error message
+            Print "Error: {$message}"
         end
         """;
 
@@ -45,8 +46,7 @@ public Exception? Exception
             field = value;
         }
     }
-    private VariableToken? _variableToken;
-    private Variable? _variable;
+    private LiteralVariableToken? _variableToken;
 
     public override TryAddTokenRes TryAddToken(BaseToken token)
     {
@@ -62,29 +62,29 @@ public Result SetOptionalVariables(params VariableToken[] variableTokens)
     {
         if (variableTokens.Length > 1)
             return $"Too many arguments provided for {FriendlyName}, only 1 is allowed.";
-        var token = variableTokens.FirstOrDefault();
-        if (token is null) return true;
 
-        if (token is not ReferenceVariableToken)
-            return $"Variable {token.RawRepr} cannot be used for a {FriendlyName} as it's not a " +
-                   $"{typeof(ReferenceVariable).FriendlyTypeName(true)}.";
+        if (variableTokens.First() is not LiteralVariableToken token)
+        {
+            return $"{FriendlyName} only accepts a literal variable.";
+        }
 
         _variableToken = token;
         return true;
     }
 
     protected override IEnumerator<float> Execute()
     {
+        Variable? variable = null;
         if (_variableToken is not null)
         {
-            _variable = Variable.Create(_variableToken.Name, Value.Parse(Exception!, Script));
-            Script.AddLocalVariable(_variable);
+            variable = Variable.Create(_variableToken.Name, Value.Parse(Exception!.Message, Script));
+            Script.AddLocalVariable(variable);
         }
 
         var coro = RunChildren();
         while (coro.MoveNext())
             yield return coro.Current;
 
-        if (_variable is not null) Script.RemoveLocalVariable(_variable);
+        if (variable is not null) Script.RemoveLocalVariable(variable);
     }
 }

Code/MethodSystem/Methods/PlayerVariableMethods/OverlappingMethod.cs

@@ -1,5 +1,4 @@
 using JetBrains.Annotations;
-using LabApi.Features.Wrappers;
 using SER.Code.ArgumentSystem.Arguments;
 using SER.Code.ArgumentSystem.BaseArguments;
 using SER.Code.MethodSystem.BaseMethods.Synchronous;

Code/TokenSystem/Tokens/VariableTokens/LiteralVariableToken.cs

@@ -1,6 +1,5 @@
 using SER.Code.ContextSystem.BaseContexts;
 using SER.Code.ContextSystem.Contexts.VariableDefinition;
-using SER.Code.Helpers.ResultSystem;
 using SER.Code.ScriptSystem;
 using SER.Code.ValueSystem;
 using SER.Code.VariableSystem.Variables;

Code/VariableSystem/Variables/LiteralVariable.cs

@@ -1,5 +1,4 @@
 using SER.Code.Extensions;
-using SER.Code.Helpers.ResultSystem;
 using SER.Code.ValueSystem;
 using SER.Code.VariableSystem.Bases;