fix: update WebSocket build flags for proper string handling and clean up unused variables

Author: SeanChangX

.github/workflows/build-and-release.yml

@@ -39,13 +39,14 @@ jobs:
         run: |
           cd firmware
           # Inject production WebSocket config via build flags
+          # Inner \\\" produces literal \" so the C compiler sees a string literal.
           FLAGS=""
           if [ -n "$QBIT_WS_HOST" ]; then
-            FLAGS="$FLAGS -DWS_HOST=\"$QBIT_WS_HOST\" -DWS_PORT=443"
+            FLAGS="$FLAGS -DWS_HOST=\\\"$QBIT_WS_HOST\\\" -DWS_PORT=443"
             echo "Injected WS_HOST=$QBIT_WS_HOST, WS_PORT=443"
           fi
           if [ -n "$QBIT_WS_API_KEY" ]; then
-            FLAGS="$FLAGS -DWS_API_KEY=\"$QBIT_WS_API_KEY\""
+            FLAGS="$FLAGS -DWS_API_KEY=\\\"$QBIT_WS_API_KEY\\\""
             echo "Injected WS_API_KEY (hidden)"
           fi
           export PLATFORMIO_BUILD_FLAGS="$FLAGS"

firmware/src/main.cpp

@@ -106,7 +106,6 @@ static const char BOOT_MELODY[] =
 using namespace websockets;
 static WebsocketsClient _wsClient;
 static bool             _wsConnected = false;
-static String           _wsUrl;
 static unsigned long    _wsLastReconnect = 0;
 
 // ==========================================================================
@@ -988,8 +987,6 @@ static void wsSendClaimReject() {
 // ArduinoWebsockets library to support setInsecure() on ESP32 and increase
 // the header-read timeout for Cloudflare's large response headers.
 static bool wsConnect() {
-    if (_wsUrl.length() == 0) return false;
-
     // Close any existing connection
     if (_wsClient.available()) {
         _wsClient.close();
@@ -1214,7 +1211,6 @@ void setup() {
     _wsClient.onEvent(wsEvent);
     _wsClient.onMessage(wsMessage);
 
-    _wsUrl = String(WS_PORT == 443 ? "wss://" : "ws://") + WS_HOST + WS_PATH;
     _wsLastReconnect = 0;
     wsConnect();
 

tools/simulate-devices.py

@@ -144,7 +144,7 @@ def main():
 
     for i in range(args.count):
         t = threading.Thread(target=device_thread,
-                     args=(i, url, stop_event, args.auto_claim, args.key),
+                             args=(i, url, stop_event, args.auto_claim, args.key),
                              daemon=True)
         t.start()
         threads.append(t)