Review fixes: expand cargo clean, add binary guard

- Include magnus and serde_magnus in cargo clean (both have
  version-conditional #[cfg(ruby_gte_*)] code that must recompile)
- Add cargo clean before first compilation too (handles stale cache
  from previous release run)
- Abort if no compiled binaries found before packaging gem
- Simplify glob to idiomatic spec.files +=

Author: ZilvinasKucinskas

.github/workflows/release.yml

@@ -83,6 +83,7 @@ jobs:
         env:
           RB_SYS_CARGO_PROFILE: release
         run: |
+          cargo clean -p rb-sys -p magnus -p serde_magnus -p wreq-ruby --release 2>/dev/null || true
           bundle exec rake compile
           mkdir -p lib/wreq_ruby/3.3
           cp lib/wreq_ruby/wreq_ruby.bundle lib/wreq_ruby/3.3/
@@ -96,7 +97,7 @@ jobs:
         env:
           RB_SYS_CARGO_PROFILE: release
         run: |
-          cargo clean -p rb-sys -p wreq-ruby --release
+          cargo clean -p rb-sys -p magnus -p serde_magnus -p wreq-ruby --release
           bundle exec rake compile
           mkdir -p lib/wreq_ruby/3.4
           cp lib/wreq_ruby/wreq_ruby.bundle lib/wreq_ruby/3.4/
@@ -110,7 +111,7 @@ jobs:
         env:
           RB_SYS_CARGO_PROFILE: release
         run: |
-          cargo clean -p rb-sys -p wreq-ruby --release
+          cargo clean -p rb-sys -p magnus -p serde_magnus -p wreq-ruby --release
           bundle exec rake compile
           mkdir -p lib/wreq_ruby/4.0
           cp lib/wreq_ruby/wreq_ruby.bundle lib/wreq_ruby/4.0/

script/build_platform_gem.rb

@@ -19,12 +19,13 @@
 spec = Gem::Specification.load("wreq.gemspec")
 spec.platform = Gem::Platform.new(platform)
 spec.extensions = []
+# Keep in sync with Rakefile cross_compiling block
 spec.required_ruby_version = Gem::Requirement.new(">= 3.3", "< 4.1.dev")
 
 # Add version-specific compiled extensions
-Dir.glob("lib/wreq_ruby/[0-9]*/*.{bundle,so}").each do |path|
-  spec.files << path unless spec.files.include?(path)
-end
+binaries = Dir.glob("lib/wreq_ruby/[0-9]*/*.{bundle,so}")
+abort "No compiled binaries found in lib/wreq_ruby/*/. Did compilation succeed?" if binaries.empty?
+spec.files += binaries
 
 FileUtils.mkdir_p("pkg")
 gem_file = Gem::Package.build(spec)