Skip to content

Commit c5ad03a

Browse files
committed
minor EasyCorp#7149 Update a test related to action groups (javiereguiluz)
This PR was merged into the 4.x branch. Discussion ---------- Update a test related to action groups This test fails in 5.x branch because the CRUD actions used in the global actions example require passing route parameters. So, let's simplify the test. Commits ------- ab85402 Update a test related to action groups
2 parents af40b24 + ab85402 commit c5ad03a

File tree

1 file changed

+23
-18
lines changed

1 file changed

+23
-18
lines changed

tests/TestApplication/src/Controller/ActionGroupsCrudController.php

Lines changed: 23 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,9 @@ public function configureActions(Actions $actions): Actions
3939
->addAction(Action::new('action3', 'Action 3')->linkToCrudAction('delete'));
4040
$group1Global = ActionGroup::new('group1global', 'Global Action Group 1')
4141
->createAsGlobalActionGroup()
42-
->addAction(Action::new('action1', 'Action 1')->linkToCrudAction('edit'))
43-
->addAction(Action::new('action2', 'Action 2')->linkToCrudAction('detail'))
44-
->addAction(Action::new('action3', 'Action 3')->linkToCrudAction('delete'));
42+
->addAction(Action::new('action1', 'Action 1')->linkToCrudAction('aGlobalAction'))
43+
->addAction(Action::new('action2', 'Action 2')->linkToCrudAction('aGlobalAction'))
44+
->addAction(Action::new('action3', 'Action 3')->linkToCrudAction('aGlobalAction'));
4545

4646
// split button with main action
4747
$group2 = ActionGroup::new('group2', 'Action Group 2')
@@ -50,9 +50,9 @@ public function configureActions(Actions $actions): Actions
5050
->addAction(Action::new('action2', 'Action 2')->linkToCrudAction('delete'));
5151
$group2Global = ActionGroup::new('group2global', 'Global Action Group 2')
5252
->createAsGlobalActionGroup()
53-
->addMainAction(Action::new('main_action', 'Main Action')->linkToCrudAction('edit'))
54-
->addAction(Action::new('action1', 'Action 1')->linkToCrudAction('detail'))
55-
->addAction(Action::new('action2', 'Action 2')->linkToCrudAction('delete'));
53+
->addMainAction(Action::new('main_action', 'Main Action')->linkToCrudAction('aGlobalAction'))
54+
->addAction(Action::new('action1', 'Action 1')->linkToCrudAction('aGlobalAction'))
55+
->addAction(Action::new('action2', 'Action 2')->linkToCrudAction('aGlobalAction'));
5656

5757
// action group with headers and dividers
5858
$group3 = ActionGroup::new('group3', 'Action Group 3')
@@ -65,11 +65,11 @@ public function configureActions(Actions $actions): Actions
6565
$group3Global = ActionGroup::new('group3global', 'Global Action Group 3')
6666
->createAsGlobalActionGroup()
6767
->addHeader('Group 1')
68-
->addAction(Action::new('action1', 'Action 1')->linkToCrudAction('edit'))
69-
->addAction(Action::new('action2', 'Action 2')->linkToCrudAction('detail'))
68+
->addAction(Action::new('action1', 'Action 1')->linkToCrudAction('aGlobalAction'))
69+
->addAction(Action::new('action2', 'Action 2')->linkToCrudAction('aGlobalAction'))
7070
->addDivider()
7171
->addHeader('Group 2')
72-
->addAction(Action::new('action3', 'Action 3')->linkToCrudAction('delete'));
72+
->addAction(Action::new('action3', 'Action 3')->linkToCrudAction('aGlobalAction'));
7373

7474
// mixed action types (link, button, form)
7575
$group4 = ActionGroup::new('group4', 'Action Group 4')
@@ -78,9 +78,9 @@ public function configureActions(Actions $actions): Actions
7878
->addAction(Action::new('form_action', 'Action 3')->linkToCrudAction('delete')->displayAsForm());
7979
$group4Global = ActionGroup::new('group4global ', 'Global Action Group 4')
8080
->createAsGlobalActionGroup()
81-
->addAction(Action::new('link_action', 'Action 1')->linkToCrudAction('edit'))
82-
->addAction(Action::new('button_action', 'Action 2')->linkToCrudAction('detail')->addCssClass('btn-primary'))
83-
->addAction(Action::new('form_action', 'Action 3')->linkToCrudAction('delete')->displayAsForm());
81+
->addAction(Action::new('link_action', 'Action 1')->linkToCrudAction('aGlobalAction'))
82+
->addAction(Action::new('button_action', 'Action 2')->linkToCrudAction('aGlobalAction')->addCssClass('btn-primary'))
83+
->addAction(Action::new('form_action', 'Action 3')->linkToCrudAction('aGlobalAction')->displayAsForm());
8484

8585
// custom styling
8686
$group5 = ActionGroup::new('group5', 'Action Group 5')
@@ -100,8 +100,8 @@ public function configureActions(Actions $actions): Actions
100100
'data-test' => 'group-5',
101101
'data-custom' => 'value',
102102
])
103-
->addAction(Action::new('action1', 'Action 1')->linkToCrudAction('edit'))
104-
->addAction(Action::new('action2', 'Action 2')->linkToCrudAction('detail'));
103+
->addAction(Action::new('action1', 'Action 1')->linkToCrudAction('aGlobalAction'))
104+
->addAction(Action::new('action2', 'Action 2')->linkToCrudAction('aGlobalAction'));
105105

106106
// conditional display
107107
$group6 = ActionGroup::new('group6', 'Action Group 6')
@@ -111,17 +111,17 @@ public function configureActions(Actions $actions): Actions
111111
$group6Global = ActionGroup::new('group6global', 'Global Action Group 6')
112112
->createAsGlobalActionGroup()
113113
->displayIf(static fn ($entity): bool => $entity instanceof Category && str_starts_with($entity->getName(), 'Category 1'))
114-
->addAction(Action::new('action1', 'Action 1')->linkToCrudAction('edit'))
115-
->addAction(Action::new('action2', 'Action 2')->linkToCrudAction('detail'));
114+
->addAction(Action::new('action1', 'Action 1')->linkToCrudAction('aGlobalAction'))
115+
->addAction(Action::new('action2', 'Action 2')->linkToCrudAction('aGlobalAction'));
116116

117117
// action group with icon only (no label)
118118
$group7 = ActionGroup::new('group7', false, 'fa fa-ellipsis-v')
119119
->addAction(Action::new('action1', 'Action 1')->linkToCrudAction('edit'))
120120
->addAction(Action::new('action2', 'Action 2')->linkToCrudAction('detail'));
121121
$group7Global = ActionGroup::new('group7global', false, 'fa fa-ellipsis-v')
122122
->createAsGlobalActionGroup()
123-
->addAction(Action::new('action1', 'Action 1')->linkToCrudAction('edit'))
124-
->addAction(Action::new('action2', 'Action 2')->linkToCrudAction('detail'));
123+
->addAction(Action::new('action1', 'Action 1')->linkToCrudAction('aGlobalAction'))
124+
->addAction(Action::new('action2', 'Action 2')->linkToCrudAction('aGlobalAction'));
125125

126126
// action group with translatable labels
127127
$group8 = ActionGroup::new('group8', t('Action Group 8'))
@@ -180,4 +180,9 @@ public function configureActions(Actions $actions): Actions
180180
return $action->addCssClass('text-danger');
181181
});
182182
}
183+
184+
public function aGlobalAction(): void
185+
{
186+
// no need to add any logic here because the action won't be executed in the tests
187+
}
183188
}

0 commit comments

Comments
 (0)