fix databases being made in the same directory

Author: Sebastian-Webster

src/constants.ts

@@ -6,7 +6,7 @@ import { valid as validSemver } from "semver";
 
 export const MIN_SUPPORTED_MYSQL = '8.0.20';
 
-export const DEFAULT_OPTIONS: InternalServerOptions = {
+export const DEFAULT_OPTIONS_GENERATOR: () => InternalServerOptions = () => ({
     version: undefined,
     dbName: 'dbdata',
     logLevel: 'ERROR',
@@ -24,7 +24,9 @@ export const DEFAULT_OPTIONS: InternalServerOptions = {
     //mysqlmsn = MySQL Memory Server Node.js
     _DO_NOT_USE_dbPath: normalizePath(`${tmpdir()}/mysqlmsn/dbs/${randomUUID().replace(/-/g, '')}`),
     _DO_NOT_USE_binaryDirectoryPath: `${tmpdir()}/mysqlmsn/binaries`
-} as const;
+});
+
+export const DEFAULT_OPTIONS_KEYS = Object.freeze(Object.keys(DEFAULT_OPTIONS_GENERATOR()))
 
 export const LOG_LEVELS = {
     'LOG': 0,

src/index.ts

@@ -6,30 +6,34 @@ import { BinaryInfo, InternalServerOptions, ServerOptions } from '../types'
 import getBinaryURL from './libraries/Version'
 import MySQLVersions from './versions.json'
 import { downloadBinary } from './libraries/Downloader'
-import { MIN_SUPPORTED_MYSQL, DEFAULT_OPTIONS, OPTION_TYPE_CHECKS, INTERNAL_OPTIONS } from './constants'
+import { MIN_SUPPORTED_MYSQL, DEFAULT_OPTIONS_KEYS, OPTION_TYPE_CHECKS, INTERNAL_OPTIONS, DEFAULT_OPTIONS_GENERATOR } from './constants'
 
 export async function createDB(opts?: ServerOptions) {
     const suppliedOpts = opts || {};
     const suppliedOptsKeys = Object.keys(suppliedOpts);
-    const defaultOptionsKeys = Object.keys(DEFAULT_OPTIONS);
 
     for (const opt of INTERNAL_OPTIONS) {
         if (suppliedOptsKeys.includes(opt)) {
             console.warn(`[ mysql-memory-server - Options WARN ]: Creating MySQL database with option ${opt}. This is considered unstable and should not be used externally. Please consider removing this option.`)
         }
     }
 
+    const options = DEFAULT_OPTIONS_GENERATOR();
+    
     for (const opt of suppliedOptsKeys) {
-        if (!defaultOptionsKeys.includes(opt)) {
+        if (!DEFAULT_OPTIONS_KEYS.includes(opt)) {
             throw `Option ${opt} is not a valid option.`
         }
+
         if (!OPTION_TYPE_CHECKS[opt].check(suppliedOpts[opt])) {
             //Supplied option failed the check
             throw OPTION_TYPE_CHECKS[opt].errorMessage
         }
+
+        if (suppliedOpts[opt] !== undefined) {
+            options[opt] = suppliedOpts[opt]
+        }
     }
-    
-    const options: InternalServerOptions = {...DEFAULT_OPTIONS, ...opts}
 
     const logger = new Logger(options.logLevel)