remove databaseDirectoryPath internal option

Author: Sebastian-Webster

.github/workflows/os-compatibility.yml

@@ -33,6 +33,7 @@ jobs:
       - name: Run tests
         env:
           VERSION_REQUIREMENT: ${{ matrix.version-requirement }}
+          MOVE_MYSQLMSN_TO: ${{ runner.os == 'Windows' && 'C:\\Users\\RUNNER~1\\mysqlmsn' || '/tmp/mysqlmsn' }}
         run: npm run os-compat:ci
 
       - name: Upload mysqlmsn directory (Windows)

dist/src/constants.d.ts

@@ -8,7 +8,6 @@ export declare const LOG_LEVELS: {
 };
 declare const internalOptions: {
     deleteDBAfterStopped: string;
-    databaseDirectoryPath: string;
     binaryDirectoryPath: string;
     cli: string;
 };

src/constants.ts

@@ -32,7 +32,6 @@ export const LOG_LEVELS = {
 const internalOptions = {
     deleteDBAfterStopped: 'true',
     //mysqlmsn = MySQL Memory Server Node.js
-    databaseDirectoryPath: normalizePath(`${tmpdir()}/mysqlmsn/dbs`),
     binaryDirectoryPath: `${tmpdir()}/mysqlmsn/binaries`,
     cli: 'false'
 }

src/libraries/Executor.ts

@@ -516,7 +516,7 @@ class Executor {
 
         let retries = 0;
 
-        this.databasePath = normalizePath(`${getInternalEnvVariable('databaseDirectoryPath')}/${randomUUID().replaceAll("-", '')}`)
+        this.databasePath = normalizePath(`${os.tmpdir()}/mysqlmsn/dbs/${randomUUID().replaceAll("-", '')}`)
 
         const datadir = normalizePath(`${this.databasePath}/data`)
 

tests/versions.test.ts

@@ -1,10 +1,12 @@
-import {expect, test, jest} from '@jest/globals'
+import {expect, test, jest, afterAll} from '@jest/globals'
 import { createDB } from '../src/index'
 import sql from 'mysql2/promise'
 import { coerce, satisfies } from 'semver';
 import { ServerOptions } from '../types';
 import getBinaryURL from '../src/libraries/Version';
 import { DOWNLOADABLE_MYSQL_VERSIONS } from '../src/constants';
+import fsPromises from 'fs/promises'
+import os from 'os'
 
 const usernames = ['root', 'dbuser']
 
@@ -56,4 +58,10 @@ for (const version of DOWNLOADABLE_MYSQL_VERSIONS.filter(v => satisfies(v, proce
 //binary, we need this test here just in case all the MySQL binaries are skipped
 test('dummy test', () => {
     expect(1 + 1).toBe(2)
+})
+
+afterAll(async () => {
+    if (process.env.MOVE_MYSQLMSN_TO) {
+        await fsPromises.rename(`${os.tmpdir()}/mysqlmsn`, process.env.MOVE_MYSQLMSN_TO)
+    }
 })