use static URL for Oracle downloads

Author: Sebastian-Webster

src/constants.ts

@@ -123,6 +123,7 @@ export const OPTION_TYPE_CHECKS: OptionTypeChecks = {
 
 export const MIN_SUPPORTED_MYSQL = '5.7.19';
 export const MySQLCDNDownloadsBaseURL = 'https://cdn.mysql.com//Downloads/MySQL-'
+export const MySQLCDNArchivesBaseURL = 'https://cdn.mysql.com/archives/mysql-'
 // Versions 8.0.29, 8.0.38, 8.4.1, and 9.0.0 have been purposefully left out of this list as MySQL has removed them from the CDN due to critical issues.
 export const DOWNLOADABLE_MYSQL_VERSIONS = [
     '5.7.19', '5.7.20', '5.7.21', '5.7.22', '5.7.23', '5.7.24', '5.7.25', '5.7.26', '5.7.27', '5.7.28', '5.7.29', '5.7.30', '5.7.31', '5.7.32', '5.7.33', '5.7.34', '5.7.35', '5.7.36', '5.7.37', '5.7.38', '5.7.39', '5.7.40', '5.7.41', '5.7.42', '5.7.43', '5.7.44',

src/libraries/Downloader.ts

@@ -8,7 +8,7 @@ import { randomUUID } from 'crypto';
 import { execFile } from 'child_process';
 import { BinaryInfo, InternalServerOptions } from '../../types';
 import { lockFile, waitForLock } from './FileLock';
-import { getInternalEnvVariable } from '../constants';
+import { getInternalEnvVariable, MySQLCDNArchivesBaseURL, MySQLCDNDownloadsBaseURL } from '../constants';
 
 function handleTarExtraction(filepath: string, extractedPath: string): Promise<void> {
     return new Promise((resolve, reject) => {
@@ -25,12 +25,7 @@ function getFileDownloadURLRedirect(url: string): Promise<string> {
     const options: https.RequestOptions = {
         headers: {
             'accept': '*/*',
-            'connection': 'keep-alive',
-            "user-agent": 'mysql-memory-server-js-net/1.0.0',
-            // Not too sure why, but the request fails without dummy headers
-            // For the request to work, these headers have been added
-            "hello": "hello",
-            "world": "world"
+            'connection': 'keep-alive'
         }
     }
 
@@ -294,14 +289,16 @@ export function downloadBinary(binaryInfo: BinaryInfo, options: InternalServerOp
             //The code below only runs if the lock has been acquired by us
 
             let downloadTries = 0;
+            let useDownloadsURL = false;
 
             do {
+                const downloadURL = binaryInfo.hostedByOracle ? `${useDownloadsURL ? MySQLCDNDownloadsBaseURL : MySQLCDNArchivesBaseURL}${url}` : await getFileDownloadURLRedirect(url)
                 try {
                     downloadTries++;
-                    logger.log(`Starting download for MySQL version ${version} from ${url}.`)
-                    await downloadFromCDN(url, archivePath, logger)
-                    logger.log(`Finished downloading MySQL version ${version} from ${url}. Now starting binary extraction.`)
-                    await extractBinary(url, archivePath, extractedPath, binaryInfo, logger)
+                    logger.log(`Starting download for MySQL version ${version} from ${downloadURL}.`)
+                    await downloadFromCDN(downloadURL, archivePath, logger)
+                    logger.log(`Finished downloading MySQL version ${version} from ${downloadURL}. Now starting binary extraction.`)
+                    await extractBinary(downloadURL, archivePath, extractedPath, binaryInfo, logger)
                     logger.log(`Finished extraction for version ${version}`)
                     break
                 } catch (e) {
@@ -315,14 +312,22 @@ export function downloadBinary(binaryInfo: BinaryInfo, options: InternalServerOp
                         logger.error('An error occurred while deleting extractedPath and/or archivePath:', e)
                     }
 
-                    if (e?.includes?.('status code 404')) {
-                        try {
-                            await releaseFunction()
-                        } catch (e) {
-                            logger.error('An error occurred while releasing lock after receiving a 404 error on download. The error was:', e)
+                    // If we got a 404 error while downloading a binary from Oracle and have not retried with the Downloads URL yet
+                    // then retry with the Downloads URL. Otherwise, reject.
+                    if (e?.includes('status code 404')) {
+                        if (binaryInfo.hostedByOracle && useDownloadsURL === false) {
+                            useDownloadsURL = true;
+                            downloadTries--
+                            continue
+                        } else {
+                            try {
+                                await releaseFunction()
+                            } catch (e) {
+                                logger.error('An error occurred while releasing lock after receiving a 404 error on download. The error was:', e)
+                            } finally {
+                                return reject(`Binary download for MySQL version ${binaryInfo.version} returned status code 404 at URL ${downloadURL}. Aborting download.`)
+                            }
                         }
-
-                        return reject(`Binary download for MySQL version ${binaryInfo.version} returned status code 404. Aborting download.`)
                     }
 
                     if (downloadTries > options.downloadRetries) {
@@ -349,19 +354,21 @@ export function downloadBinary(binaryInfo: BinaryInfo, options: InternalServerOp
             return resolve(binaryPath)
         } else {
             let downloadTries = 0;
+            let useDownloadsURL = false;
 
             do {
+                const downloadURL = binaryInfo.hostedByOracle ? `${useDownloadsURL ? MySQLCDNDownloadsBaseURL : MySQLCDNArchivesBaseURL}${url}` : await getFileDownloadURLRedirect(url)
                 const uuid = randomUUID()
                 const zipFilepath = `${dirpath}/${uuid}.${fileExtension}`
                 logger.log('Binary filepath:', zipFilepath)
                 const extractedPath = `${dirpath}/${uuid}`
 
                 try {
                     downloadTries++
-                    logger.log(`Starting download for MySQL version ${version} from ${url}.`)
-                    await downloadFromCDN(url, zipFilepath, logger)
-                    logger.log(`Finished downloading MySQL version ${version} from ${url}. Now starting binary extraction.`)
-                    const binaryPath = await extractBinary(url, zipFilepath, extractedPath, binaryInfo, logger)
+                    logger.log(`Starting download for MySQL version ${version} from ${downloadURL}.`)
+                    await downloadFromCDN(downloadURL, zipFilepath, logger)
+                    logger.log(`Finished downloading MySQL version ${version} from ${downloadURL}. Now starting binary extraction.`)
+                    const binaryPath = await extractBinary(downloadURL, zipFilepath, extractedPath, binaryInfo, logger)
                     logger.log(`Finished extraction for version ${version}`)
                     return resolve(binaryPath)
                 } catch (e) {
@@ -375,8 +382,16 @@ export function downloadBinary(binaryInfo: BinaryInfo, options: InternalServerOp
                         logger.error('An error occurred while deleting extractedPath and/or archivePath:', e)
                     }
 
-                    if (e?.includes?.('status code 404')) {
-                        return reject(`Binary download for MySQL version ${version} returned status code 404. Aborting download.`)
+                    // If we got a 404 error while downloading a binary from Oracle and have not retried with the Downloads URL yet
+                    // then retry with the Downloads URL. Otherwise, reject.
+                    if (e?.includes('status code 404')) {
+                        if (binaryInfo.hostedByOracle && useDownloadsURL === false) {
+                            useDownloadsURL = true;
+                            downloadTries--
+                            continue
+                        } else {
+                            return reject(`Binary download for MySQL version ${binaryInfo.version} returned status code 404 at URL ${downloadURL}. Aborting download.`)
+                        }
                     }
 
                     if (downloadTries > options.downloadRetries) {

src/libraries/Version.ts

@@ -123,7 +123,7 @@ export default function getBinaryURL(versionToGet: string = "x", currentArch: st
 
     return {
         version: selectedVersion,
-        url: isOnAlpineLinux ? fileLocation : (MySQLCDNDownloadsBaseURL + fileLocation),
+        url: fileLocation,
         hostedByOracle: !isOnAlpineLinux, // Only the Alpine Linux binaries are not hosted on the MySQL CDN.
         xPluginSupported
     }