remove reject on force and X not starting successfully

Author: Sebastian-Webster

README.md

@@ -87,8 +87,8 @@ The name of the user to use to login to the database
 If on Windows, this is the name of the named pipe that MySQL is listening on. If not on Windows, this is the path to the socket that MySQL is listening on.
 - `xSocket: string`
 If on Windows, this is the name of the named pipe that the MySQL X Plugin is listening on. If not on Windows, this is the path that the MySQL X Plugin is listening on. If ```options.xEnabled``` is set to "OFF", this value will be an empty string.
-- `mysql: {version: string, versionIsInstalledOnSystem: boolean, xPluginIsEnabled: boolean}`
-An object with three properties. ```version``` is the version of MySQL used to create the database. ```versionIsInstalledOnSystem``` will be true if the MySQL version used is already installed on the system and false if the version had to be downloaded from MySQL's CDN. ```xPluginIsEnabled``` will be true if ```options.xEnabled``` is set to "FORCE", and will be false if ```options.xEnabled``` is set to "OFF".
+- `mysql: {version: string, versionIsInstalledOnSystem: boolean}`
+An object with three properties. ```version``` is the version of MySQL used to create the database. ```versionIsInstalledOnSystem``` will be true if the MySQL version used is already installed on the system and false if the version had to be downloaded from MySQL's CDN.
 - `stop: () => Promise<void>`
 The method to stop the database. The returned promise resolves when the database has successfully stopped.
 

src/libraries/Executor.ts

@@ -229,29 +229,16 @@ class Executor {
                             return //Promise rejection will be handled in the process.on('close') section because this.killedFromPortIssue is being set to true
                         }
 
-                        const xStartedSuccessfully = file.includes('X Plugin ready for connections') || file.includes("mysqlx reported: 'Server starts handling incoming connections'") || (lte(this.version, '8.0.12') && gte(this.version, '8.0.4') && file.search(/\[ERROR\].*Plugin mysqlx reported/m) === -1)
-
-                        if (options.xEnabled === 'FORCE' && !xStartedSuccessfully) {
-                            this.logger.error('Error file:', file)
-                            this.logger.error('MySQL X failed to start successfully and xEnabled is set to "FORCE". Error log is above this message. If this is happening continually and you can start the database without the X Plugin, you can set options.xEnabled to "OFF" instead of "FORCE".')
-                            const killed = await this.#killProcess(process)
-                            if (!killed) {
-                                this.logger.error('Failed to kill MySQL process after MySQL X failing to initialise.')
-                            }
-                            return reject('X Plugin failed to start and options.xEnabled is set to "FORCE".')
-                        }
-
                         const result: MySQLDB = {
                             port,
-                            xPort: xStartedSuccessfully ? mySQLXPort : -1,
+                            xPort: options.xEnabled === 'FORCE' ? mySQLXPort : -1,
                             socket,
-                            xSocket: xStartedSuccessfully ? xSocket : '',
+                            xSocket: options.xEnabled === 'FORCE' ? xSocket : '',
                             dbName: options.dbName,
                             username: options.username,
                             mysql: {
                                 version: this.version,
-                                versionIsInstalledOnSystem: this.versionInstalledOnSystem,
-                                xPluginIsEnabled: xStartedSuccessfully
+                                versionIsInstalledOnSystem: this.versionInstalledOnSystem
                             },
                             stop: () => {
                                 return new Promise(async (resolve, reject) => {

types/index.ts

@@ -55,8 +55,7 @@ export type MySQLDB = {
     username: string,
     mysql: {
         version: string,
-        versionIsInstalledOnSystem: boolean,
-        xPluginIsEnabled: boolean
+        versionIsInstalledOnSystem: boolean
     },
     stop: () => Promise<void>
 }