change X init failure test to use http server port instead of mysql port

Author: Sebastian-Webster

src/libraries/Executor.ts

@@ -95,7 +95,6 @@ class Executor {
             if (options.xEnabled !== 'OFF') {
                 mysqlArguments.push(`--mysqlx-port=${mySQLXPort}`)
                 mysqlArguments.push(`--mysqlx-socket=${xSocket}`)
-                mysqlArguments.push(`--mysqlx-bind-address=127.0.0.1`)
 
                 //<8.0.11 does not have MySQL X turned on by default so we will be installing the X Plugin in this if statement.
                 //MySQL 5.7.12 introduced the X plugin, but according to https://dev.mysql.com/doc/refman/5.7/en/document-store-setting-up.html, the database needs to be initialised with version 5.7.19.

tests/ci/x.test.ts

@@ -2,6 +2,7 @@ import {expect, test, jest} from '@jest/globals'
 import { createDB } from '../../src/index'
 import sql from 'mysql2/promise'
 import { ServerOptions } from '../../types';
+import http from 'http';
 
 jest.setTimeout(500_000); //5 minutes
 
@@ -88,11 +89,25 @@ test(`MySQL X is on when force enabling it`, async () => {
 })
 
 test('DB creation throws when MySQL fails to initialise and X is force enabled', async () => {
+    const server: http.Server = await new Promise(resolve => {
+        const httpServer = new http.Server();
+        httpServer.listen(0, () => {
+            resolve(httpServer)
+        })
+    })
+
+    const serverAddress = server.address();
+    if (typeof serverAddress === 'string') {
+        throw 'serverAddress is a string. Should be an object'
+    }
+    if (serverAddress === null) {
+        throw 'serverAddress is null. Should be an object.'
+    }
+
     const options: ServerOptions = {
         arch,
         logLevel: 'LOG',
-        port: 3306,
-        xPort: 3306,
+        xPort: serverAddress.port, // Use a port that is already in use to get X to fail
         xEnabled: 'FORCE',
         initSQLString: 'SELECT 2+2;'
     }
@@ -105,5 +120,10 @@ test('DB creation throws when MySQL fails to initialise and X is force enabled',
         thrown = e
     }
 
+    await new Promise(resolve => {
+        server.on('close', resolve)
+        server.close()
+    })
+
     expect(thrown).toBe('The port has been retried 10 times and a free port could not be found.\nEither try again, or if this is a common issue, increase options.portRetries.')
 })