Merge pull request #149 from Sebastian-Webster/147-option-downloadretries-is-off-by-1

Fix off by one error with downloadRetries

Author: Sebastian-Webster

src/libraries/Downloader.ts

@@ -245,7 +245,7 @@ export function downloadBinary(binaryInfo: BinaryInfo, options: InternalServerOp
                         logger.error('An error occurred while deleting extractedPath and/or archivePath:', e)
                     }
 
-                    if (downloadTries >= options.downloadRetries) {
+                    if (downloadTries > options.downloadRetries) {
                         //Only reject if we have met the downloadRetries limit
                         try {
                             await releaseFunction()
@@ -258,7 +258,7 @@ export function downloadBinary(binaryInfo: BinaryInfo, options: InternalServerOp
                         console.warn(`An error was encountered during the binary download process. Retrying for retry ${downloadTries}/${options.downloadRetries}. The error was:`, e)
                     }
                 }
-            } while (downloadTries < options.downloadRetries)
+            } while (downloadTries <= options.downloadRetries)
 
             try {
                 releaseFunction()
@@ -292,14 +292,14 @@ export function downloadBinary(binaryInfo: BinaryInfo, options: InternalServerOp
                         logger.error('An error occurred while deleting extractedPath and/or archivePath:', e)
                     }
 
-                    if (downloadTries >= options.downloadRetries) {
+                    if (downloadTries > options.downloadRetries) {
                         //Only reject if we have met the downloadRetries limit
                         return reject(e)
                     } else {
                         console.warn(`An error was encountered during the binary download process. Retrying for retry ${downloadTries}/${options.downloadRetries}. The error was:`, e)
                     }
                 }
-            } while (downloadTries < options.downloadRetries)
+            } while (downloadTries <= options.downloadRetries)
         }
     })
 }