Skip to content

Commit 296e696

Browse files
committed
[INTERNAL] default header row fixed back to false
1 parent 0b8eeb8 commit 296e696

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

CHANGELOG

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
2.14.3
22
Oct 10, 2020
33

4-
NEW: Added default "Header row fixed" setting (enabled)
4+
NEW: Added default "Header row fixed" setting
55
NEW: Support "Comment with line comment" #247
66
FIX: "Value coloring" change not applied to open files
77

src/main/java/net/seesharpsoft/intellij/plugins/csv/settings/CsvEditorSettings.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ public static final class OptionSet {
7272
public int TABLE_DEFAULT_COLUMN_WIDTH = TABLE_DEFAULT_COLUMN_WIDTH_DEFAULT;
7373
public boolean TABLE_AUTO_COLUMN_WIDTH_ON_OPEN = false;
7474
public boolean ZERO_BASED_COLUMN_NUMBERING = false;
75-
public boolean TABLE_HEADER_ROW_FIXED = true;
75+
public boolean TABLE_HEADER_ROW_FIXED = false;
7676

7777
public boolean SHOW_TABLE_EDITOR_INFO_PANEL = true;
7878
public boolean QUOTING_ENFORCED = false;

src/main/resources/META-INF/plugin.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050

5151
<change-notes><![CDATA[
5252
<pre style="font-family: sans-serif">
53-
NEW: Added default "Header row fixed" setting (enabled)
53+
NEW: Added default "Header row fixed" setting
5454
NEW: Support "Comment with line comment" #247
5555
FIX: "Value coloring" change not applied to open files
5656
</pre>

src/test/java/net/seesharpsoft/intellij/plugins/csv/settings/CsvEditorSettingsProviderTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ public void testResetAndModified() throws ConfigurationException {
7979
csvEditorSettings.setKeepTrailingSpaces(true);
8080
csvEditorSettings.setCommentIndicator("//");
8181
csvEditorSettings.setValueColoring(CsvEditorSettings.ValueColoring.SIMPLE);
82-
csvEditorSettings.setHeaderRowFixed(false);
82+
csvEditorSettings.setHeaderRowFixed(true);
8383

8484
assertEquals(true, editorSettingsPanel.isModified());
8585

@@ -103,7 +103,7 @@ public void testResetAndModified() throws ConfigurationException {
103103
assertEquals(true, csvEditorSettings.getKeepTrailingSpaces());
104104
assertEquals("//", csvEditorSettings.getCommentIndicator());
105105
assertEquals( CsvEditorSettings.ValueColoring.SIMPLE, csvEditorSettings.getValueColoring());
106-
assertEquals(false, csvEditorSettings.isHeaderRowFixed());
106+
assertEquals(true, csvEditorSettings.isHeaderRowFixed());
107107

108108
editorSettingsPanel.disposeUIResources();
109109
}
@@ -131,7 +131,7 @@ public void testApply() throws ConfigurationException {
131131
csvEditorSettings.setKeepTrailingSpaces(true);
132132
csvEditorSettings.setCommentIndicator("//");
133133
csvEditorSettings.setValueColoring(CsvEditorSettings.ValueColoring.SIMPLE);
134-
csvEditorSettings.setHeaderRowFixed(false);
134+
csvEditorSettings.setHeaderRowFixed(true);
135135

136136
editorSettingsPanel.apply();
137137

0 commit comments

Comments
 (0)