Merge pull request #183 from SeeSharpSoft/master

Release 2.9.1

Author: SeeSharpSoft

CHANGELOG

@@ -1,3 +1,9 @@
+2.9.1
+Feb 15, 2020
+
+FIX: update failed for AnAction #181
+FIX: selection indicator for default separator action
+
 2.9.0
 Feb 07, 2020
 

README.md

@@ -122,6 +122,22 @@ The preferred editor usage can be switched between "Text Editor first", "Table E
 
 Enable zero-based column numbering. This affects the tooltip info of the text editor as well as column numbering of the table editor.
 
+##### Default Value Separator (CSV only)
+
+The following separators are currently supported: **,** (Comma), **;** (Semicolon), **|** (Pipe) and **↹** (Tab)
+
+_Default Value Separator_ defines which separator is used as standard for each newly opened CSV file. The separator character can be changed for each file individually in its editors context menu.
+
+This option has no effect on TSV/PSV files, the separator is pre-defined by their file- and language-type.
+
+##### Default Escape Character
+
+The following escape characters are currently supported: **"** (Double Quote), **\\** (Backslash)
+
+Within quoted values (fields starting and ending with a double quote), the double quote character must be escaped to be parsed as part of its value and not to be treated as the closing quote. 
+
+_Default Escape Character_ defines which escape character is used as standard for each newly opened CSV/TSV/PSV file. The escape character can be changed for each file individually in its editors context menu.
+
 #### Text Editor
 
 ##### Highlighting
@@ -223,11 +239,7 @@ Annasusanna,Amsterdam,1
 
 ##### Separator
 
-The following separators are currently supported: **,** (Comma), **;** (Semicolon), **|** (Pipe) and **↹** (Tab)
-
-_Value separator (default)_ defines which separator is used by default. The separator character can be changed for each CSV file individually.
-
-When changing the separator, press the apply button to refresh the preview window properly. 
+Adjust spacing around the separator.
 
 _Space before separator_
 

build.gradle

@@ -24,7 +24,7 @@ jacocoTestReport {
 }
 
 group 'net.seesharpsoft.intellij.plugins'
-version '2.9.0'
+version '2.9.1'
 
 apply plugin: 'java'
 sourceCompatibility = javaVersion

docs/editorsettings.png

@@ -22,7 +22,7 @@ public boolean isSelected(@NotNull AnActionEvent anActionEvent) {
         if (psiFile == null) {
             return false;
         }
-        return CsvHelper.getValueSeparator(psiFile) == null;
+        return !CsvHelper.hasValueSeparatorAttribute(psiFile);
     }
 
     @Override
@@ -31,7 +31,6 @@ public void setSelected(@NotNull AnActionEvent anActionEvent, boolean selected)
         if (psiFile == null) {
             return;
         }
-
         CsvFileAttributes.getInstance(psiFile.getProject()).resetValueSeparator(psiFile);
         FileContentUtilCore.reparseFiles(psiFile.getVirtualFile());
 

src/main/java/net/seesharpsoft/intellij/plugins/csv/actions/CsvDefaultSeparatorAction.java

@@ -120,10 +120,9 @@ public void resetValueSeparator(@NotNull PsiFile psiFile) {
 
     public @NotNull
     CsvValueSeparator getValueSeparator(Project project, VirtualFile virtualFile) {
-        if (project == null || virtualFile == null) {
+        if (project == null || virtualFile == null || !(virtualFile.getFileType() instanceof LanguageFileType)) {
             return CsvEditorSettings.getInstance().getDefaultValueSeparator();
         }
-        assert(virtualFile.getFileType() instanceof LanguageFileType);
         Language language = ((LanguageFileType) virtualFile.getFileType()).getLanguage();
         if (language instanceof CsvSeparatorHolder) {
                 return ((CsvSeparatorHolder) language).getSeparator();

src/main/java/net/seesharpsoft/intellij/plugins/csv/components/CsvFileAttributes.java

@@ -51,6 +51,9 @@
 NEW: customizable escape character #159
 NEW: value separator setting moved from 'Code Style' to 'General'
 + lots of code cleanup & rework
+
+FIX: update failed for AnAction #181
+FIX: selection indicator for default separator action
       </pre>
     ]]>
     </change-notes>