Skip to content

Commit cb374f8

Browse files
committed
[FIX] code cleanup / build fixes
1 parent c41455a commit cb374f8

File tree

5 files changed

+10
-6
lines changed

5 files changed

+10
-6
lines changed

src/main/java/net/seesharpsoft/intellij/plugins/csv/annotation/CsvAnnotator.java renamed to src/main/java/net/seesharpsoft/intellij/plugins/csv/editor/CsvAnnotator.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package net.seesharpsoft.intellij.plugins.csv.annotation;
1+
package net.seesharpsoft.intellij.plugins.csv.editor;
22

33
import com.intellij.lang.annotation.*;
44
import com.intellij.openapi.editor.colors.ColorKey;
@@ -13,7 +13,6 @@
1313
import com.intellij.xml.util.XmlStringUtil;
1414
import net.seesharpsoft.intellij.plugins.csv.CsvColumnInfo;
1515
import net.seesharpsoft.intellij.plugins.csv.CsvHelper;
16-
import net.seesharpsoft.intellij.plugins.csv.editor.CsvEditorSettingsExternalizable;
1716
import net.seesharpsoft.intellij.plugins.csv.psi.CsvFile;
1817
import net.seesharpsoft.intellij.plugins.csv.psi.CsvTypes;
1918
import net.seesharpsoft.intellij.plugins.csv.settings.CsvCodeStyleSettings;

src/main/java/net/seesharpsoft/intellij/plugins/csv/editor/CsvEditorSettingsPanel.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ public class CsvEditorSettingsPanel implements SearchableConfigurable {
1616
private JPanel myMainPanel;
1717
private JCheckBox cbUseSoftWraps;
1818
private JCheckBox cbColumnHighlighting;
19-
private JPanel panelHighlighting;
2019
private CheckBoxWithColorChooser cbTabHighlightColor;
2120

2221
@NotNull
@@ -37,6 +36,12 @@ public JComponent createComponent() {
3736
return myMainPanel;
3837
}
3938

39+
// ensure downward compatibility
40+
@Override
41+
public boolean isModified(@NotNull JToggleButton toggleButton, boolean value) {
42+
return toggleButton.isSelected() != value;
43+
}
44+
4045
@Override
4146
public boolean isModified() {
4247
CsvEditorSettingsExternalizable csvEditorSettingsExternalizable = CsvEditorSettingsExternalizable.getInstance();

src/main/java/net/seesharpsoft/intellij/plugins/csv/settings/CsvColorSettingsPage.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
import com.intellij.openapi.options.colors.ColorSettingsPage;
88
import net.seesharpsoft.intellij.plugins.csv.CsvIconProvider;
99
import net.seesharpsoft.intellij.plugins.csv.CsvLanguage;
10-
import net.seesharpsoft.intellij.plugins.csv.annotation.CsvAnnotator;
10+
import net.seesharpsoft.intellij.plugins.csv.editor.CsvAnnotator;
1111
import net.seesharpsoft.intellij.plugins.csv.highlighter.CsvSyntaxHighlighter;
1212
import org.jetbrains.annotations.NotNull;
1313
import org.jetbrains.annotations.Nullable;

src/main/resources/META-INF/plugin.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@
7474
<editorOptionsProvider instance="net.seesharpsoft.intellij.plugins.csv.editor.CsvEditorSettingsProvider" />
7575
<fileEditorProvider implementation="net.seesharpsoft.intellij.plugins.csv.editor.CsvFileEditorProvider" />
7676

77-
<annotator language="csv" implementationClass="net.seesharpsoft.intellij.plugins.csv.annotation.CsvAnnotator"/>
77+
<annotator language="csv" implementationClass="net.seesharpsoft.intellij.plugins.csv.editor.CsvAnnotator"/>
7878

7979
<spellchecker.support language="csv"
8080
implementationClass="net.seesharpsoft.intellij.plugins.csv.spellchecker.CsvSpellCheckingStrategy" />

src/test/java/net/seesharpsoft/intellij/plugins/csv/annotation/CsvAnnotatorTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
import java.util.Iterator;
2222
import java.util.List;
2323

24-
import static net.seesharpsoft.intellij.plugins.csv.annotation.CsvAnnotator.CSV_COLUMN_INFO_SEVERITY;
24+
import static net.seesharpsoft.intellij.plugins.csv.editor.CsvAnnotator.CSV_COLUMN_INFO_SEVERITY;
2525

2626
public class CsvAnnotatorTest extends LightCodeInsightFixtureTestCase {
2727

0 commit comments

Comments
 (0)