Allow FPMs to add engagements while the project is discussing changes to plan (#3388)

Author: CarsonF

dbschema/migrations/00017-m1d2nmz.edgeql

@@ -1,9 +1,15 @@
-import { field, Hierarchies, member, Policy } from '../util';
+import { any, field, Hierarchies, member, Policy } from '../util';
 
 @Policy([...Hierarchies.Field, ...Hierarchies.Finance], (r) => [
   r.Project,
   r.Engagement.read,
-  r.Engagement.whenAll(member, field('project.status', 'InDevelopment')).create,
+  r.Engagement.whenAll(
+    member,
+    any(
+      field('project.status', 'InDevelopment'),
+      field('project.step', 'DiscussingChangeToPlan'),
+    ),
+  ).create,
   r.Engagement.whenAll(member, field('status', 'InDevelopment')).delete,
 ])
 export class EngagementsCreateDeletePolicy {}

src/components/authorization/policies/by-feature/engagements-create-delete.policy.ts

@@ -75,7 +75,8 @@ class Engagement extends Interfaces {
 
   declare readonly __typename: DBNames<typeof e.Engagement>;
 
-  readonly project: LinkTo<'Project'> & Pick<IProject, 'status' | 'type'>;
+  readonly project: LinkTo<'Project'> &
+    Pick<UnsecuredDto<IProject>, 'status' | 'step' | 'type'>;
 
   @Field(() => IProject)
   declare readonly parent: BaseNode;

src/components/engagement/dto/engagement.dto.ts

@@ -22,6 +22,7 @@ const baseHydrate = e.shape(e.Engagement, (engagement) => ({
   project: {
     id: true,
     status: true,
+    step: true,
     type: true,
   },
   parent: e.tuple({

src/components/engagement/engagement.gel.repository.ts

@@ -167,9 +167,12 @@ export class EngagementRepository extends CommonRepository {
           node('mouEnd'),
         ])
         .match([
-          node('project'),
-          relation('out', '', 'status', ACTIVE),
-          node('status'),
+          [
+            node('project'),
+            relation('out', '', 'status', ACTIVE),
+            node('status'),
+          ],
+          [node('project'), relation('out', '', 'step', ACTIVE), node('step')],
         ])
         .return<{ dto: UnsecuredDto<Engagement> }>(
           merge('props', 'changedProps', {
@@ -185,6 +188,7 @@ export class EngagementRepository extends CommonRepository {
               id: 'project.id',
               type: 'project.type',
               status: 'status.value',
+              step: 'step.value',
             },
             language: 'language { .id }',
             pnp: { id: 'props.pnp' },