Skip to content

Commit 05190e2

Browse files
committed
Drop deprecated project member GQL queries
1 parent 396bcb4 commit 05190e2

File tree

2 files changed

+4
-107
lines changed

2 files changed

+4
-107
lines changed

src/components/project/project-member/project-member.resolver.ts

Lines changed: 3 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,10 @@
1-
import { Args, Mutation, Query, Resolver } from '@nestjs/graphql';
2-
import {
3-
AnonSession,
4-
ID,
5-
IdArg,
6-
ListArg,
7-
LoggedInSession,
8-
Session,
9-
} from '~/common';
10-
import { Loader, LoaderOf } from '~/core';
11-
import { ProjectMemberLoader, ProjectMemberService } from '../project-member';
1+
import { Args, Mutation, Resolver } from '@nestjs/graphql';
2+
import { ID, IdArg, LoggedInSession, Session } from '~/common';
3+
import { ProjectMemberService } from '../project-member';
124
import {
135
CreateProjectMemberInput,
146
CreateProjectMemberOutput,
157
DeleteProjectMemberOutput,
16-
ProjectMember,
17-
ProjectMemberListInput,
18-
ProjectMemberListOutput,
198
UpdateProjectMemberInput,
209
UpdateProjectMemberOutput,
2110
} from './dto';
@@ -35,31 +24,6 @@ export class ProjectMemberResolver {
3524
return { projectMember };
3625
}
3726

38-
@Query(() => ProjectMember, {
39-
description: 'Look up a project member by ID',
40-
deprecationReason: 'Query via project instead',
41-
})
42-
async projectMember(
43-
@Loader(ProjectMemberLoader) projectMembers: LoaderOf<ProjectMemberLoader>,
44-
@IdArg() id: ID,
45-
): Promise<ProjectMember> {
46-
return await projectMembers.load(id);
47-
}
48-
49-
@Query(() => ProjectMemberListOutput, {
50-
description: 'Look up project members',
51-
deprecationReason: 'Query via project instead',
52-
})
53-
async projectMembers(
54-
@AnonSession() session: Session,
55-
@ListArg(ProjectMemberListInput) input: ProjectMemberListInput,
56-
@Loader(ProjectMemberLoader) projectMembers: LoaderOf<ProjectMemberLoader>,
57-
): Promise<ProjectMemberListOutput> {
58-
const list = await this.service.list(input, session);
59-
projectMembers.primeAll(list.items);
60-
return list;
61-
}
62-
6327
@Mutation(() => UpdateProjectMemberOutput, {
6428
description: 'Update a project member',
6529
})

test/project-member.e2e-spec.ts

Lines changed: 1 addition & 68 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
1-
import { times } from 'lodash';
21
import { DateTime, Interval } from 'luxon';
3-
import { isValidId, Role } from '~/common';
2+
import { Role } from '~/common';
43
import { Project } from '../src/components/project/dto';
54
import { ProjectMember } from '../src/components/project/project-member/dto';
65
import {
@@ -71,72 +70,6 @@ describe('ProjectMember e2e', () => {
7170
);
7271
});
7372

74-
it('read one projectMember by id', async () => {
75-
const member = await createPerson(app);
76-
const projectMember = await createProjectMember(app, {
77-
userId: member.id,
78-
projectId: project.id,
79-
});
80-
const result = await app.graphql.query(
81-
gql`
82-
query projectMember($id: ID!) {
83-
projectMember(id: $id) {
84-
...projectMember
85-
}
86-
}
87-
${fragments.projectMember}
88-
`,
89-
{
90-
id: projectMember.id,
91-
},
92-
);
93-
94-
const actual: ProjectMember = result.projectMember;
95-
expect(actual.id).toBe(projectMember.id);
96-
expect(isValidId(actual.id)).toBe(true);
97-
expect(actual.user.value?.id).toBe(member.id);
98-
});
99-
100-
it.skip('list view of ProjectMember', async () => {
101-
const numProjectMembers = 2;
102-
const userForList = await createPerson(app);
103-
const userId = userForList.id;
104-
const projectIds = await Promise.all(
105-
times(numProjectMembers).map(async () => {
106-
await createPerson(app);
107-
const project = await createProject(app);
108-
return project.id;
109-
}),
110-
);
111-
112-
await Promise.all(
113-
times(numProjectMembers, async (index) => {
114-
await createProjectMember(app, {
115-
userId: userId,
116-
projectId: projectIds[index],
117-
roles: [Role.Consultant],
118-
});
119-
}),
120-
);
121-
122-
const { projectMembers } = await app.graphql.query(
123-
gql`
124-
query {
125-
projectMembers(input: { filter: { roles: [Consultant] } }) {
126-
items {
127-
id
128-
}
129-
hasMore
130-
total
131-
}
132-
}
133-
`,
134-
);
135-
expect(projectMembers.items.length).toBeGreaterThanOrEqual(
136-
numProjectMembers,
137-
);
138-
});
139-
14073
it.skip('delete projectMember', async () => {
14174
const member = await createPerson(app);
14275
const projectMember = await createProjectMember(app, {

0 commit comments

Comments
 (0)