Standardize field resolvers to return empty results when anon

This is probably better as it is not the best to throw errors
when resolving fields.

Author: CarsonF

src/components/changeset/changeset-aware.resolver.ts

@@ -1,9 +1,9 @@
 import { Info, Parent, ResolveField, Resolver } from '@nestjs/graphql';
 import { stripIndent } from 'common-tags';
 import {
+  AnonSession,
   Fields,
   IsOnlyId,
-  LoggedInSession,
   Resource,
   type Session,
 } from '~/common';
@@ -55,8 +55,13 @@ export class ChangesetAwareResolver {
   })
   async changesetDiff(
     @Parent() object: ChangesetAware,
-    @LoggedInSession() session: Session,
+    @AnonSession() session: Session,
   ): Promise<ChangesetDiff | null> {
+    // TODO move to auth policy
+    if (session.anonymous) {
+      return null;
+    }
+
     const changeset = await this.changeset(object);
     if (!changeset) {
       return null;

src/components/changeset/changeset.resolver.ts

@@ -1,8 +1,8 @@
 import { Parent, Query, ResolveField, Resolver } from '@nestjs/graphql';
 import {
+  AnonSession,
   type ID,
   IdArg,
-  LoggedInSession,
   type ObjectView,
   type Session,
 } from '~/common';
@@ -28,7 +28,7 @@ export class ChangesetResolver {
   })
   async difference(
     @Parent() changeset: Changeset,
-    @LoggedInSession() session: Session,
+    @AnonSession() session: Session,
     @IdArg({
       name: 'resource',
       nullable: true,
@@ -37,6 +37,11 @@ export class ChangesetResolver {
     })
     parent?: ID,
   ): Promise<ChangesetDiff> {
+    // TODO move to auth policy
+    if (session.anonymous) {
+      return { added: [], removed: [], changed: [] };
+    }
+
     const diff = await this.repo.difference(changeset.id, parent);
     const load = (node: BaseNode, view?: ObjectView) =>
       this.resources.loadByBaseNode(node, view ?? { changeset: changeset.id });

src/components/comments/comment-thread.resolver.ts

@@ -1,13 +1,7 @@
 import { Args, Parent, Query, ResolveField, Resolver } from '@nestjs/graphql';
 import { stripIndent } from 'common-tags';
-import {
-  AnonSession,
-  type ID,
-  IdArg,
-  ListArg,
-  LoggedInSession,
-  type Session,
-} from '~/common';
+import { AnonSession, type ID, IdArg, ListArg, type Session } from '~/common';
+import { loggedInSession as verifyLoggedIn } from '~/common/session';
 import { Loader, type LoaderOf, ResourceLoader } from '~/core';
 import { UserLoader } from '../user';
 import { User } from '../user/dto';
@@ -47,9 +41,11 @@ export class CommentThreadResolver {
   async commentThreads(
     @IdArg({ name: 'resource' }) resourceId: ID,
     @ListArg(CommentThreadListInput) input: CommentThreadListInput,
-    @LoggedInSession() session: Session,
+    @AnonSession() session: Session,
     @Loader(CommentThreadLoader) commentThreads: LoaderOf<CommentThreadLoader>,
   ): Promise<CommentThreadList> {
+    // TODO move to auth policy
+    verifyLoggedIn(session);
     const resource = await this.service.loadCommentable(resourceId);
     const list = await this.service.listThreads(resource, input, session);
     commentThreads.primeAll(list.items);

src/components/comments/commentable.resolver.ts

@@ -1,12 +1,13 @@
 import { Info, Parent, Query, ResolveField, Resolver } from '@nestjs/graphql';
 import {
+  AnonSession,
   Fields,
   type ID,
   IdArg,
   IsOnly,
   ListArg,
-  LoggedInSession,
   type Resource,
+  SecuredList,
   type Session,
 } from '~/common';
 import { Loader, type LoaderOf } from '~/core';
@@ -31,10 +32,14 @@ export class CommentableResolver {
   async commentThreads(
     @Parent() parent: Commentable & Resource,
     @ListArg(CommentThreadListInput) input: CommentThreadListInput,
-    @LoggedInSession() session: Session,
+    @AnonSession() session: Session,
     @Loader(CommentThreadLoader) commentThreads: LoaderOf<CommentThreadLoader>,
     @Info(Fields, IsOnly(['total'])) onlyTotal: boolean,
   ) {
+    // TODO move to auth policy
+    if (session.anonymous) {
+      return { parent, ...SecuredList.Redacted };
+    }
     if (onlyTotal) {
       const total = await this.service.getThreadCount(parent, session);
       return { total };

src/components/post/postable.resolver.ts

@@ -1,9 +1,10 @@
 import { Info, Parent, ResolveField, Resolver } from '@nestjs/graphql';
 import { type GraphQLResolveInfo } from 'graphql';
 import {
+  AnonSession,
   ListArg,
-  LoggedInSession,
   type Resource,
+  SecuredList,
   type Session,
 } from '~/common';
 import { Loader, type LoaderOf } from '~/core';
@@ -23,9 +24,14 @@ export class PostableResolver {
     @Info() info: GraphQLResolveInfo & {},
     @Parent() parent: Postable & Resource,
     @ListArg(PostListInput) input: PostListInput,
-    @LoggedInSession() session: Session,
+    @AnonSession() session: Session,
     @Loader(PostLoader) posts: LoaderOf<PostLoader>,
   ): Promise<SecuredPostList> {
+    // TODO move to auth policy
+    if (session.anonymous) {
+      return SecuredList.Redacted;
+    }
+
     const list = await this.service.securedList(
       {
         ...parent,

src/components/product-progress/create-product-connection.resolver.ts

@@ -1,5 +1,5 @@
 import { Parent, ResolveField, Resolver } from '@nestjs/graphql';
-import { LoggedInSession, type Session, Variant } from '~/common';
+import { AnonSession, type Session, Variant } from '~/common';
 import { CreateProductOutput } from '../product/dto';
 import { ProductProgressService } from './product-progress.service';
 
@@ -12,8 +12,12 @@ export class ProgressReportCreateProductConnectionResolver {
   })
   async availableVariants(
     @Parent() { product }: CreateProductOutput,
-    @LoggedInSession() session: Session,
+    @AnonSession() session: Session,
   ): Promise<readonly Variant[]> {
+    // TODO move to auth policy
+    if (session.anonymous) {
+      return [];
+    }
     return await this.service.getAvailableVariantsForProduct(product, session);
   }
 }