Change notification recipients to use session ALS

Author: CarsonF

src/components/authentication/authentication.service.ts

@@ -230,6 +230,14 @@ export class AuthenticationService {
     return this.repo.waitForRootUserId();
   }
 
+  async asUser<R>(
+    userId: ID<'User'>,
+    fn: (session: Session) => Promise<R>,
+  ): Promise<R> {
+    const session = await this.sessionForUser(userId);
+    return await this.sessionHost.withSession(session, () => fn(session));
+  }
+
   async sessionForUser(userId: ID): Promise<Session> {
     const roles = await this.repo.rolesForUser(userId);
     const session: Session = {

src/components/progress-report/workflow/handlers/progress-report-workflow-notification.handler.ts

@@ -113,40 +113,43 @@ export class ProgressReportWorkflowNotificationHandler
     languageId: ID,
   ): Promise<EmailReportStatusNotification> {
     const recipientId = receiver.userId ?? this.configService.rootUser.id;
-    const recipientSession = await this.auth.sessionForUser(recipientId);
+    return await this.auth.asUser(recipientId, async (recipientSession) => {
+      const recipient = receiver.userId
+        ? await this.userService.readOne(recipientId, recipientSession)
+        : this.fakeUserFromEmailAddress(receiver.email!);
 
-    const recipient = receiver.userId
-      ? await this.userService.readOne(recipientId, recipientSession)
-      : this.fakeUserFromEmailAddress(receiver.email!);
+      const project = await this.projectService.readOne(
+        projectId,
+        recipientSession,
+      );
+      const language = await this.languageService.readOne(
+        languageId,
+        recipientSession,
+      );
+      const report = await this.reportService.readOne(
+        reportId,
+        recipientSession,
+      );
+      const changedBy = await this.userService.readOne(
+        unsecuredEvent.who.id,
+        recipientSession,
+      );
+      const workflowEvent = this.workflowService.secure(
+        unsecuredEvent,
+        recipientSession,
+      );
 
-    const project = await this.projectService.readOne(
-      projectId,
-      recipientSession,
-    );
-    const language = await this.languageService.readOne(
-      languageId,
-      recipientSession,
-    );
-    const report = await this.reportService.readOne(reportId, recipientSession);
-    const changedBy = await this.userService.readOne(
-      unsecuredEvent.who.id,
-      recipientSession,
-    );
-    const workflowEvent = this.workflowService.secure(
-      unsecuredEvent,
-      recipientSession,
-    );
-
-    return {
-      changedBy,
-      recipient,
-      project,
-      language,
-      report,
-      newStatusVal: report.status?.value,
-      previousStatusVal: report.status?.value ? previousStatus : undefined,
-      workflowEvent: workflowEvent,
-    };
+      return {
+        changedBy,
+        recipient,
+        project,
+        language,
+        report,
+        newStatusVal: report.status?.value,
+        previousStatusVal: report.status?.value ? previousStatus : undefined,
+        workflowEvent: workflowEvent,
+      };
+    });
   }
 
   private fakeUserFromEmailAddress(

src/components/project/workflow/handlers/project-workflow-notification.handler.ts

@@ -104,30 +104,31 @@ export class ProjectWorkflowNotificationHandler
     primaryPartnerName: string | null,
   ): Promise<ProjectStepChangedProps> {
     const recipientId = notifier.id ?? this.config.rootUser.id;
-    const recipientSession = await this.auth.sessionForUser(recipientId);
-    const recipient = notifier.id
-      ? await this.users.readOne(recipientId, recipientSession)
-      : ({
-          email: { value: notifier.email, canRead: true, canEdit: false },
-          displayFirstName: {
-            value: notifier.email!.split('@')[0],
-            canRead: true,
-            canEdit: false,
-          },
-          displayLastName: { value: '', canRead: true, canEdit: false },
-          timezone: {
-            value: this.config.defaultTimeZone,
-            canRead: true,
-            canEdit: false,
-          },
-        } satisfies ProjectStepChangedProps['recipient']);
+    return await this.auth.asUser(recipientId, async (recipientSession) => {
+      const recipient = notifier.id
+        ? await this.users.readOne(recipientId, recipientSession)
+        : ({
+            email: { value: notifier.email, canRead: true, canEdit: false },
+            displayFirstName: {
+              value: notifier.email!.split('@')[0],
+              canRead: true,
+              canEdit: false,
+            },
+            displayLastName: { value: '', canRead: true, canEdit: false },
+            timezone: {
+              value: this.config.defaultTimeZone,
+              canRead: true,
+              canEdit: false,
+            },
+          } satisfies ProjectStepChangedProps['recipient']);
 
-    return {
-      recipient,
-      changedBy: this.users.secure(changedBy, recipientSession),
-      project: this.projects.secure(project, recipientSession),
-      previousStep,
-      primaryPartnerName,
-    };
+      return {
+        recipient,
+        changedBy: this.users.secure(changedBy, recipientSession),
+        project: this.projects.secure(project, recipientSession),
+        previousStep,
+        primaryPartnerName,
+      };
+    });
   }
 }