Await HttpAdapter.reply / FastifyReply.send

Author: CarsonF

src/core/exception/exception.filter.ts

@@ -18,7 +18,7 @@ export class ExceptionFilter implements GqlExceptionFilter {
     private readonly normalizer: ExceptionNormalizer,
   ) {}
 
-  catch(exception: Error, args: ArgumentsHost) {
+  async catch(exception: Error, args: ArgumentsHost) {
     if (exception && (exception as any).type === 'request.aborted') {
       this.logger.warning('Request aborted');
       return;
@@ -43,7 +43,7 @@ export class ExceptionFilter implements GqlExceptionFilter {
     if (args.getType() === 'graphql') {
       this.respondToGraphQL(normalized, args);
     }
-    this.respondToHttp(normalized, args);
+    await this.respondToHttp(normalized, args);
   }
 
   private respondToGraphQL(ex: ExceptionJson, _args: ArgumentsHost) {
@@ -53,7 +53,7 @@ export class ExceptionFilter implements GqlExceptionFilter {
     throw Object.assign(new Error(), out);
   }
 
-  private respondToHttp(ex: ExceptionJson, args: ArgumentsHost) {
+  private async respondToHttp(ex: ExceptionJson, args: ArgumentsHost) {
     const { codes } = ex;
     const status = codes.has('NotFound')
       ? HttpStatus.NOT_FOUND
@@ -78,7 +78,7 @@ export class ExceptionFilter implements GqlExceptionFilter {
     };
 
     const res = args.switchToHttp().getResponse();
-    this.http.reply(res, out, status);
+    await this.http.reply(res, out, status);
   }
 
   logIt(info: ExceptionJson, error: Error) {

src/core/http/http.adapter.ts

@@ -128,17 +128,6 @@ export class HttpAdapter extends PatchedFastifyAdapter {
     void response.cookie(name, value, options);
   }
 
-  // @ts-expect-error we don't need to be compatible with base
-  reply(
-    response: IResponse | IResponse['raw'],
-    body: any,
-    statusCode?: number,
-  ) {
-    // Avoid linter wanting us to await sending response.
-    // This method just returns the response instance for fluent interface.
-    void super.reply(response, body, statusCode);
-  }
-
   // @ts-expect-error we don't need to be compatible with base
   setHeader(response: IResponse, name: string, value: string) {
     // Avoid linter wanting us to await sending response.