Move default notifiers into the workflow natively

Author: CarsonF

src/components/project/workflow/handlers/project-workflow-notification.handler.ts

@@ -20,7 +20,6 @@ import { User } from '../../../user/dto';
 import { Notifier } from '../../../workflow/transitions/notifiers';
 import { Project, ProjectStep } from '../../dto';
 import { ProjectTransitionedEvent } from '../events/project-transitioned.event';
-import { TeamMembers } from '../transitions/notifiers';
 
 @EventsHandler(ProjectTransitionedEvent)
 export class ProjectWorkflowNotificationHandler
@@ -41,11 +40,8 @@ export class ProjectWorkflowNotificationHandler
     const { previousStep, next, workflowEvent } = event;
     const transition = typeof next !== 'string' ? next : undefined;
 
-    const notifiers = [
-      TeamMembers,
-      ...(transition?.notifiers ?? []),
-      // TODO on bypass: keep notifying members? add anyone else?
-    ];
+    // TODO on bypass: keep notifying members? add anyone else?
+    const notifiers = transition?.notifiers ?? [];
 
     const params = { project: event.project, moduleRef: this.moduleRef };
     const notifyees = (

src/components/project/workflow/project-workflow.ts

@@ -12,7 +12,11 @@ import {
   BackToActive,
   ResolveParams,
 } from './transitions/dynamic-step';
-import { EmailDistros, FinancialApprovers } from './transitions/notifiers';
+import {
+  EmailDistros,
+  FinancialApprovers,
+  TeamMembers,
+} from './transitions/notifiers';
 
 // This also controls the order shown in the UI.
 // Therefore, these should generally flow down.
@@ -24,6 +28,7 @@ export const ProjectWorkflow = defineWorkflow({
   states: Step,
   event: ProjectWorkflowEvent,
   context: defineContext<ResolveParams>,
+  defaultNotifiers: [TeamMembers],
 })({
   'Early Conversations -> Pending Regional Director Approval': {
     from: Step.EarlyConversations,

src/components/workflow/define-workflow.ts

@@ -9,6 +9,7 @@ import {
   ResourceShape,
 } from '~/common';
 import { WorkflowEvent } from './dto';
+import { TransitionNotifier } from './transitions/notifiers';
 import { InternalTransition, TransitionInput } from './transitions/types';
 
 export const defineWorkflow =
@@ -31,6 +32,10 @@ export const defineWorkflow =
      * context: defineContext<X>
      */
     context: () => Context;
+    /**
+     * Notifiers that apply to all transitions by default.
+     */
+    defaultNotifiers?: ReadonlyArray<TransitionNotifier<Context>>;
   }) =>
   <TransitionNames extends string>(
     obj: Record<TransitionNames, TransitionInput<State, Context>>,
@@ -46,7 +51,10 @@ export const defineWorkflow =
         from: transition.from ? setOf(many(transition.from)) : undefined,
         key: (transition.key ?? uuid.v5(name, input.id)) as ID,
         conditions: maybeMany(transition.conditions),
-        notifiers: maybeMany(transition.notifiers),
+        notifiers: [
+          ...(input.defaultNotifiers ?? []),
+          ...(maybeMany(transition.notifiers) ?? []),
+        ],
       }),
     ).asRecord as Record<
       TransitionNames,