Revert #3309 / 1fa42ad for EnforceChangesetEditablePipe (#3408)

I didn't realize it at the time, but because this is a global pipe, it applies as a dependency to all controllers/resolvers. Making this request scoped means all controllers/resolvers become request scoped as well.

Revert to using `GqlContextHost`/ALS and add `contextMaybe` to prevent the former try/catch need.

Author: CarsonF

src/components/changeset/enforce-changeset-editable.pipe.ts

@@ -1,12 +1,9 @@
 import {
   ArgumentMetadata,
-  Inject,
   Injectable,
   PipeTransform,
-  Scope,
   Type,
 } from '@nestjs/common';
-import { CONTEXT } from '@nestjs/graphql';
 import { hasCtor, isRegularObject } from '@seedcompany/common';
 import {
   DataLoaderContext,
@@ -18,7 +15,7 @@ import {
   isIdLike,
   loadManyIgnoreMissingThrowAny,
 } from '~/common';
-import { isGqlContext } from '~/core/graphql';
+import { GqlContextHost, ifGqlContext } from '~/core/graphql';
 import { ResourceLoaderRegistry } from '~/core/resources/loader.registry';
 import { Changeset } from './dto';
 import { shouldValidateEditability } from './validate-editability.decorator';
@@ -37,12 +34,10 @@ import { shouldValidateEditability } from './validate-editability.decorator';
  * it is called for every argument of every resolver/controller.
  * So we want to be careful to do as little work as possible.
  */
-@Injectable({ scope: Scope.REQUEST })
+@Injectable()
 export class EnforceChangesetEditablePipe implements PipeTransform {
   constructor(
-    // This is only the GQL context if this is a GQL execution context.
-    // If it is http, then it is the request.
-    @Inject(CONTEXT) private readonly context: unknown,
+    private readonly gqlContextHost: GqlContextHost,
     private readonly loaderRegistry: ResourceLoaderRegistry,
     private readonly loaderContext: DataLoaderContext,
   ) {}
@@ -58,7 +53,7 @@ export class EnforceChangesetEditablePipe implements PipeTransform {
       return;
     }
 
-    const context = isGqlContext(this.context) ? this.context : undefined;
+    const context = ifGqlContext(this.gqlContextHost.contextMaybe);
     if (context?.operation.operation !== 'mutation') {
       return;
     }

src/core/graphql/gql-context.host.ts

@@ -1,11 +1,14 @@
 import { Injectable, OnModuleDestroy } from '@nestjs/common';
+import { isObjectLike } from '@seedcompany/common';
 import { AsyncLocalStorage } from 'async_hooks';
 import { GqlContextType as ContextType } from '~/common';
 import { AsyncLocalStorageNoContextException } from '../async-local-storage-no-context.exception';
 import { Plugin } from './plugin.decorator';
 
+export const ifGqlContext = (object: unknown): ContextType | undefined =>
+  isGqlContext(object) ? object : undefined;
 export const isGqlContext = (object: unknown): object is ContextType =>
-  object != null && typeof object === 'object' && isGqlContext.KEY in object;
+  isObjectLike(object) && isGqlContext.KEY in object;
 isGqlContext.KEY = Symbol('GqlContext');
 
 /**
@@ -16,13 +19,22 @@ export abstract class GqlContextHost {
    * The current GraphQL context
    */
   readonly context: ContextType;
+
+  /**
+   * The current GraphQL context
+   */
+  readonly contextMaybe: ContextType | undefined;
 }
 
 @Injectable()
 @Plugin()
 export class GqlContextHostImpl implements GqlContextHost, OnModuleDestroy {
   als = new AsyncLocalStorage<ContextType>();
 
+  get contextMaybe() {
+    return this.als.getStore();
+  }
+
   get context() {
     const context = this.als.getStore();
     if (context) {

src/core/graphql/index.ts

@@ -1,3 +1,3 @@
 export * from './graphql.module';
-export { GqlContextHost, isGqlContext } from './gql-context.host';
+export { GqlContextHost, isGqlContext, ifGqlContext } from './gql-context.host';
 export * from './plugin.decorator';