Address logical changes found by no-unnecessary-condition lint

However, these are still minor and I would not consider them "bug fixes".
That said the resulting code is still "cleaner".

Author: CarsonF

src/common/resource.dto.ts

@@ -110,7 +110,12 @@ export class EnhancedResource<T extends ResourceShape<any>> {
   >();
 
   static resolve(ref: ResourceLike) {
-    if (ref && typeof ref !== 'string') {
+    // Safety check; since this very dynamic code, it is very possible the types are lying.
+    // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
+    if (ref == null) {
+      throw new ServerException('Resource reference is actually null');
+    }
+    if (typeof ref !== 'string') {
       return EnhancedResource.of(ref);
     }
     if (!EnhancedResource.resourcesHost) {

src/components/file/bucket/parse-uri.ts

@@ -14,12 +14,12 @@ export const parseUri = (uri: string): ParsedBucketUri => {
     // Shouldn't ever happen
     throw new Error('Failed to parse Bucket URI');
   }
-  const type = typeMatch[1]!;
+  const type = typeMatch[1]?.toLowerCase() ?? '';
   const remainingSrc = typeMatch[2]!;
   const roMatch = /(:ro|:readonly)$/i.exec(remainingSrc);
   const readonly = !!roMatch;
   const path = roMatch
     ? remainingSrc.slice(0, -roMatch[0].length)
     : remainingSrc;
-  return { type: type?.toLowerCase() ?? '', path, readonly };
+  return { type, path, readonly };
 };

src/components/file/file.service.ts

@@ -327,13 +327,10 @@ export class FileService {
       tempUpload.status === 'fulfilled' &&
       existingUpload.status === 'fulfilled'
     ) {
-      if (tempUpload.value && existingUpload.value) {
-        throw new InputException(
-          'Upload request has already been used',
-          'uploadId',
-        );
-      }
-      throw new CreationFailed(FileVersion);
+      throw new InputException(
+        'Upload request has already been used',
+        'uploadId',
+      );
     } else if (
       tempUpload.status === 'rejected' &&
       existingUpload.status === 'fulfilled'

src/components/location/migrations/default-marketing-region.migration.ts

@@ -47,7 +47,7 @@ export class DefaultMarketingRegionMigration extends BaseMigration {
     const marketingRegionNameToId = mapEntries(marketingRegionList, (loc) => [
       loc.name,
       loc.id,
-    ]).asRecord;
+    ]).asMap;
 
     const countries = await this.db
       .query()
@@ -72,7 +72,8 @@ export class DefaultMarketingRegionMigration extends BaseMigration {
     for (const country of countries) {
       const marketingRegionName =
         fieldRegionNameToMarketingRegionName[country.fieldRegionName];
-      const marketingRegionId = marketingRegionNameToId[marketingRegionName];
+      const marketingRegionId =
+        marketingRegionNameToId.get(marketingRegionName);
       if (marketingRegionId === undefined) {
         continue;
       }

src/components/project/project-member/project-member.repository.ts

@@ -14,6 +14,7 @@ import {
   isIdLike,
   NotFoundException,
   type Role,
+  ServerException,
   type UnsecuredDto,
 } from '~/common';
 import { DtoRepository } from '~/core/database';
@@ -73,7 +74,11 @@ export class ProjectMemberRepository extends DtoRepository(ProjectMember) {
         'member',
       ])
       .first();
-
+    if (!result) {
+      throw new ServerException(
+        'Failed to gather info for relationship verification',
+      );
+    }
     if (!result?.project) {
       throw new NotFoundException(
         'Could not find project',

src/core/authentication/session/session.initiator.ts

@@ -1,5 +1,5 @@
 import { forwardRef, Inject, Injectable } from '@nestjs/common';
-import { csv, setOf } from '@seedcompany/common';
+import { asNonEmptyArray, csv, setOf } from '@seedcompany/common';
 import {
   type ID,
   InputException,
@@ -111,10 +111,10 @@ const assertValidRole = (role: string): Role => {
   );
 };
 
-function csvHeader(headerVal: Many<string> | undefined) {
+function csvHeader(headerVal: Many<string | undefined> | undefined) {
   if (!headerVal) {
     return undefined;
   }
   const items = many(headerVal).flatMap((itemCsv) => csv(itemCsv ?? ''));
-  return items && items.length > 0 ? items : undefined;
+  return asNonEmptyArray(items);
 }

src/core/database/query/create-relationships.ts

@@ -1,3 +1,4 @@
+import { entries } from '@seedcompany/common';
 import { createHash } from 'crypto';
 import { node, type Query, relation } from 'cypher-query-builder';
 import { type RelationDirection } from 'cypher-query-builder/dist/typings/clauses/relation-pattern';
@@ -90,20 +91,20 @@ export function createRelationships<TResourceStatic extends ResourceShape<any>>(
   maybeLabelsToRelationships?: RelationshipDefinition,
 ) {
   resource = EnhancedResource.of(resource);
-  const normalizedArgs =
+  const normalizedArgs: AnyDirectionalDefinition =
     typeof directionOrDefinition === 'string'
       ? { [directionOrDefinition]: maybeLabelsToRelationships }
       : directionOrDefinition;
 
-  const flattened = Object.entries(normalizedArgs).flatMap(
+  const flattened = entries(normalizedArgs).flatMap(
     ([direction, relationships]) =>
-      Object.entries(relationships ?? {}).flatMap(([relLabel, varOrTuple]) =>
+      Object.entries(relationships).flatMap(([relLabel, varOrTuple]) =>
         many(Array.isArray(varOrTuple) ? varOrTuple[1] ?? [] : varOrTuple).map(
           (id, i) => ({
             nodeLabel: Array.isArray(varOrTuple) ? varOrTuple[0] : undefined, // no labels for variables
             id,
-            direction: direction as RelationDirection,
-            relLabel: relLabel,
+            direction,
+            relLabel,
             variable: !Array.isArray(varOrTuple)
               ? varOrTuple instanceof Variable
                 ? varOrTuple.value
@@ -123,9 +124,9 @@ export function createRelationships<TResourceStatic extends ResourceShape<any>>(
     return (query: Query) => query;
   }
 
-  // We are creating inside of changeset if there's a changeset relation into the node.
+  // We're creating inside a changeset if there is a changeset relation into the node.
   const inChangeset = flattened.some(
-    (f) => f.direction === 'in' && f.relLabel === 'changeset' && f.id,
+    (f) => f.direction === 'in' && f.relLabel === 'changeset',
   );
 
   const createdAt = DateTime.local();

src/core/database/query/filters.ts

@@ -176,11 +176,11 @@ export const pathExists =
   ): Builder<T, K> =>
   ({ key, value }) => {
     const cond = pathPattern(isFunction(pattern) ? pattern(value) : pattern);
-    return { [key]: value ? cond : not(cond) };
+    return { [key]: value !== false ? cond : not(cond) };
   };
 
 export const pathExistsWhenTrue: typeof pathExists = (pattern) => (args) =>
-  args.value ? pathExists(pattern)(args) : null;
+  args.value !== false ? pathExists(pattern)(args) : null;
 
 export const isPinned = pathExists<{ pinned?: boolean }, 'pinned'>([
   currentUser,