Merge pull request #2883 from SeedCompany/progress-report/media

Progress Report Media

Author: CarsonF

src/common/variant.dto.ts

@@ -72,22 +72,29 @@ export type VariantOf<TResourceStatic extends ResourceShape<any>> =
  */
 export const VariantInputField = <
   Res extends ResourceShape<any> & { Variants: readonly Variant[] },
+  Many extends undefined | true = undefined,
 >(
   resource: Res,
   options: Omit<FieldOptions, 'defaultValue'> & {
-    defaultValue?: Variant<VariantOf<Res>> | VariantOf<Res>;
+    many?: Many;
+    defaultValue?: Many extends true
+      ? ReadonlyArray<Variant<VariantOf<Res>> | VariantOf<Res>>
+      : Variant<VariantOf<Res>> | VariantOf<Res>;
   } = {},
 ) => {
-  const { defaultValue, ...rest } = options;
+  const { many, defaultValue, ...rest } = options;
 
   // Resolve default to variant object
-  const defaultVariant =
-    typeof defaultValue === 'string'
-      ? resource.Variants.find((v) => v.key === options.defaultValue)
-      : defaultValue;
+  const resolveVariant = (value: Variant<VariantOf<Res>> | VariantOf<Res>) =>
+    typeof value === 'string'
+      ? resource.Variants.find((v) => v.key === value)
+      : value;
+  const defaultVariant = many
+    ? (defaultValue as any[])?.map(resolveVariant)
+    : resolveVariant(defaultValue as VariantOf<Res>);
 
   return applyDecorators(
-    Field(() => IDType, {
+    Field(() => (many ? [IDType] : IDType), {
       // Don't put default value in schema as we are trying to keep specific
       // values out of schema, so they can be more dynamic.
       nullable: !!defaultValue,
@@ -97,11 +104,15 @@ export const VariantInputField = <
       if (value == null) {
         return defaultVariant;
       }
-      return resource.Variants.find((v) => v.key === value) ?? value;
+      if (many && Array.isArray(value)) {
+        return value.map(resolveVariant);
+      }
+      return resolveVariant(value);
     }),
     IsIn(resource.Variants, {
       message: ({ value }) =>
         `Variant with key "${String(value)}" was not found`,
+      each: many,
     }),
   );
 };

src/components/authorization/policies/by-feature/progress-report-media-owner.policy.ts

@@ -0,0 +1,4 @@
+import { owner, Policy } from '../util';
+
+@Policy('all', (r) => r.ProgressReportMedia.when(owner).edit.delete)
+export class ProgressReportMediaOwnerPolicy {}

src/components/authorization/policies/by-role/consultant-manager.policy.ts

@@ -46,6 +46,7 @@ import { member, Policy, Role, sensMediumOrLower, sensOnlyLow } from '../util';
     r.ProgressReportCommunityStory,
     r.ProgressReportHighlight,
     r.ProgressReportTeamNews,
+    r.ProgressReportMedia,
     r.ProgressReportVarianceExplanation,
     r.StepProgress,
   ].map((it) => it.whenAny(member, sensMediumOrLower).read),

src/components/authorization/policies/by-role/consultant.policy.ts

@@ -17,6 +17,7 @@ import { member, Policy, Role } from '../util';
     r.ProgressReportCommunityStory,
     r.ProgressReportHighlight,
     r.ProgressReportTeamNews,
+    r.ProgressReportMedia,
     r.ProgressReportVarianceExplanation,
     r.StepProgress,
   ].map((it) => it.when(member).read),

src/components/authorization/policies/by-role/field-partner.policy.ts

@@ -24,6 +24,7 @@ import { member, Policy, Role, variant } from '../util';
       p.responses.whenAll(member, variant('draft')).edit,
     ]),
   ]),
+  r.ProgressReportMedia.whenAll(member, variant('draft')).create.edit,
   r.ProgressReportWorkflowEvent.transitions(
     'Start',
     'In Progress -> In Review',

src/components/authorization/policies/by-role/marketing.policy.ts

@@ -27,6 +27,7 @@ import {
       p.responses.read.when(variant('published')).edit,
     ]),
   ]),
+  r.ProgressReportMedia.read.when(variant('published')).create.edit,
   r.ProgressReportVarianceExplanation.read.specifically((p) => p.comments.none),
   r.ProgressReportWorkflowEvent.read.transitions('Publish').execute,
   r.Project.read

src/components/authorization/policies/by-role/project-manager.policy.ts

@@ -65,6 +65,11 @@ import {
         p.responses.whenAll(member, variant('draft', 'translated', 'fpm')).edit,
       ]),
     ]),
+    [r.ProgressReportMedia].flatMap((it) => [
+      it.whenAll(sensOnlyLow, variant('fpm', 'published')).read,
+      it.when(member).read,
+      it.whenAll(member, variant('draft', 'translated', 'fpm')).create.edit,
+    ]),
     r.ProgressReportVarianceExplanation.edit,
     r.ProgressReportWorkflowEvent.read.transitions(
       'Start',

src/components/authorization/policies/by-role/translator.policy.ts

@@ -29,6 +29,10 @@ import { member, Policy, Role, variant } from '../util';
       p.responses.whenAll(member, variant('translated')).edit,
     ]),
   ]),
+  [r.ProgressReportMedia].flatMap((it) => [
+    it.when(member).read,
+    it.whenAll(member, variant('translated')).create.edit,
+  ]),
   r.ProgressReportWorkflowEvent.transitions(
     'Translation Done',
     'Translation Reject',

src/components/authorization/policies/conditions/variant.condition.ts

@@ -33,7 +33,7 @@ class VariantCondition<TResourceStatic extends ResourceShape<any>>
 
   asCypherCondition(query: Query, _other: AsCypherParams<TResourceStatic>) {
     const variants = query.params.addParam([...this.variants], 'variants');
-    return `node.variant = ${String(variants)}`; // TODO hand waving
+    return `node.variant = ${String(variants)}`;
   }
 
   union(this: void, conditions: this[]) {

src/components/authorization/policies/index.ts

@@ -19,6 +19,7 @@ export * from './by-role/staff-member.policy';
 export * from './by-role/translator.policy';
 
 export * from './by-feature/engagements-create-delete.policy';
+export * from './by-feature/progress-report-media-owner.policy';
 export * from './by-feature/project-change-requests-beta.policy';
 export * from './by-feature/read-util-objects.policy';
 export * from './by-feature/user-can-edit-self.policy';