Drop old useless constructor arg on repos

CarsonF · CarsonF · commit 1af81dabb6a8 · 2023-11-30T13:01:35.000-06:00
diff --git a/src/components/budget/budget.repository.ts b/src/components/budget/budget.repository.ts
@@ -12,7 +12,7 @@ import {
   UnsecuredDto,
   viewOfChangeset,
 } from '../../common';
-import { DatabaseService, DtoRepository } from '../../core';
+import { DtoRepository } from '../../core';
 import {
   ACTIVE,
   createNode,
@@ -43,11 +43,8 @@ export class BudgetRepository extends DtoRepository<
   typeof Budget,
   [session: Session, view?: ObjectView]
 >(Budget) {
-  constructor(
-    db: DatabaseService,
-    private readonly records: BudgetRecordRepository,
-  ) {
-    super(db);
+  constructor(private readonly records: BudgetRecordRepository) {
+    super();
   }
 
   async doesProjectExist(projectId: ID, session: Session) {
diff --git a/src/components/comments/comment-thread.repository.ts b/src/components/comments/comment-thread.repository.ts
@@ -1,7 +1,7 @@
 import { forwardRef, Inject, Injectable } from '@nestjs/common';
 import { node, Query, relation } from 'cypher-query-builder';
 import { ID, Session, UnsecuredDto } from '../../common';
-import { DatabaseService, DtoRepository } from '../../core';
+import { DtoRepository } from '../../core';
 import {
   ACTIVE,
   createNode,
@@ -19,9 +19,8 @@ export class CommentThreadRepository extends DtoRepository(CommentThread) {
   constructor(
     @Inject(forwardRef(() => CommentRepository))
     private readonly comments: CommentRepository & {},
-    db: DatabaseService,
   ) {
-    super(db);
+    super();
   }
 
   async create(parent: ID, session: Session) {
diff --git a/src/components/comments/comment.repository.ts b/src/components/comments/comment.repository.ts
@@ -3,7 +3,7 @@ import { node, Query, relation } from 'cypher-query-builder';
 import { DateTime } from 'luxon';
 import { ChangesOf } from '~/core/database/changes';
 import { ID, Session, UnsecuredDto } from '../../common';
-import { DatabaseService, DtoRepository } from '../../core';
+import { DtoRepository } from '../../core';
 import {
   ACTIVE,
   createNode,
@@ -28,9 +28,8 @@ export class CommentRepository extends DtoRepository(Comment) {
   constructor(
     @Inject(forwardRef(() => CommentThreadRepository))
     readonly threads: CommentThreadRepository & {},
-    db: DatabaseService,
   ) {
-    super(db);
+    super();
   }
 
   async create(input: CreateCommentInput, session: Session) {
diff --git a/src/components/engagement/engagement.repository.ts b/src/components/engagement/engagement.repository.ts
@@ -16,7 +16,7 @@ import {
   UnsecuredDto,
   viewOfChangeset,
 } from '../../common';
-import { CommonRepository, DatabaseService, OnIndex } from '../../core';
+import { CommonRepository, OnIndex } from '../../core';
 import { ChangesOf, getChanges } from '../../core/database/changes';
 import {
   ACTIVE,
@@ -56,8 +56,8 @@ export type LanguageOrEngagementId = MergeExclusive<
 
 @Injectable()
 export class EngagementRepository extends CommonRepository {
-  constructor(db: DatabaseService, private readonly privileges: Privileges) {
-    super(db);
+  constructor(private readonly privileges: Privileges) {
+    super();
   }
 
   async readOne(id: ID, session: Session, view?: ObjectView) {
diff --git a/src/components/ethno-art/ethno-art.repository.ts b/src/components/ethno-art/ethno-art.repository.ts
@@ -2,7 +2,7 @@ import { Injectable } from '@nestjs/common';
 import { Query } from 'cypher-query-builder';
 import { ChangesOf } from '~/core/database/changes';
 import { ID, Session } from '../../common';
-import { DatabaseService, DbTypeOf, DtoRepository } from '../../core';
+import { DbTypeOf, DtoRepository } from '../../core';
 import {
   createNode,
   matchProps,
@@ -20,11 +20,8 @@ import {
 
 @Injectable()
 export class EthnoArtRepository extends DtoRepository(EthnoArt) {
-  constructor(
-    private readonly scriptureRefs: ScriptureReferenceRepository,
-    db: DatabaseService,
-  ) {
-    super(db);
+  constructor(private readonly scriptureRefs: ScriptureReferenceRepository) {
+    super();
   }
   async create(input: CreateEthnoArt, _session: Session) {
     const initialProps = {
diff --git a/src/components/file/file.repository.ts b/src/components/file/file.repository.ts
@@ -22,7 +22,6 @@ import {
 } from '../../common';
 import {
   CommonRepository,
-  DatabaseService,
   ILogger,
   Logger,
   OnIndex,
@@ -54,11 +53,8 @@ import {
 
 @Injectable()
 export class FileRepository extends CommonRepository {
-  constructor(
-    db: DatabaseService,
-    @Logger('file:repository') private readonly logger: ILogger,
-  ) {
-    super(db);
+  constructor(@Logger('file:repository') private readonly logger: ILogger) {
+    super();
   }
 
   @OnIndex()
diff --git a/src/components/film/film.repository.ts b/src/components/film/film.repository.ts
@@ -2,7 +2,7 @@ import { Injectable } from '@nestjs/common';
 import { node, Query } from 'cypher-query-builder';
 import { ChangesOf } from '~/core/database/changes';
 import { ID, Session } from '../../common';
-import { DatabaseService, DbTypeOf, DtoRepository } from '../../core';
+import { DbTypeOf, DtoRepository } from '../../core';
 import {
   createNode,
   matchProps,
@@ -17,11 +17,8 @@ import { CreateFilm, Film, FilmListInput, UpdateFilm } from './dto';
 
 @Injectable()
 export class FilmRepository extends DtoRepository(Film) {
-  constructor(
-    private readonly scriptureRefs: ScriptureReferenceRepository,
-    db: DatabaseService,
-  ) {
-    super(db);
+  constructor(private readonly scriptureRefs: ScriptureReferenceRepository) {
+    super();
   }
 
   async create(input: CreateFilm, session: Session) {
diff --git a/src/components/periodic-report/periodic-report.repository.ts b/src/components/periodic-report/periodic-report.repository.ts
@@ -18,7 +18,7 @@ import {
   Session,
   UnsecuredDto,
 } from '../../common';
-import { DatabaseService, DtoRepository } from '../../core';
+import { DtoRepository } from '../../core';
 import {
   ACTIVE,
   createNode,
@@ -53,9 +53,8 @@ export class PeriodicReportRepository extends DtoRepository<
 >(IPeriodicReport) {
   constructor(
     private readonly progressRepo: ProgressReportExtraForPeriodicInterfaceRepository,
-    db: DatabaseService,
   ) {
-    super(db);
+    super();
   }
 
   async merge(input: MergePeriodicReports) {
diff --git a/src/components/product/product.repository.ts b/src/components/product/product.repository.ts
@@ -17,12 +17,7 @@ import {
   ServerException,
   Session,
 } from '../../common';
-import {
-  CommonRepository,
-  DatabaseService,
-  DbTypeOf,
-  OnIndex,
-} from '../../core';
+import { CommonRepository, DbTypeOf, OnIndex } from '../../core';
 import { DbChanges, getChanges } from '../../core/database/changes';
 import {
   ACTIVE,
@@ -80,11 +75,8 @@ export type HydratedProductRow = Merge<
 
 @Injectable()
 export class ProductRepository extends CommonRepository {
-  constructor(
-    private readonly scriptureRefs: ScriptureReferenceRepository,
-    db: DatabaseService,
-  ) {
-    super(db);
+  constructor(private readonly scriptureRefs: ScriptureReferenceRepository) {
+    super();
   }
 
   async readMany(ids: readonly ID[], session: Session) {
diff --git a/src/components/project/project-member/project-member.repository.ts b/src/components/project/project-member/project-member.repository.ts
@@ -3,7 +3,7 @@ import { Node, node, Query, relation } from 'cypher-query-builder';
 import { DateTime } from 'luxon';
 import { ChangesOf } from '~/core/database/changes';
 import { ID, Session, UnsecuredDto } from '../../../common';
-import { DatabaseService, DtoRepository } from '../../../core';
+import { DtoRepository } from '../../../core';
 import {
   ACTIVE,
   matchPropsAndProjectSensAndScopedRoles,
@@ -27,8 +27,8 @@ export class ProjectMemberRepository extends DtoRepository<
   typeof ProjectMember,
   [session: Session]
 >(ProjectMember) {
-  constructor(private readonly users: UserRepository, db: DatabaseService) {
-    super(db);
+  constructor(private readonly users: UserRepository) {
+    super();
   }
 
   async verifyRelationshipEligibility(projectId: ID, userId: ID) {
diff --git a/src/components/project/project.repository.ts b/src/components/project/project.repository.ts
@@ -9,12 +9,7 @@ import {
   Session,
   UnsecuredDto,
 } from '../../common';
-import {
-  CommonRepository,
-  ConfigService,
-  DatabaseService,
-  OnIndex,
-} from '../../core';
+import { CommonRepository, ConfigService, OnIndex } from '../../core';
 import { ChangesOf, getChanges } from '../../core/database/changes';
 import {
   ACTIVE,
@@ -46,11 +41,10 @@ import { projectListFilter } from './list-filter.query';
 @Injectable()
 export class ProjectRepository extends CommonRepository {
   constructor(
-    db: DatabaseService,
     private readonly config: ConfigService,
     private readonly privileges: Privileges,
   ) {
-    super(db);
+    super();
   }
 
   async getRoles(session: Session) {
diff --git a/src/components/story/story.repository.ts b/src/components/story/story.repository.ts
@@ -3,7 +3,7 @@ import { Query } from 'cypher-query-builder';
 import { ChangesOf } from '~/core/database/changes';
 import { DbTypeOf } from '~/core/database/db-type';
 import { ID, Session } from '../../common';
-import { DatabaseService, DtoRepository } from '../../core';
+import { DtoRepository } from '../../core';
 import {
   createNode,
   matchProps,
@@ -17,11 +17,8 @@ import { CreateStory, Story, StoryListInput, UpdateStory } from './dto';
 
 @Injectable()
 export class StoryRepository extends DtoRepository(Story) {
-  constructor(
-    private readonly scriptureRefs: ScriptureReferenceRepository,
-    db: DatabaseService,
-  ) {
-    super(db);
+  constructor(private readonly scriptureRefs: ScriptureReferenceRepository) {
+    super();
   }
 
   async create(input: CreateStory, session: Session) {
diff --git a/src/core/database/common.repository.ts b/src/core/database/common.repository.ts
@@ -1,4 +1,4 @@
-import { Inject, Injectable, Optional } from '@nestjs/common';
+import { Inject, Injectable } from '@nestjs/common';
 import { setOf } from '@seedcompany/common';
 import { inArray, node, relation } from 'cypher-query-builder';
 import { DateTime } from 'luxon';
@@ -27,9 +27,6 @@ export class CommonRepository {
   @Inject(DatabaseService)
   protected db: DatabaseService;
 
-  // eslint-disable-next-line @typescript-eslint/no-empty-function,@typescript-eslint/no-useless-constructor
-  constructor(@Optional() _old?: unknown) {}
-
   async isUnique(value: string, label: string) {
     const exists = await this.db
       .query()
