Remove unnecessary checks on unexpected null input

These were added early on in a response to null problems.
I believe these resulted from cypher queries whose types
didn't match the reality of execution.
One service would call another with the result of db types, and boom.

Now we understand Cypher a lot better and can rely on these types.

Author: CarsonF

src/components/budget/budget.service.ts

@@ -4,7 +4,6 @@ import {
   DuplicateException,
   generateId,
   type ID,
-  InputException,
   type ObjectView,
   Order,
   ServerException,
@@ -70,14 +69,6 @@ export class BudgetService {
     input: CreateBudgetRecord,
     changeset?: ID,
   ): Promise<BudgetRecord> {
-    const { organizationId, fiscalYear } = input;
-
-    if (!fiscalYear || !organizationId) {
-      throw new InputException(
-        !fiscalYear ? 'budget.fiscalYear' : 'budget.organizationId',
-      );
-    }
-
     await this.verifyRecordUniqueness(input);
 
     try {

src/components/ceremony/ceremony.service.ts

@@ -1,7 +1,6 @@
 import { Injectable } from '@nestjs/common';
 import {
   type ID,
-  InputException,
   type ObjectView,
   ServerException,
   type UnsecuredDto,
@@ -26,10 +25,6 @@ export class CeremonyService {
 
   @HandleIdLookup(Ceremony)
   async readOne(id: ID, _view?: ObjectView): Promise<Ceremony> {
-    if (!id) {
-      throw new InputException('No ceremony id to search for', 'ceremony.id');
-    }
-
     const dto = await this.repo.readOne(id);
     return this.secure(dto);
   }

src/components/funding-account/funding-account.service.ts

@@ -57,10 +57,6 @@ export class FundingAccountService {
 
   @HandleIdLookup(FundingAccount)
   async readOne(id: ID, _view?: ObjectView): Promise<FundingAccount> {
-    if (!id) {
-      throw new NotFoundException('Invalid: Blank ID');
-    }
-
     const result = await this.repo.readOne(id);
     return await this.secure(result);
   }

src/components/language/ethnologue-language/ethnologue-language.service.ts

@@ -41,7 +41,6 @@ export class EthnologueLanguageService {
     input: UpdateEthnologueLanguage,
     sensitivity: Sensitivity,
   ) {
-    if (!input) return;
     const ethnologueLanguage = await this.repo.readOne(id);
 
     const changes = this.repo.getActualChanges(ethnologueLanguage, input);

src/components/periodic-report/periodic-report.service.ts

@@ -4,7 +4,6 @@ import {
   CreationFailed,
   DateInterval,
   type ID,
-  NotFoundException,
   type ObjectView,
   type Range,
   type UnsecuredDto,
@@ -92,13 +91,6 @@ export class PeriodicReportService {
 
   @HandleIdLookup([FinancialReport, NarrativeReport, ProgressReport])
   async readOne(id: ID, _view?: ObjectView): Promise<PeriodicReport> {
-    if (!id) {
-      throw new NotFoundException(
-        'No periodic report id to search for',
-        'periodicReport.id',
-      );
-    }
-
     const result = await this.repo.readOne(id);
     return this.secure(result);
   }

src/components/post/post.service.ts

@@ -34,11 +34,6 @@ export class PostService {
   ) {}
 
   async create(input: CreatePost): Promise<Post> {
-    if (!input.parentId) {
-      throw new ServerException(
-        'A post must be associated with a parent node.',
-      );
-    }
     const perms = await this.getPermissionsFromPostable(input.parentId);
     perms.verifyCan('create');
 

src/components/project/project-member/project-member.service.ts

@@ -3,7 +3,6 @@ import { type MaybeAsync, setOf } from '@seedcompany/common';
 import {
   type ID,
   InputException,
-  NotFoundException,
   type ObjectView,
   Role,
   ServerException,
@@ -60,13 +59,6 @@ export class ProjectMemberService {
 
   @HandleIdLookup(ProjectMember)
   async readOne(id: ID, _view?: ObjectView): Promise<ProjectMember> {
-    if (!id) {
-      throw new NotFoundException(
-        'No project member id to search for',
-        'projectMember.id',
-      );
-    }
-
     const dto = await this.repo.readOne(id);
     return this.secure(dto);
   }