Fix mutable arrays in DTOs (#3103)

Author: CarsonF

src/common/resource.dto.ts

@@ -55,7 +55,7 @@ export abstract class Resource extends DataObject {
 
   // A list of non-global roles the requesting user has available for this object.
   // This is used by the authorization module to determine permissions.
-  readonly scope?: ScopedRole[];
+  readonly scope?: readonly ScopedRole[];
 }
 
 type Thunk<T> = T | (() => T);

src/components/engagement/dto/create-engagement.dto.ts

@@ -89,7 +89,7 @@ export abstract class CreateInternshipEngagement extends CreateEngagement {
   readonly position?: InternshipPosition;
 
   @Field(() => [ProductMethodology], { nullable: true })
-  readonly methodologies?: ProductMethodology[];
+  readonly methodologies?: readonly ProductMethodology[];
 
   @Field({ nullable: true })
   @Type(() => CreateDefinedFileVersionInput)

src/components/engagement/dto/update-engagement.dto.ts

@@ -90,7 +90,7 @@ export abstract class UpdateInternshipEngagement extends UpdateEngagement {
   readonly position?: InternshipPosition;
 
   @Field(() => [ProductMethodology], { nullable: true })
-  readonly methodologies?: ProductMethodology[];
+  readonly methodologies?: readonly ProductMethodology[];
 
   @Field({ nullable: true })
   @Type(() => CreateDefinedFileVersionInput)

src/components/partner/dto/update-partner.dto.ts

@@ -28,11 +28,11 @@ export abstract class UpdatePartner {
 
   @Field(() => [PartnerType], { nullable: true })
   @Transform(({ value }) => uniq(value))
-  readonly types?: PartnerType[];
+  readonly types?: readonly PartnerType[];
 
   @Field(() => [FinancialReportingType], { nullable: true })
   @Transform(({ value }) => uniq(value))
-  readonly financialReportingTypes?: FinancialReportingType[];
+  readonly financialReportingTypes?: readonly FinancialReportingType[];
 
   @Field({ nullable: true })
   @Matches(/^[A-Z]{3}$/, {

src/components/partnership/dto/update-partnership.dto.ts

@@ -39,7 +39,7 @@ export abstract class UpdatePartnership {
 
   @Field(() => [PartnerType], { nullable: true })
   @Transform(({ value }) => uniq(value))
-  readonly types?: PartnerType[];
+  readonly types?: readonly PartnerType[];
 
   @Field(() => FinancialReportingType, { nullable: true })
   readonly financialReportingType?: FinancialReportingType | null;

src/components/project/dto/create-project.dto.ts

@@ -40,7 +40,7 @@ export abstract class CreateProject {
     nullable: true,
   })
   @IsId({ each: true })
-  readonly otherLocationIds?: ID[];
+  readonly otherLocationIds?: ReadonlyArray<ID<'Location'>>;
 
   @IdField({
     description: 'A marketing primary location ID',

src/components/project/dto/update-project.dto.ts

@@ -74,7 +74,7 @@ export abstract class UpdateProject {
 
   @Field(() => [String], { nullable: true })
   @Transform(({ value }) => uniq(value))
-  readonly tags?: string[];
+  readonly tags?: readonly string[];
 
   @DateTimeField({ nullable: true })
   readonly financialReportReceivedAt?: DateTime;

src/components/project/project-member/dto/create-project-member.dto.ts

@@ -19,7 +19,7 @@ export class CreateProjectMember {
   readonly projectId: ID | UnsecuredDto<Project>;
 
   @Field(() => [Role], { nullable: true })
-  readonly roles?: Role[];
+  readonly roles?: readonly Role[];
 }
 
 @InputType()

src/components/project/project-member/dto/update-project-member.dto.ts

@@ -11,7 +11,7 @@ export abstract class UpdateProjectMember {
   readonly id: ID;
 
   @Field(() => [Role], { nullable: true })
-  readonly roles?: Role[];
+  readonly roles?: readonly Role[];
 }
 
 @InputType()

src/components/project/project-member/project-member.service.ts

@@ -192,7 +192,7 @@ export class ProjectMemberService {
   }
 
   private async assertValidRoles(
-    roles: Role[] | undefined,
+    roles: readonly Role[] | undefined,
     forUser: () => MaybeAsync<User>,
   ) {
     if (!roles || roles.length === 0) {