Correct FieldRegion's zone change to only migrate zone directors for that region (#3502)

Author: CarsonF

src/components/project/project-member/handlers/regions-zone-changes-applies-director-change-to-project-members.handler.ts

@@ -33,6 +33,7 @@ export class RegionsZoneChangesAppliesDirectorChangeToProjectMembersHandler {
       oldDirector.id,
       newDirector.id,
       'FieldOperationsDirector',
+      event.updated.id,
     );
 
     this.logger.notice(

src/components/project/project-member/project-member.gel.repository.ts

@@ -77,22 +77,26 @@ export class ProjectMemberGelRepository
     oldDirector: ID<'User'>,
     newDirector: ID<'User'>,
     role: Role,
+    region?: ID<'FieldRegion'>,
   ) {
     return await this.db.run(this.replaceMembershipsOnOpenProjectsQuery, {
       oldDirector,
       newDirector,
       role,
+      region,
     });
   }
   private readonly replaceMembershipsOnOpenProjectsQuery = e.params(
     {
       oldDirector: e.uuid,
       newDirector: e.uuid,
       role: e.Role,
+      region: e.optional(e.uuid),
     },
     ($) => {
       const oldDirector = e.cast(e.User, $.oldDirector);
       const newDirector = e.cast(e.User, $.newDirector);
+      const region = e.cast(e.FieldRegion, $.region);
 
       const members = e.select(e.Project.members, (member) => ({
         filter: e.all(
@@ -101,6 +105,14 @@ export class ProjectMemberGelRepository
             e.op(member.active, '=', true),
             e.op($.role, 'in', member.roles),
             e.op(member.project.status, 'in', e.set('Active', 'InDevelopment')),
+            e.op(
+              'if',
+              e.op('exists', region),
+              'then',
+              e.op(member.project.fieldRegion, '=', region),
+              'else',
+              true,
+            ),
           ),
         ),
       }));

src/components/project/project-member/project-member.repository.ts

@@ -205,6 +205,8 @@ export class ProjectMemberRepository extends DtoRepository(ProjectMember) {
     oldDirector: ID<'User'>,
     newDirector: ID<'User'>,
     role: Role,
+    // This could be replaced with Filters once those are abstracted for Gel.
+    region?: ID<'FieldRegion'>,
   ) {
     const nowVal = DateTime.now();
     const now = variable('$now');
@@ -232,7 +234,10 @@ export class ProjectMemberRepository extends DtoRepository(ProjectMember) {
           user: { id: oldDirector },
           active: true,
           roles: [role],
-          project: { status: ['Active', 'InDevelopment'] },
+          project: {
+            status: ['Active', 'InDevelopment'],
+            ...(region ? { fieldRegion: { id: region } } : {}),
+          },
         }),
       )
       .apply(