Add labels to conflicting partnership date range errors (#3405)

Author: CarsonF

src/common/exceptions/date-override-conflict.exception.ts

@@ -70,5 +70,5 @@ export class DateOverrideConflictException extends RangeException {
   }
 }
 
-const asNonEmpty = <T>(items: readonly T[]) =>
+export const asNonEmpty = <T>(items: readonly T[]) =>
   items.length === 0 ? undefined : (items as NonEmptyArray<T>);

src/components/partnership/handlers/validate-partnership-date-overrides-on-project-change.handler.ts

@@ -1,13 +1,18 @@
-import { DateOverrideConflictException } from '~/common';
-import { EventsHandler, IEventHandler } from '~/core';
+import { mapEntries } from '@seedcompany/common';
+import { asNonEmpty, DateOverrideConflictException } from '~/common';
+import { EventsHandler, IEventHandler, ResourceLoader } from '~/core';
+import { OrganizationLoader } from '../../organization';
 import { ProjectUpdatedEvent } from '../../project/events';
 import { PartnershipService } from '../partnership.service';
 
 @EventsHandler(ProjectUpdatedEvent)
 export class ValidatePartnershipDateOverridesOnProjectChangeHandler
   implements IEventHandler<ProjectUpdatedEvent>
 {
-  constructor(private readonly partnerships: PartnershipService) {}
+  constructor(
+    private readonly partnerships: PartnershipService,
+    private readonly resources: ResourceLoader,
+  ) {}
 
   async handle(event: ProjectUpdatedEvent) {
     const { updated: project, changes, session } = event;
@@ -26,12 +31,31 @@ export class ValidatePartnershipDateOverridesOnProjectChangeHandler
       partnerships.map((partnership) => ({
         __typename: 'Partnership',
         id: partnership.id,
-        label: partnership.id, // TODO
+        label: partnership.id,
         start: partnership.mouStartOverride,
         end: partnership.mouEndOverride,
       })),
     );
     if (!conflicts) return;
+    const orgLoader = await this.resources.getLoader(OrganizationLoader);
+    const partnershipToOrg = mapEntries(partnerships, (p) => [
+      p.id,
+      p.organization.id,
+    ]).asRecord;
+    const orgs = await orgLoader.loadMany(
+      conflicts.map((conflict) => partnershipToOrg[conflict.id]),
+    );
+    const conflictsWithLabels = conflicts.map((conflict, index) => {
+      const org = orgs[index];
+      if (org instanceof Error) {
+        // Shouldn't happen
+        return conflict;
+      }
+      return {
+        ...conflict,
+        label: org.name.value ?? conflict.id,
+      };
+    });
     throw new DateOverrideConflictException(
       {
         __typename: event.resource.name,
@@ -40,7 +64,7 @@ export class ValidatePartnershipDateOverridesOnProjectChangeHandler
       },
       canonical,
       ['A partnership', 'Some partnerships'],
-      conflicts,
+      asNonEmpty(conflictsWithLabels)!,
     );
   }
 }