Correct update fields to have null type where nulls are actually allowed/expected

Author: CarsonF

src/components/ceremony/dto/update-ceremony.dto.ts

@@ -13,10 +13,10 @@ export abstract class UpdateCeremony {
   readonly planned?: boolean;
 
   @DateField({ nullable: true })
-  readonly estimatedDate?: CalendarDate;
+  readonly estimatedDate?: CalendarDate | null;
 
   @DateField({ nullable: true })
-  readonly actualDate?: CalendarDate;
+  readonly actualDate?: CalendarDate | null;
 }
 
 @InputType()

src/components/engagement/dto/update-engagement.dto.ts

@@ -58,8 +58,8 @@ export abstract class UpdateLanguageEngagement extends UpdateEngagement {
   @Field({ nullable: true })
   readonly openToInvestorVisit?: boolean;
 
-  @Field({ nullable: true })
-  readonly paratextRegistryId?: string;
+  @Field(() => String, { nullable: true })
+  readonly paratextRegistryId?: string | null;
 
   @Field({ nullable: true })
   @Type(() => CreateDefinedFileVersionInput)
@@ -76,8 +76,8 @@ export abstract class UpdateLanguageEngagement extends UpdateEngagement {
   })
   readonly methodology?: ProductMethodology;
 
-  @Field({ nullable: true })
-  readonly historicGoal?: string;
+  @Field(() => String, { nullable: true })
+  readonly historicGoal?: string | null;
 
   @Field(() => LanguageMilestone, { nullable: true })
   readonly milestoneReached?: LanguageMilestone;

src/components/location/dto/update-location.dto.ts

@@ -1,7 +1,7 @@
 import { Field, InputType, ObjectType } from '@nestjs/graphql';
 import { Type } from 'class-transformer';
 import { ValidateNested } from 'class-validator';
-import { ID, IdField, IdOf, ISO31661Alpha3, NameField } from '~/common';
+import { ID, IdField, ISO31661Alpha3, NameField } from '~/common';
 import { Transform } from '~/common/transform.decorator';
 import { CreateDefinedFileVersionInput } from '../../file/dto';
 import { LocationType } from './location-type.enum';
@@ -33,7 +33,7 @@ export abstract class UpdateLocation {
   readonly defaultFieldRegionId?: ID | null;
 
   @IdField({ nullable: true })
-  readonly defaultMarketingRegionId?: IdOf<Location>;
+  readonly defaultMarketingRegionId?: ID<Location> | null;
 
   @Field({ nullable: true })
   @Type(() => CreateDefinedFileVersionInput)

src/components/organization/dto/update-organization.dto.ts

@@ -17,8 +17,8 @@ export abstract class UpdateOrganization {
   @NameField({ nullable: true })
   readonly acronym?: string | null;
 
-  @Field({ nullable: true })
-  readonly address?: string;
+  @Field(() => String, { nullable: true })
+  readonly address?: string | null;
 
   @Field(() => [OrganizationType], { nullable: true })
   readonly types?: readonly OrganizationType[];

src/components/partner/dto/update-partner.dto.ts

@@ -22,7 +22,7 @@ export abstract class UpdatePartner {
   readonly id: ID;
 
   @IdField({ nullable: true })
-  readonly pointOfContactId?: ID | null;
+  readonly pointOfContactId?: ID<'User'> | null;
 
   @Field(() => [PartnerType], { nullable: true })
   @Transform(({ value }) => uniq(value))
@@ -32,11 +32,11 @@ export abstract class UpdatePartner {
   @Transform(({ value }) => uniq(value))
   readonly financialReportingTypes?: readonly FinancialReportingType[];
 
-  @Field({ nullable: true })
+  @Field(() => String, { nullable: true })
   @Matches(/^[A-Z]{3}$/, {
     message: 'Must be 3 uppercase letters',
   })
-  readonly pmcEntityCode?: string;
+  readonly pmcEntityCode?: string | null;
 
   @Field({ nullable: true })
   readonly globalInnovationsClient?: boolean;
@@ -45,7 +45,7 @@ export abstract class UpdatePartner {
   readonly active?: boolean;
 
   @NameField({ nullable: true })
-  readonly address?: string;
+  readonly address?: string | null;
 
   @IdField({ nullable: true })
   readonly languageOfWiderCommunicationId?: ID<'Language'> | null;

src/components/partnership/dto/update-partnership.dto.ts

@@ -32,10 +32,10 @@ export abstract class UpdatePartnership {
   readonly mouStatus?: PartnershipAgreementStatus;
 
   @DateField({ nullable: true })
-  readonly mouStartOverride?: CalendarDate;
+  readonly mouStartOverride?: CalendarDate | null;
 
   @DateField({ nullable: true })
-  readonly mouEndOverride?: CalendarDate;
+  readonly mouEndOverride?: CalendarDate | null;
 
   @Field(() => [PartnerType], { nullable: true })
   @Transform(({ value }) => uniq(value))

src/components/periodic-report/dto/update-periodic-report.dto.ts

@@ -18,11 +18,11 @@ export abstract class UpdatePeriodicReportInput {
   readonly reportFile?: CreateDefinedFileVersionInput;
 
   @DateField({ nullable: true })
-  readonly receivedDate?: CalendarDate;
+  readonly receivedDate?: CalendarDate | null;
 
-  @Field({
+  @Field(() => String, {
     description: 'Why this report is skipped',
     nullable: true,
   })
-  readonly skippedReason?: string;
+  readonly skippedReason?: string | null;
 }