Alias public neo4j hydrate method as different name

This strategy will allow the edgedb version
to be fully type safe with the neo4j version.

Using a stubbed method is better because we know it won't be called,
and this makes the types happy and easier.

Author: CarsonF

src/components/project/project-member/project-member.repository.ts

@@ -117,7 +117,9 @@ export class ProjectMemberRepository extends DtoRepository<
           node('user', 'User'),
         ])
         .subQuery('user', (sub) =>
-          sub.with('user as node').apply(this.users.hydrate(session.userId)),
+          sub
+            .with('user as node')
+            .apply(this.users.hydrateAsNeo4j(session.userId)),
         )
         .return<{ dto: UnsecuredDto<ProjectMember> }>(
           merge('props', { user: 'dto' }).as('dto'),

src/components/user/user.edgedb.repository.ts

@@ -12,14 +12,7 @@ import type { UserRepository } from './user.repository';
 @Injectable()
 export class UserEdgeDBRepository
   extends RepoFor(User).withDefaults()
-  implements
-    Omit<
-      PublicOf<UserRepository>,
-      // hydrate is public (not default) and specific to Neo4j,
-      // but it will only be called by other neo4j repositories,
-      // so it doesn't have to match here
-      'hydrate'
-    >
+  implements PublicOf<UserRepository>
 {
   async doesEmailAddressExist(email: string) {
     const query = e.select(e.User, () => ({
@@ -43,4 +36,8 @@ export class UserEdgeDBRepository
   removeOrganizationFromUser(args: RemoveOrganizationFromUser): Promise<void> {
     throw new NotImplementedException().with(args);
   }
+
+  hydrateAsNeo4j(_session: unknown): any {
+    throw new NotImplementedException();
+  }
 }

src/components/user/user.module.ts

@@ -36,7 +36,7 @@ import { UserService } from './user.service';
     AssignableRolesResolver,
     UserLoader,
     UserService,
-    splitDb(UserRepository, UserEdgeDBRepository as any),
+    splitDb(UserRepository, UserEdgeDBRepository),
     KnownLanguageRepository,
   ],
   exports: [UserService, UserRepository, EducationModule, UnavailabilityModule],

src/components/user/user.repository.ts

@@ -104,7 +104,7 @@ export class UserRepository extends DtoRepository<typeof User, [Session | ID]>(
     return undefined;
   }
 
-  hydrate(requestingUserId: Session | ID) {
+  protected hydrate(requestingUserId: Session | ID) {
     return (query: Query) =>
       query
         .subQuery('node', (sub) =>
@@ -347,4 +347,8 @@ export class UserRepository extends DtoRepository<typeof User, [Session | ID]>(
       await removePrimary.first();
     }
   }
+
+  hydrateAsNeo4j(session: Session | ID) {
+    return this.hydrate(session);
+  }
 }