Merge pull request #3414 from SeedCompany/vertbatim

Author: CarsonF

.eslintrc.cjs

@@ -88,6 +88,11 @@ const restrictedImports = [
     path: '@nestjs/platform-fastify',
     replacement: { path: '~/core/http' },
   },
+  {
+    path: 'type-fest',
+    kind: 'value',
+    message: 'Be sure to specify the `type` modifier',
+  },
 ];
 
 const namingConvention = [
@@ -161,24 +166,20 @@ const namingConvention = [
 /** @type {import('@typescript-eslint/utils').TSESLint.Linter.Config} */
 const config = {
   root: true,
-  plugins: [
-    '@seedcompany',
-    'typescript-sort-keys',
-    'no-only-tests',
-  ],
+  plugins: ['@seedcompany', 'typescript-sort-keys', 'no-only-tests'],
   extends: ['plugin:@seedcompany/nestjs'],
   rules: {
     'no-console': 'error',
     'no-only-tests/no-only-tests': 'error',
     '@typescript-eslint/naming-convention': ['warn', ...namingConvention],
-    'no-restricted-imports': ['error', { 'paths': oldRestrictedImports }],
+    'no-restricted-imports': ['error', { paths: oldRestrictedImports }],
     '@seedcompany/no-restricted-imports': ['error', ...restrictedImports],
     'no-restricted-syntax': [
       'error',
       ...baseConfig.rules['no-restricted-syntax']?.slice(1),
       {
         selector: 'NewExpression[callee.name="Logger"]',
-        'message': `
+        message: `
         Inject a logger instead
 
         constructor(
@@ -187,6 +188,14 @@ const config = {
         `,
       },
     ],
+    '@typescript-eslint/consistent-type-imports': [
+      'error',
+      { fixStyle: 'inline-type-imports' },
+    ],
+    '@typescript-eslint/consistent-type-exports': [
+      'error',
+      { fixMixedExportsWithInlineTypeSpecifier: true },
+    ],
     // TODO Enable this and fix errors (both types & logic changes will be needed)
     '@typescript-eslint/no-unnecessary-condition': 'off',
   },

.git-blame-ignore-revs

@@ -22,3 +22,6 @@ bfed26416fb0bd22aa9437145b081ea4216b9816
 
 # EdgeDB -> Gel
 e7bc70f5598d83b7a49306f1726d3bcb45cc9956
+
+# Verbatim module syntax enabled / strict type modifiers
+2ac61585bc2a9fb187ddcf50eb3b3c178581d5b7

src/common/and-call.ts

@@ -1,6 +1,6 @@
-import { FnLike } from '@seedcompany/common';
+import { type FnLike } from '@seedcompany/common';
 import { isPromise } from 'node:util/types';
-import { ConditionalKeys } from 'type-fest';
+import { type ConditionalKeys } from 'type-fest';
 
 export const andCall = <
   T,

src/common/augmented-metadata.pipe.ts

@@ -1,4 +1,4 @@
-import { ArgumentMetadata, PipeTransform } from '@nestjs/common';
+import { type ArgumentMetadata, type PipeTransform } from '@nestjs/common';
 import { ServerException } from './exceptions';
 
 const key = Symbol('AugmentedMetadata');

src/common/context.type.ts

@@ -1,7 +1,7 @@
-import { OperationDefinitionNode } from 'graphql';
-import { BehaviorSubject } from 'rxjs';
+import { type OperationDefinitionNode } from 'graphql';
+import { type BehaviorSubject } from 'rxjs';
 import type { IRequest, IResponse } from '~/core/http';
-import { Session } from './session';
+import { type Session } from './session';
 
 /**
  * The type for graphql @Context() decorator

src/common/create-and-inject.ts

@@ -1,6 +1,6 @@
-import { ModuleRef } from '@nestjs/core';
+import { type ModuleRef } from '@nestjs/core';
 import { pickBy } from 'lodash';
-import { Class } from 'type-fest';
+import { type Class } from 'type-fest';
 
 /**
  * A helper to create an instance of a class and inject dependencies.

src/common/data-object.ts

@@ -1,4 +1,4 @@
-import { AbstractClassType } from './types';
+import { type AbstractClassType } from './types';
 
 /**
  * A helper class to try to enforce proper usage of data objects.

src/common/db-label.helpers.ts

@@ -1,5 +1,5 @@
 import { uniq } from 'lodash';
-import { AbstractClass } from 'type-fest';
+import type { AbstractClass } from 'type-fest';
 import { DbLabelSymbol } from './db-label.decorator';
 import { getParentTypes } from './parent-types';
 import { isResourceClass } from './resource.dto';

src/common/discovery-unique-methods.ts

@@ -1,4 +1,4 @@
-import { DiscoveredMethodWithMeta } from '@golevelup/nestjs-discovery';
+import { type DiscoveredMethodWithMeta } from '@golevelup/nestjs-discovery';
 
 export const uniqueDiscoveredMethods = <T>(
   methods: Array<DiscoveredMethodWithMeta<T>>,

src/common/email-field.ts

@@ -1,5 +1,5 @@
 import { applyDecorators } from '@nestjs/common';
-import { Field, FieldOptions } from '@nestjs/graphql';
+import { Field, type FieldOptions } from '@nestjs/graphql';
 import { Transform } from './transform.decorator';
 import { IsEmail } from './validators';