Massively Refactor Authentication internals (#3440)

Author: CarsonF

src/app.module.ts

@@ -1,7 +1,6 @@
 import { Module } from '@nestjs/common';
 import process from 'node:process';
 import { AdminModule } from './components/admin/admin.module';
-import { AuthenticationModule } from './components/authentication/authentication.module';
 import { AuthorizationModule } from './components/authorization/authorization.module';
 import { BudgetModule } from './components/budget/budget.module';
 import { CeremonyModule } from './components/ceremony/ceremony.module';
@@ -52,7 +51,6 @@ if (process.env.NODE_ENV !== 'production') {
     LoggerModule.forRoot(),
     CoreModule,
     AdminModule,
-    AuthenticationModule,
     AuthorizationModule,
     BudgetModule,
     CeremonyModule,

src/common/index.ts

@@ -49,7 +49,6 @@ export * from './secured-mapper';
 export * from './sensitivity.enum';
 export * from './trace-layer';
 export * from './util';
-export { type Session } from './session';
 export * from './types';
 export * from './validators';
 export * from './name-field';

src/common/session.ts

@@ -1,8 +1,10 @@
 import { Injectable } from '@nestjs/common';
+import { ModuleRef } from '@nestjs/core';
+import { LazyGetter as Once } from 'lazy-get-decorator';
 import { type ID, Role } from '~/common';
+import { AuthenticationRepository } from '~/core/authentication/authentication.repository';
 import { RootUserAlias } from '~/core/config/root-user.config';
 import { DbTraceLayer, disableAccessPolicies, e, Gel } from '~/core/gel';
-import { AuthenticationRepository } from '../authentication/authentication.repository';
 import { SystemAgentRepository } from '../user/system-agent.repository';
 
 @Injectable()
@@ -11,12 +13,16 @@ export class AdminGelRepository {
   private readonly db: Gel;
   constructor(
     gel: Gel,
-    readonly auth: AuthenticationRepository,
+    private readonly moduleRef: ModuleRef,
     readonly agents: SystemAgentRepository,
   ) {
     this.db = gel.withOptions(disableAccessPolicies);
   }
 
+  @Once() get auth() {
+    return this.moduleRef.get(AuthenticationRepository, { strict: false });
+  }
+
   async finishing(callback: () => Promise<void>) {
     await this.db.waitForConnection({
       forever: true,

src/components/admin/admin.gel.repository.ts

@@ -3,9 +3,9 @@ import {
   Injectable,
   type OnApplicationBootstrap,
 } from '@nestjs/common';
+import { CryptoService } from '~/core/authentication/crypto.service';
 import { ConfigService } from '~/core/config/config.service';
 import { ILogger, Logger } from '~/core/logger';
-import { CryptoService } from '../authentication/crypto.service';
 import { AdminGelRepository } from './admin.gel.repository';
 import { AdminRepository } from './admin.repository';
 

src/components/admin/admin.gel.service.ts

@@ -1,24 +1,33 @@
 import { Injectable, type OnApplicationBootstrap } from '@nestjs/common';
+import { ModuleRef } from '@nestjs/core';
+import { LazyGetter as Once } from 'lazy-get-decorator';
 import { DateTime } from 'luxon';
 import { Role, ServerException } from '~/common';
+import { AuthenticationService } from '~/core/authentication/authentication.service';
+import { CryptoService } from '~/core/authentication/crypto.service';
 import { ConfigService } from '~/core/config/config.service';
 import { Transactional } from '~/core/database';
 import { ILogger, Logger } from '~/core/logger';
-import { AuthenticationService } from '../authentication';
-import { CryptoService } from '../authentication/crypto.service';
 import { AdminRepository } from './admin.repository';
 
 @Injectable()
 export class AdminService implements OnApplicationBootstrap {
   constructor(
     private readonly config: ConfigService,
-    private readonly authentication: AuthenticationService,
-    private readonly crypto: CryptoService,
     private readonly repo: AdminRepository,
+    private readonly moduleRef: ModuleRef,
     @Logger('admin:service') private readonly logger: ILogger,
     @Logger('admin:database') private readonly dbLogger: ILogger,
   ) {}
 
+  @Once() private get authentication() {
+    return this.moduleRef.get(AuthenticationService, { strict: false });
+  }
+
+  @Once() private get crypto() {
+    return this.moduleRef.get(CryptoService, { strict: false });
+  }
+
   async onApplicationBootstrap(): Promise<void> {
     if (!this.config.dbRootObjectsSync) {
       return;