Hydrate labels for engagements

Author: CarsonF

dbschema/common.gel

@@ -18,7 +18,12 @@ module default {
        )
     )
   );
-  
+
+  function array_join_maybe(array: array<str>, delimiter: str) -> optional str using (
+    with joined := array_join(array, delimiter)
+    select if joined = "" then <str>{} else joined
+  );
+
   scalar type nanoid extending str;
 
   scalar type RichText extending json;

dbschema/migrations/00018-m1jf7p4.edgeql

@@ -81,6 +81,12 @@ class Engagement extends Interfaces {
   @Field(() => IProject)
   declare readonly parent: BaseNode;
 
+  readonly label: Readonly<{
+    project: string;
+    language: string | null;
+    intern: string | null;
+  }>;
+
   @Field(() => SecuredEngagementStatus, {
     middleware: [parentIdMiddleware],
   })

src/components/engagement/dto/engagement.dto.ts

@@ -63,19 +63,51 @@ const languageHydrate = e.shape(e.LanguageEngagement, (le) => ({
   ...baseHydrate(le),
   __typename: le.__type__.name,
   ...languageExtraHydrate,
+  label: e.select({
+    project: le.project.name,
+    language: le.language.name,
+    intern: e.cast(e.str, e.set()),
+  }),
 }));
 
 const internshipHydrate = e.shape(e.InternshipEngagement, (ie) => ({
   ...baseHydrate(ie),
   __typename: ie.__type__.name,
   ...internshipExtraHydrate,
+  label: e.select({
+    project: ie.project.name,
+    language: e.cast(e.str, e.set()),
+    intern: e.array_join_maybe(
+      e.array([ie.intern.displayFirstName, ie.intern.displayLastName]),
+      ' ',
+    ),
+  }),
 }));
 
-const hydrate = e.shape(e.Engagement, (engagement) => ({
-  ...baseHydrate(engagement),
-  ...e.is(e.LanguageEngagement, languageExtraHydrate),
-  ...e.is(e.InternshipEngagement, internshipExtraHydrate),
-}));
+const hydrate = e.shape(e.Engagement, (engagement) => {
+  const langEng = e.select(e.LanguageEngagement, () => ({
+    filter_single: { id: engagement.id },
+  }));
+  const internEng = e.select(e.InternshipEngagement, () => ({
+    filter_single: { id: engagement.id },
+  }));
+  return {
+    ...baseHydrate(engagement),
+    ...e.is(e.LanguageEngagement, languageExtraHydrate),
+    ...e.is(e.InternshipEngagement, internshipExtraHydrate),
+    label: e.select({
+      project: engagement.project.name,
+      language: langEng.language.name,
+      intern: e.array_join_maybe(
+        e.array([
+          internEng.intern.displayFirstName,
+          internEng.intern.displayLastName,
+        ]),
+        ' ',
+      ),
+    }),
+  };
+});
 
 export const ConcreteRepos = {
   LanguageEngagement: class LanguageEngagementRepository extends RepoFor(

src/components/engagement/engagement.gel.repository.ts

@@ -49,6 +49,7 @@ import {
   requestingUser,
   SortCol,
   sortWith,
+  textJoinMaybe,
   whereNotDeletedInChangeset,
 } from '~/core/database/query';
 import { Privileges } from '../authorization';
@@ -168,6 +169,7 @@ export class EngagementRepository extends CommonRepository {
           relation('out', '', 'mouEnd', ACTIVE),
           node('mouEnd'),
         ])
+        .apply(matchNames)
         .match([
           [
             node('project'),
@@ -193,6 +195,11 @@ export class EngagementRepository extends CommonRepository {
               step: 'step.value',
             },
             language: 'language { .id }',
+            label: {
+              project: 'projectName.value',
+              language: 'languageName.value',
+              intern: textJoinMaybe(['dfn.value', 'dln.value']),
+            },
             pnp: { id: 'props.pnp' },
             growthPlan: { id: 'props.growthPlan' },
             ceremony: 'ceremony { .id }',

src/components/engagement/engagement.repository.ts

@@ -34,6 +34,7 @@ export class ValidateEngDateOverridesOnProjectChangeHandlerSetLastStatusDate
       >((eng) => {
         const common = {
           id: eng.id,
+          label: (eng.label.language ?? eng.label.intern)!,
         } as const;
         const { startDateOverride: start, endDateOverride: end } = eng;
         return [
@@ -73,6 +74,7 @@ class EngagementDateOverrideConflictException extends RangeException {
     readonly engagements: NonEmptyArray<
       Readonly<{
         id: ID<'Engagement'>;
+        label: string;
         point: 'start' | 'end';
         date: CalendarDate;
       }>
@@ -85,7 +87,7 @@ class EngagementDateOverrideConflictException extends RangeException {
       ...engagements.map((eng) => {
         const pointStr = eng.point === 'start' ? 'Start' : 'End';
         const dateStr = eng.date.toISO();
-        return `  - ${pointStr} date of ${eng.id} is ${dateStr}`;
+        return `  - ${pointStr} date of ${eng.label} is ${dateStr}`;
       }),
     ].join('\n');
     super({ message });

src/components/engagement/handlers/validate-eng-date-overrides-on-project-change.handler.ts

@@ -89,6 +89,26 @@ export const apoc = {
     setLabels: (node: ExpressionInput, labels: readonly string[]) =>
       procedure('apoc.create.setLabels', ['node'])({ node: exp(node), labels }),
   },
+  text: {
+    /**
+     * @see https://neo4j.com/docs/apoc/current/overview/apoc.text/apoc.text.join/
+     */
+    join: (list: ExpressionInput, delimiter: string) =>
+      fn('apoc.text.join')(list, delimiter),
+  },
+};
+
+export const cleanTextList = (list: ExpressionInput) =>
+  exp(`[x IN ${exp(list)} WHERE x IS NOT NULL AND trim(x) <> '' | trim(x)]`);
+
+export const textJoinMaybe = (items: ExpressionInput, delimiter = ' ') => {
+  const cleaned = cleanTextList(items);
+  return exp(
+    `CASE WHEN size(${cleaned}) = 0 THEN null ELSE ${apoc.text.join(
+      `${cleaned}`,
+      `"${delimiter}"`,
+    )} END`,
+  );
 };
 
 /**