Fix permissions

In general, just tried to follow suit of project workflow

Author: CarsonF

dbschema/migrations/00012-m1pqxkv.edgeql renamed to dbschema/migrations/00012-m1vbhai.edgeql

@@ -37,6 +37,7 @@ import * as FA from './financial-analyst.policy';
     ).edit,
   ]),
   r.ProjectWorkflowEvent.transitions(FA.projectTransitions).execute,
+  r.EngagementWorkflowEvent.transitions(FA.engagementTransitions).execute,
   r.ProjectMember.edit.create.delete,
 ])
 export class FinancialAnalystLeadPolicy {}

src/components/authorization/policies/by-role/financial-analyst-lead.policy.ts

@@ -1,3 +1,4 @@
+import { EngagementWorkflow } from '../../../engagement/workflow/engagement-workflow';
 import { ProjectWorkflow } from '../../../project/workflow/project-workflow';
 import {
   inherit,
@@ -16,6 +17,9 @@ export const projectTransitions = () =>
     'Complete',
   );
 
+export const engagementTransitions = () =>
+  EngagementWorkflow.pickNames('Not Ready for Completion', 'Complete');
+
 // NOTE: There could be other permissions for this role from other policies
 @Policy(
   [Role.FinancialAnalyst, Role.LeadFinancialAnalyst, Role.Controller],
@@ -31,9 +35,9 @@ export const projectTransitions = () =>
       ]),
       r.LanguageEngagement.specifically((p) => p.paratextRegistryId.none),
     ),
-    r.EngagementWorkflowEvent.read.transitions(
-      'Not Ready for Completion',
-      'Complete',
+    r.EngagementWorkflowEvent.read.whenAll(
+      member,
+      r.EngagementWorkflowEvent.isTransitions(engagementTransitions),
     ).execute,
     r.FieldRegion.read,
     r.FieldZone.read,

src/components/authorization/policies/by-role/financial-analyst.policy.ts

@@ -1,4 +1,5 @@
 import { takeWhile } from 'lodash';
+import { EngagementWorkflow } from '../../../engagement/workflow/engagement-workflow';
 import { ProjectStep } from '../../../project/dto';
 import { ProjectWorkflow } from '../../../project/workflow/project-workflow';
 import {
@@ -57,6 +58,22 @@ export const momentumProjectsTransitions = () =>
     'Consultant Opposes Proposal',
   );
 
+export const engagementTransitions = () =>
+  EngagementWorkflow.pickNames(
+    'End Proposal',
+    'Discuss Change To Plan',
+    'Discuss Suspension out of Change to Plan Discussion',
+    'End Change To Plan Discussion',
+    'Discuss Suspension',
+    'End Suspension Discussion',
+    'Discuss Reactivation',
+    'Discuss Termination',
+    'End Termination Discussion',
+    'Finalize Completion',
+    'Not Ready for Completion',
+    'Complete',
+  );
+
 // NOTE: There could be other permissions for this role from other policies
 @Policy(
   [Role.ProjectManager, Role.RegionalDirector, Role.FieldOperationsDirector],
@@ -82,22 +99,9 @@ export const momentumProjectsTransitions = () =>
         p.paratextRegistryId.when(member).read,
       ]),
     ),
-    r.EngagementWorkflowEvent.read.transitions(
-      'Discuss Change To Plan',
-      'Discuss Suspension',
-      'Discuss Termination',
-      'Finalize Completion',
-      'Approve Change To Plan',
-      'End Change To Plan Discussion',
-      'Discuss Suspension out of Change to Plan Discussion',
-      'End Suspension Discussion',
-      'Approve Suspension',
-      'Approve Reactivation',
-      'Discuss Reactivation',
-      'End Termination Discussion',
-      'Approve Termination',
-      'Not Ready for Completion',
-      'Complete',
+    r.EngagementWorkflowEvent.read.whenAll(
+      member,
+      r.EngagementWorkflowEvent.isTransitions(engagementTransitions),
     ).execute,
     r.EthnologueLanguage.read,
     r.FieldRegion.read,

src/components/authorization/policies/by-role/project-manager.policy.ts

@@ -34,5 +34,12 @@ import * as PM from './project-manager.policy';
     'Request Changes for Termination',
     'End Termination Discussion By Approver',
   ).execute,
+  r.EngagementWorkflowEvent.transitions(
+    PM.engagementTransitions,
+    'Reject Proposal',
+    'Approve Suspension',
+    'Approve Reactivation',
+    'Approve Termination',
+  ).execute,
 ])
 export class RegionalDirectorPolicy {}

src/components/authorization/policies/by-role/regional-director.policy.ts

@@ -115,6 +115,7 @@ export const EngagementWorkflow = defineWorkflow({
       Status.Active,
       Status.ActiveChangedPlan,
       Status.DiscussingReactivation,
+      Status.DiscussingSuspension,
       Status.Suspended,
     ),
     label: 'Will Not Terminate',