Remove explicit Props/SecuredProps across the codebase

Author: CarsonF

src/common/resource.dto.ts

@@ -10,7 +10,6 @@ import {
 import { createMetadataDecorator } from '@seedcompany/nest';
 import { LazyGetter as Once } from 'lazy-get-decorator';
 import { DateTime } from 'luxon';
-import { keys as keysOf } from 'ts-transformer-keys';
 import type {
   ResourceDBMap,
   ResourceLike,
@@ -53,9 +52,6 @@ export const resolveByTypename =
 })
 @DbLabel('BaseNode')
 export abstract class Resource extends DataObject {
-  static readonly Props: string[] = keysOf<Resource>();
-  static readonly SecuredProps: string[] = [];
-
   readonly __typename?: string;
 
   @IdField()

src/components/authorization/dto/assignable-roles.ts

@@ -17,8 +17,6 @@ import { RegisterResource } from '~/core/resources';
 @RegisterResource()
 @Calculated()
 export class AssignableRoles {
-  static Props = [];
-  static SecuredProps = [];
   static Relations = mapValues.fromList(Role, () => undefined)
     .asRecord satisfies ResourceRelationsShape;
 }

src/components/authorization/dto/beta-features.dto.ts

@@ -1,5 +1,4 @@
 import { Field, ObjectType } from '@nestjs/graphql';
-import { keys as keysOf } from 'ts-transformer-keys';
 import { Calculated, type ResourceRelationsShape } from '~/common';
 import { RegisterResource } from '~/core/resources';
 import { Granter, ResourceGranter } from '../policy';
@@ -10,9 +9,6 @@ import { Granter, ResourceGranter } from '../policy';
 @Calculated()
 @ObjectType()
 export class BetaFeatures {
-  static readonly Props = keysOf<BetaFeatures>();
-  static readonly SecuredProps = [];
-
   // Declaring as relations as well so privileges can use.
   static readonly Relations = {
     projectChangeRequests: undefined,

src/components/budget/dto/budget-record.dto.ts

@@ -1,5 +1,4 @@
 import { Field, ObjectType } from '@nestjs/graphql';
-import { keys as keysOf } from 'ts-transformer-keys';
 import {
   Calculated,
   type ID,
@@ -8,7 +7,6 @@ import {
   type Secured,
   SecuredFloatNullable,
   SecuredInt,
-  type SecuredProps,
   Sensitivity,
   SensitivityField,
 } from '~/common';
@@ -27,8 +25,6 @@ const Interfaces = IntersectTypes(Resource, ChangesetAware);
   implements: Interfaces.members,
 })
 export class BudgetRecord extends Interfaces {
-  static readonly Props = keysOf<BudgetRecord>();
-  static readonly SecuredProps = keysOf<SecuredProps<BudgetRecord>>();
   static readonly Parent = () => import('./budget.dto').then((m) => m.Budget);
 
   @Field(() => Budget)

src/components/budget/dto/budget.dto.ts

@@ -1,13 +1,11 @@
 import { Field, ObjectType } from '@nestjs/graphql';
-import { keys as keysOf } from 'ts-transformer-keys';
 import {
   Calculated,
   DbLabel,
   IntersectTypes,
   Resource,
   type ResourceRelationsShape,
   SecuredProperty,
-  type SecuredProps,
   Sensitivity,
   SensitivityField,
 } from '~/common';
@@ -28,8 +26,6 @@ const Interfaces = IntersectTypes(Resource, ChangesetAware);
   implements: Interfaces.members,
 })
 export class Budget extends Interfaces {
-  static readonly Props = keysOf<Budget>();
-  static readonly SecuredProps = keysOf<SecuredProps<Budget>>();
   static readonly Relations = (() => ({
     records: [BudgetRecord],
   })) satisfies ResourceRelationsShape;

src/components/ceremony/dto/ceremony.dto.ts

@@ -1,12 +1,10 @@
 import { Field, ObjectType } from '@nestjs/graphql';
-import { keys as keysOf } from 'ts-transformer-keys';
 import {
   Calculated,
   Resource,
   SecuredBoolean,
   SecuredDateNullable,
   SecuredProperty,
-  type SecuredProps,
   Sensitivity,
   SensitivityField,
 } from '~/common';
@@ -20,8 +18,6 @@ import { CeremonyType } from './ceremony-type.enum';
   implements: [Resource],
 })
 export class Ceremony extends Resource {
-  static readonly Props = keysOf<Ceremony>();
-  static readonly SecuredProps = keysOf<SecuredProps<Ceremony>>();
   static readonly Parent = () =>
     import('../../engagement/dto').then((m) => m.IEngagement);
 

src/components/changeset/dto/changeset.dto.ts

@@ -1,6 +1,5 @@
 import { Field, InterfaceType } from '@nestjs/graphql';
-import { keys as keysOf } from 'ts-transformer-keys';
-import { Resource, type SecuredProps } from '~/common';
+import { Resource } from '~/common';
 import { RegisterResource } from '~/core/resources';
 
 @RegisterResource()
@@ -9,8 +8,6 @@ import { RegisterResource } from '~/core/resources';
   resolveType: (obj: Changeset) => obj.__typename,
 })
 export class Changeset extends Resource {
-  static readonly Props: string[] = keysOf<Changeset>();
-  static readonly SecuredProps: string[] = keysOf<SecuredProps<Changeset>>();
   declare __typename: string;
 
   @Field({

src/components/comments/dto/comment-thread.dto.ts

@@ -1,10 +1,8 @@
 import { Field, ObjectType } from '@nestjs/graphql';
-import { keys as keysOf } from 'ts-transformer-keys';
 import {
   type ID,
   Resource,
   type ResourceRelationsShape,
-  type SecuredProps,
   type SetUnsecuredType,
   type UnsecuredDto,
 } from '~/common';
@@ -18,9 +16,6 @@ import { Comment } from './comment.dto';
   implements: [Resource],
 })
 export class CommentThread extends Resource {
-  static readonly Props = keysOf<CommentThread>();
-  static readonly SecuredProps: string[] =
-    keysOf<SecuredProps<CommentThread>>();
   static readonly Relations = {
     comments: [Comment],
   } satisfies ResourceRelationsShape;

src/components/comments/dto/comment.dto.ts

@@ -1,13 +1,6 @@
 import { Field, ObjectType } from '@nestjs/graphql';
 import { DateTime } from 'luxon';
-import { keys as keysOf } from 'ts-transformer-keys';
-import {
-  DateTimeField,
-  type ID,
-  Resource,
-  type SecuredProps,
-  SecuredRichText,
-} from '~/common';
+import { DateTimeField, type ID, Resource, SecuredRichText } from '~/common';
 import { e } from '~/core/gel';
 import { RegisterResource } from '~/core/resources';
 
@@ -16,8 +9,6 @@ import { RegisterResource } from '~/core/resources';
   implements: [Resource],
 })
 export class Comment extends Resource {
-  static readonly Props = keysOf<Comment>();
-  static readonly SecuredProps: string[] = keysOf<SecuredProps<Comment>>();
   static readonly Parent = () =>
     import('./comment-thread.dto').then((m) => m.CommentThread);
 

src/components/comments/dto/commentable.dto.ts

@@ -1,10 +1,8 @@
 import { InterfaceType } from '@nestjs/graphql';
-import { keys as keysOf } from 'ts-transformer-keys';
 import {
   resolveByTypename,
   Resource,
   type ResourceRelationsShape,
-  type SecuredProps,
 } from '~/common';
 import { e } from '~/core/gel';
 import { RegisterResource } from '~/core/resources';
@@ -17,8 +15,6 @@ import { CommentThread } from './comment-thread.dto';
   resolveType: resolveByTypename(Commentable.name),
 })
 export abstract class Commentable extends Resource {
-  static readonly Props: string[] = keysOf<Commentable>();
-  static readonly SecuredProps: string[] = keysOf<SecuredProps<Commentable>>();
   static readonly Relations = {
     commentThreads: [CommentThread],
   } satisfies ResourceRelationsShape;