Add project step condition

Author: CarsonF

src/components/engagement/dto/engagement.dto.ts

@@ -69,7 +69,8 @@ class Engagement extends Interfaces {
 
   declare readonly __typename: 'LanguageEngagement' | 'InternshipEngagement';
 
-  readonly project: LinkTo<'Project'> & Pick<IProject, 'status' | 'type'>;
+  readonly project: LinkTo<'Project'> &
+    Pick<UnsecuredDto<IProject>, 'type' | 'step' | 'status'>;
 
   @Field(() => IProject)
   declare readonly parent: BaseNode;

src/components/engagement/engagement.repository.ts

@@ -158,6 +158,11 @@ export class EngagementRepository extends CommonRepository {
           relation('out', '', 'status', ACTIVE),
           node('status'),
         ])
+        .match([
+          node('project'),
+          relation('out', '', 'step', ACTIVE),
+          node('projectStep'),
+        ])
         .return<{ dto: UnsecuredDto<Engagement> }>(
           merge('props', 'changedProps', {
             __typename: typenameForView(
@@ -169,6 +174,7 @@ export class EngagementRepository extends CommonRepository {
               id: 'project.id',
               type: 'project.type',
               status: 'status.value',
+              step: 'step.value',
             },
             language: 'language.id',
             ceremony: 'ceremony.id',

src/components/engagement/workflow/engagement-workflow.neo4j.repository.ts

@@ -1,13 +1,6 @@
 import { Injectable } from '@nestjs/common';
 import { inArray, node, Query, relation } from 'cypher-query-builder';
-import {
-  ID,
-  Order,
-  PublicOf,
-  ServerException,
-  Session,
-  UnsecuredDto,
-} from '~/common';
+import { ID, Order, PublicOf, Session, UnsecuredDto } from '~/common';
 import { DtoRepository } from '~/core/database';
 import {
   ACTIVE,
@@ -18,7 +11,6 @@ import {
   requestingUser,
   sorting,
 } from '~/core/database/query';
-import { ProjectStep } from '../../project/dto';
 import { EngagementStatus, IEngagement } from '../dto';
 import {
   ExecuteEngagementTransitionInput,
@@ -138,58 +130,4 @@ export class EngagementWorkflowNeo4jRepository
       .first();
     return result?.step ?? null;
   }
-
-  async getCurrentProjectStep(engagementId: ID, changeset?: ID) {
-    const result = await this.db
-      .query()
-      .match([
-        node('engagement', 'Engagement', { id: engagementId }),
-        relation('in', '', 'engagement'), // Removed active true due to changeset aware
-        node('project', 'Project'),
-      ])
-      .raw('return project.id as projectId')
-      .asResult<{ projectId: ID }>()
-      .first();
-
-    if (!result?.projectId) {
-      throw new ServerException(`Could not find project`);
-    }
-    const projectId = result.projectId;
-
-    let currentStep;
-    if (changeset) {
-      const result = await this.db
-        .query()
-        .match([
-          node('project', 'Project', { id: projectId }),
-          relation('out', '', 'step', INACTIVE),
-          node('step', 'Property'),
-          relation('in', '', 'changeset', ACTIVE),
-          node('', 'Changeset', { id: changeset }),
-        ])
-        .raw('return step.value as step')
-        .asResult<{ step: ProjectStep }>()
-        .first();
-      currentStep = result?.step;
-    }
-    if (!currentStep) {
-      const result = await this.db
-        .query()
-        .match([
-          node('project', 'Project', { id: projectId }),
-          relation('out', '', 'step', ACTIVE),
-          node('step', 'Property'),
-        ])
-        .raw('return step.value as step')
-        .asResult<{ step: ProjectStep }>()
-        .first();
-      currentStep = result?.step;
-    }
-
-    if (!currentStep) {
-      throw new ServerException(`Could not find project's step`);
-    }
-
-    return currentStep;
-  }
 }

src/components/engagement/workflow/engagement-workflow.repository.ts

@@ -69,11 +69,4 @@ export class EngagementWorkflowRepository extends RepoFor(
     `);
     return await this.db.run(query, { engagementId, steps });
   }
-
-  async getCurrentProjectStep(engagementId: ID) {
-    const engagement = e.cast(e.Engagement, e.uuid(engagementId));
-    const project = e.cast(e.Project, engagement.project.id);
-    const query = e.select(project.step);
-    return await this.db.run(query);
-  }
 }

src/components/engagement/workflow/engagement-workflow.ts

@@ -4,6 +4,7 @@ import { EngagementStatus as Status } from '../dto';
 import { EngagementWorkflowEvent } from './dto';
 import { BackTo, BackToActive } from './transitions/back';
 import { EngagementWorkflowContext } from './transitions/context';
+import { ProjectStep } from './transitions/project-step';
 
 // This also controls the order shown in the UI.
 // Therefore, these should generally flow down.
@@ -20,18 +21,21 @@ export const EngagementWorkflow = defineWorkflow({
     to: Status.Rejected,
     label: 'Reject',
     type: Type.Reject,
+    conditions: ProjectStep('Rejected'),
   },
   'End Development': {
     from: Status.InDevelopment,
     to: Status.DidNotDevelop,
     label: 'End Development',
     type: Type.Reject,
+    conditions: ProjectStep('DidNotDevelop'),
   },
   'Approve to Active': {
     from: Status.InDevelopment,
     to: Status.Active,
     label: 'Approve',
     type: Type.Approve,
+    conditions: ProjectStep('Active'),
   },
   'Discuss Change To Plan': {
     from: [Status.Active, Status.ActiveChangedPlan],

src/components/engagement/workflow/transitions/project-step.ts

@@ -0,0 +1,24 @@
+import { setOf } from '@seedcompany/common';
+import { ProjectStep as Step } from '../../../project/dto';
+import { TransitionCondition } from '../../../workflow/transitions/conditions';
+import { EngagementWorkflowContext } from './context';
+
+type Condition = TransitionCondition<EngagementWorkflowContext>;
+
+export const ProjectStep = (...steps: Step[]): Condition => {
+  const stepSet = setOf(steps);
+  const description =
+    'Project needs to be ' +
+    [...stepSet].map((step) => Step.entry(step).label).join(' / ');
+  return {
+    description,
+    resolve({ engagement }) {
+      return {
+        status: steps.includes(engagement.project.step)
+          ? 'ENABLED'
+          : 'DISABLED',
+        disabledReason: description,
+      };
+    },
+  };
+};