Add migration to backfill missing directors on open projects

Author: CarsonF

src/components/project/project-member/migrations/backfill-missing-directors.migration.ts

@@ -0,0 +1,95 @@
+import { ModuleRef } from '@nestjs/core';
+import { node, type Query, relation } from 'cypher-query-builder';
+import { type Role } from '~/common';
+import { BaseMigration, Migration } from '~/core/database';
+import { ACTIVE, variable } from '~/core/database/query';
+import { projectFilters } from '../../project-filters.query';
+import {
+  projectMemberFilters,
+  ProjectMemberRepository,
+} from '../project-member.repository';
+
+@Migration('2025-06-18T00:00:05')
+export class BackfillMissingDirectorsMigration extends BaseMigration {
+  constructor(private readonly moduleRef: ModuleRef) {
+    super();
+  }
+
+  async up() {
+    const members = this.moduleRef.get(ProjectMemberRepository, {
+      strict: false,
+    });
+    // @ts-expect-error the method is private, but it is fine for this.
+    const upsertMember = members.upsertMember.bind(members);
+
+    const openProjectsMissingRole = (role: Role) => (query: Query) =>
+      query
+        // Open projects
+        .match(node('node', 'Project'))
+        .apply(
+          projectFilters({
+            status: ['Active', 'InDevelopment'],
+          }),
+        )
+        .with('node as project')
+        // Missing role
+        .subQuery('project', (sub) =>
+          sub
+            .match([
+              node('project'),
+              relation('out', '', 'member', ACTIVE),
+              node('node', 'ProjectMember'),
+            ])
+            .apply(
+              projectMemberFilters({
+                active: true,
+                roles: [role],
+              }),
+            )
+            .with('count(node) as members')
+            .raw('WHERE members = 0')
+            .return('true as filtered'),
+        )
+        .with('*');
+
+    await this.db
+      .query()
+      .apply((q) => {
+        q.params.addParam(this.version, 'now');
+      })
+      .apply(openProjectsMissingRole('RegionalDirector'))
+      // Find its region director
+      .match([
+        node('project'),
+        relation('out', '', 'fieldRegion', ACTIVE),
+        node('', 'FieldRegion'),
+        relation('out', '', 'director', ACTIVE),
+        node('director', 'User'),
+      ])
+      .apply(await upsertMember(variable('director'), 'RegionalDirector'))
+      .return('project.id as id')
+      .executeAndLogStats();
+
+    await this.db
+      .query()
+      .apply((q) => {
+        q.params.addParam(this.version, 'now');
+      })
+      .apply(openProjectsMissingRole('FieldOperationsDirector'))
+      // Find its zone director
+      .match([
+        node('project'),
+        relation('out', '', 'fieldRegion', ACTIVE),
+        node('', 'FieldRegion'),
+        relation('out', '', 'zone', ACTIVE),
+        node('', 'FieldZone'),
+        relation('out', '', 'director', ACTIVE),
+        node('director', 'User'),
+      ])
+      .apply(
+        await upsertMember(variable('director'), 'FieldOperationsDirector'),
+      )
+      .return('project.id as id')
+      .executeAndLogStats();
+  }
+}

src/components/project/project-member/project-member.module.ts

@@ -8,6 +8,7 @@ import { DirectorChangeApplyToProjectMembersHandler } from './handlers/director-
 import { ProjectRegionDefaultsDirectorMembershipHandler } from './handlers/project-region-defaults-director-membership.handler';
 import { RegionsZoneChangesAppliesDirectorChangeToProjectMembersHandler } from './handlers/regions-zone-changes-applies-director-change-to-project-members.handler';
 import { AddInactiveAtMigration } from './migrations/add-inactive-at.migration';
+import { BackfillMissingDirectorsMigration } from './migrations/backfill-missing-directors.migration';
 import { ProjectMemberGelRepository } from './project-member.gel.repository';
 import { ProjectMemberLoader } from './project-member.loader';
 import { ProjectMemberRepository } from './project-member.repository';
@@ -30,6 +31,7 @@ import { ProjectMemberService } from './project-member.service';
     DirectorChangeApplyToProjectMembersHandler,
     RegionsZoneChangesAppliesDirectorChangeToProjectMembersHandler,
     ProjectRegionDefaultsDirectorMembershipHandler,
+    BackfillMissingDirectorsMigration,
   ],
   exports: [ProjectMemberService],
 })

src/components/project/project-member/project-member.repository.ts

@@ -34,6 +34,7 @@ import {
   variable,
   Variable,
 } from '~/core/database/query';
+import { varInExp } from '~/core/database/query-augmentation/subquery';
 import { type FilterFn } from '~/core/database/query/filters';
 import { conditionalOn } from '~/core/database/query/properties/update-property';
 import { userFilters, UserRepository } from '../../user/user.repository';
@@ -332,16 +333,21 @@ export class ProjectMemberRepository extends DtoRepository(ProjectMember) {
         modifiedAt: now,
       },
     });
+    const scope = ['project', user instanceof Variable ? varInExp(user) : ''];
+    const userNode =
+      user instanceof Variable
+        ? node(String(user))
+        : node('', 'User', { id: user });
     return (query: Query) =>
-      query.subQuery('project', (sub) =>
+      query.subQuery(scope, (sub) =>
         sub
           .match([
             [
               node('project'),
               relation('out', '', 'member', ACTIVE),
               node('node', 'ProjectMember'),
               relation('out', '', 'user', ACTIVE),
-              node('', 'User', { id: user }),
+              userNode,
             ],
             [
               node('node', 'ProjectMember'),
@@ -356,7 +362,7 @@ export class ProjectMemberRepository extends DtoRepository(ProjectMember) {
               value: variable(apoc.coll.union('roles.value', [`"${role}"`])),
               now,
               permanentAfter: 0,
-              outputStatsVar: 'inactiveStats',
+              outputStatsVar: 'rolesStats',
             }),
           )
           .apply(
@@ -366,7 +372,7 @@ export class ProjectMemberRepository extends DtoRepository(ProjectMember) {
               value: null,
               now,
               permanentAfter: 0,
-              outputStatsVar: 'rolesStats',
+              outputStatsVar: 'inactiveStats',
             }),
           )
           .apply(
@@ -381,16 +387,16 @@ export class ProjectMemberRepository extends DtoRepository(ProjectMember) {
           )
           .return('node as member')
           .union()
-          .with('project')
-          .with('project')
+          .with(scope)
+          .with(scope)
           .where(
             not(
               path([
                 node('project'),
                 relation('out', '', 'member', ACTIVE),
                 node('', 'ProjectMember'),
                 relation('out', '', 'user', ACTIVE),
-                node('', 'User', { id: user }),
+                userNode,
               ]),
             ),
           )