Drop silly logs & ones referencing session

Most of these actions are already logged at the operation level.
Errors do not need to be manually logged anymore either.
Now that we have SessionHost we can work in the current user to implicit log statements.

Author: CarsonF

src/components/budget/budget.service.ts

@@ -11,7 +11,7 @@ import {
   type Session,
   viewOfChangeset,
 } from '~/common';
-import { HandleIdLookup, ILogger, Logger, ResourceResolver } from '~/core';
+import { HandleIdLookup, ResourceResolver } from '~/core';
 import { mapListResults } from '~/core/database/results';
 import { Privileges } from '../authorization';
 import { FileService } from '../file';
@@ -41,15 +41,12 @@ export class BudgetService {
     private readonly budgetRepo: BudgetRepository,
     private readonly budgetRecordsRepo: BudgetRecordRepository,
     private readonly resources: ResourceResolver,
-    @Logger('budget:service') private readonly logger: ILogger,
   ) {}
 
   async create(
     { projectId, ...input }: CreateBudget,
     session: Session,
   ): Promise<Budget> {
-    this.logger.debug('Creating budget', { projectId });
-
     const universalTemplateFileId = await generateId<FileId>();
 
     try {
@@ -58,11 +55,6 @@ export class BudgetService {
         universalTemplateFileId,
       );
 
-      this.logger.debug(`Created Budget`, {
-        id: budgetId,
-        userId: session.userId,
-      });
-
       await this.files.createDefinedFile(
         universalTemplateFileId,
         `Universal Budget Template`,
@@ -75,10 +67,6 @@ export class BudgetService {
 
       return await this.readOne(budgetId, session);
     } catch (exception) {
-      this.logger.error(`Could not create budget`, {
-        userId: session.userId,
-        exception,
-      });
       throw new CreationFailed(Budget, { cause: exception });
     }
   }
@@ -98,16 +86,9 @@ export class BudgetService {
 
     await this.verifyRecordUniqueness(input);
 
-    this.logger.debug('Creating BudgetRecord', input);
-
     try {
       const recordId = await this.budgetRecordsRepo.create(input, changeset);
 
-      this.logger.debug(`Created Budget Record`, {
-        id: recordId,
-        userId: session.userId,
-      });
-
       const budgetRecord = await this.readOneRecord(
         recordId,
         session,
@@ -116,10 +97,6 @@ export class BudgetService {
 
       return budgetRecord;
     } catch (exception) {
-      this.logger.error(`Could not create Budget Record`, {
-        userId: session.userId,
-        exception,
-      });
       throw new CreationFailed(BudgetRecord, { cause: exception });
     }
   }
@@ -136,11 +113,6 @@ export class BudgetService {
 
   @HandleIdLookup(Budget)
   async readOne(id: ID, session: Session, view?: ObjectView): Promise<Budget> {
-    this.logger.debug(`readOne budget`, {
-      id,
-      userId: session.userId,
-    });
-
     const result = await this.budgetRepo.readOne(id, session, view);
 
     const privs = this.privileges.for(Budget, result);
@@ -190,11 +162,6 @@ export class BudgetService {
     session: Session,
     view?: ObjectView,
   ): Promise<BudgetRecord> {
-    this.logger.debug(`readOne BudgetRecord`, {
-      id,
-      userId: session.userId,
-    });
-
     const result = await this.budgetRecordsRepo.readOne(id, { session, view });
 
     return this.privileges.for(BudgetRecord).secure(result);
@@ -220,8 +187,6 @@ export class BudgetService {
     session: Session,
     changeset?: ID,
   ): Promise<BudgetRecord> {
-    this.logger.debug('Update budget record', { id, userId: session.userId });
-
     const br = await this.readOneRecord(
       id,
       session,
@@ -230,20 +195,8 @@ export class BudgetService {
     const changes = this.budgetRecordsRepo.getActualChanges(br, input);
     this.privileges.for(BudgetRecord, br).verifyChanges(changes);
 
-    try {
-      const result = await this.budgetRecordsRepo.update(
-        br,
-        changes,
-        changeset,
-      );
-      return result;
-    } catch (e) {
-      this.logger.error('Could not update budget Record ', {
-        id,
-        userId: session.userId,
-      });
-      throw e;
-    }
+    const result = await this.budgetRecordsRepo.update(br, changes, changeset);
+    return result;
   }
 
   async delete(id: ID, session: Session): Promise<void> {
@@ -257,21 +210,15 @@ export class BudgetService {
     try {
       await this.budgetRepo.deleteNode(budget);
     } catch (e) {
-      this.logger.warning('Failed to delete budget', {
-        exception: e,
-      });
-      throw new ServerException('Failed to delete budget');
+      throw new ServerException('Failed to delete budget', e);
     }
   }
 
   async deleteRecord(id: ID, session: Session, changeset?: ID): Promise<void> {
     try {
       await this.budgetRecordsRepo.deleteNode(id, { changeset });
     } catch (e) {
-      this.logger.warning('Failed to delete Budget Record', {
-        exception: e,
-      });
-      throw new ServerException('Failed to delete Budget Record');
+      throw new ServerException('Failed to delete Budget Record', e);
     }
   }
 

src/components/ceremony/ceremony.service.ts

@@ -7,7 +7,7 @@ import {
   type Session,
   type UnsecuredDto,
 } from '~/common';
-import { HandleIdLookup, ILogger, Logger } from '~/core';
+import { HandleIdLookup } from '~/core';
 import { Privileges } from '../authorization';
 import { CeremonyRepository } from './ceremony.repository';
 import { Ceremony, type CreateCeremony, type UpdateCeremony } from './dto';
@@ -17,7 +17,6 @@ export class CeremonyService {
   constructor(
     private readonly privileges: Privileges,
     private readonly repo: CeremonyRepository,
-    @Logger('ceremony:service') private readonly logger: ILogger,
   ) {}
 
   async create(input: CreateCeremony): Promise<ID> {
@@ -32,7 +31,6 @@ export class CeremonyService {
     session: Session,
     _view?: ObjectView,
   ): Promise<Ceremony> {
-    this.logger.debug(`Query readOne Ceremony`, { id, userId: session.userId });
     if (!id) {
       throw new InputException('No ceremony id to search for', 'ceremony.id');
     }
@@ -73,10 +71,7 @@ export class CeremonyService {
     try {
       await this.repo.deleteNode(object);
     } catch (exception) {
-      this.logger.warning('Failed to delete Ceremony', {
-        exception,
-      });
-      throw new ServerException('Failed to delete Ceremony');
+      throw new ServerException('Failed to delete Ceremony', exception);
     }
   }
 }

src/components/engagement/handlers/set-initial-end-date.handler.ts

@@ -1,14 +1,7 @@
 import { ServerException } from '~/common';
-import {
-  ConfigService,
-  EventsHandler,
-  type IEventHandler,
-  ILogger,
-  Logger,
-} from '~/core';
+import { ConfigService, EventsHandler, type IEventHandler } from '~/core';
 import { EngagementStatus, LanguageEngagement } from '../dto';
 import { EngagementRepository } from '../engagement.repository';
-import { EngagementService } from '../engagement.service';
 import { EngagementCreatedEvent, EngagementUpdatedEvent } from '../events';
 
 type SubscribedEvent = EngagementCreatedEvent | EngagementUpdatedEvent;
@@ -17,19 +10,13 @@ type SubscribedEvent = EngagementCreatedEvent | EngagementUpdatedEvent;
 export class SetInitialEndDate implements IEventHandler<SubscribedEvent> {
   constructor(
     private readonly engagementRepo: EngagementRepository,
-    private readonly engagementService: EngagementService,
     private readonly config: ConfigService,
-    @Logger('engagement:set-initial-end-date') private readonly logger: ILogger,
   ) {}
 
   async handle(event: SubscribedEvent) {
     if (this.config.databaseEngine === 'gel') {
       return;
     }
-    this.logger.debug('Engagement mutation, set initial end date', {
-      ...event,
-      event: event.constructor.name,
-    });
 
     const engagement = 'engagement' in event ? event.engagement : event.updated;
 
@@ -72,10 +59,6 @@ export class SetInitialEndDate implements IEventHandler<SubscribedEvent> {
         event.engagement = updatedEngagement;
       }
     } catch (exception) {
-      this.logger.error(`Could not set initial end date on engagement`, {
-        userId: event.session.userId,
-        exception,
-      });
       throw new ServerException(
         'Could not set initial end date on engagement',
         exception,

src/components/engagement/handlers/set-last-status-date.handler.ts

@@ -1,11 +1,5 @@
 import { ServerException } from '~/common';
-import {
-  ConfigService,
-  EventsHandler,
-  type IEventHandler,
-  ILogger,
-  Logger,
-} from '~/core';
+import { EventsHandler, type IEventHandler } from '~/core';
 import { DatabaseService } from '~/core/database';
 import { EngagementStatus, IEngagement } from '../dto';
 import { EngagementUpdatedEvent } from '../events';
@@ -14,11 +8,7 @@ import { EngagementUpdatedEvent } from '../events';
 export class SetLastStatusDate
   implements IEventHandler<EngagementUpdatedEvent>
 {
-  constructor(
-    private readonly db: DatabaseService,
-    private readonly config: ConfigService,
-    @Logger('engagement:set-last-status-date') private readonly logger: ILogger,
-  ) {}
+  constructor(private readonly db: DatabaseService) {}
 
   async handle(event: EngagementUpdatedEvent) {
     const { previous, updated, session } = event;
@@ -49,13 +39,7 @@ export class SetLastStatusDate
         changes,
       });
     } catch (exception) {
-      this.logger.error(`Could not set last status date`, {
-        userId: session.userId,
-        exception,
-      });
-      throw this.config.jest
-        ? exception
-        : new ServerException('Could not set last status date', exception);
+      throw new ServerException('Could not set last status date', exception);
     }
   }
 }

src/components/field-region/field-region.service.ts

@@ -6,7 +6,7 @@ import {
   type Session,
   type UnsecuredDto,
 } from '~/common';
-import { HandleIdLookup, ILogger, Logger } from '~/core';
+import { HandleIdLookup } from '~/core';
 import { Privileges } from '../authorization';
 import {
   type CreateFieldRegion,
@@ -20,7 +20,6 @@ import { FieldRegionRepository } from './field-region.repository';
 @Injectable()
 export class FieldRegionService {
   constructor(
-    @Logger('field-region:service') private readonly logger: ILogger,
     private readonly privileges: Privileges,
     private readonly repo: FieldRegionRepository,
   ) {}
@@ -40,11 +39,6 @@ export class FieldRegionService {
     session: Session,
     _view?: ObjectView,
   ): Promise<FieldRegion> {
-    this.logger.debug(`Read Field Region`, {
-      id: id,
-      userId: session.userId,
-    });
-
     const result = await this.repo.readOne(id);
     return this.secure(result, session);
   }
@@ -79,7 +73,6 @@ export class FieldRegionService {
     try {
       await this.repo.deleteNode(object);
     } catch (exception) {
-      this.logger.error('Failed to delete', { id, exception });
       throw new ServerException('Failed to delete', exception);
     }
   }

src/components/field-zone/field-zone.service.ts

@@ -6,7 +6,7 @@ import {
   type Session,
   type UnsecuredDto,
 } from '~/common';
-import { HandleIdLookup, ILogger, Logger } from '~/core';
+import { HandleIdLookup } from '~/core';
 import { Privileges } from '../authorization';
 import {
   type CreateFieldZone,
@@ -20,7 +20,6 @@ import { FieldZoneRepository } from './field-zone.repository';
 @Injectable()
 export class FieldZoneService {
   constructor(
-    @Logger('field-zone:service') private readonly logger: ILogger,
     private readonly privileges: Privileges,
     private readonly repo: FieldZoneRepository,
   ) {}
@@ -37,11 +36,6 @@ export class FieldZoneService {
     session: Session,
     _view?: ObjectView,
   ): Promise<FieldZone> {
-    this.logger.debug(`Read Field Zone`, {
-      id: id,
-      userId: session.userId,
-    });
-
     const result = await this.repo.readOne(id);
     return this.secure(result, session);
   }
@@ -73,7 +67,6 @@ export class FieldZoneService {
     try {
       await this.repo.deleteNode(object);
     } catch (exception) {
-      this.logger.error('Failed to delete', { id, exception });
       throw new ServerException('Failed to delete', exception);
     }
   }

src/components/file/file.service.ts

@@ -113,12 +113,10 @@ export class FileService {
   }
 
   async getFileNode(id: ID, session?: Session): Promise<FileNode> {
-    this.logger.debug(`getNode`, { id, userId: session?.userId });
     return await this.repo.getById(id);
   }
 
   async getFileNodes(ids: readonly ID[], session: Session) {
-    this.logger.debug(`getNodes`, { ids, userId: session.userId });
     return await this.repo.getByIds(ids);
   }