Refactor VarianceExplanation.reasons to convert null -> [] in the input stage

Author: CarsonF

src/components/progress-report/variance-explanation/variance-explanation.dto.ts

@@ -3,6 +3,7 @@ import { ArrayMaxSize, IsIn } from 'class-validator';
 import {
   type ID,
   IdField,
+  ListField,
   type RichTextDocument,
   RichTextField,
   SecuredRichTextNullable,
@@ -36,7 +37,10 @@ export abstract class ProgressReportVarianceExplanationInput {
   })
   readonly report: ID;
 
-  @Field(() => [String], { nullable: true })
+  @ListField(() => String, {
+    optional: true,
+    transform: (prev) => (value) => value === null ? [] : prev(value),
+  })
   @IsIn([...ReasonOptions.instance.all], {
     each: true,
     message: 'Reason is not one of our available choices',

src/components/progress-report/variance-explanation/variance-explanation.service.ts

@@ -37,12 +37,7 @@ export class ProgressReportVarianceExplanationService {
     }
 
     const changes = this.repo.getActualChanges(existing, {
-      reasons:
-        input.reasons === undefined
-          ? existing.reasons.value
-          : input.reasons === null
-          ? []
-          : input.reasons,
+      reasons: input.reasons,
       comments: input.comments,
     });
     if (Object.keys(changes).length === 0) {