Change transition conditions & notifiers to be non-nullable

This simplifies consumption

Author: CarsonF

src/components/workflow/define-workflow.ts

@@ -51,7 +51,7 @@ export const defineWorkflow =
         ...transition,
         from: transition.from ? setOf(many(transition.from)) : undefined,
         key: (transition.key ?? uuid.v5(name, input.id)) as ID,
-        conditions: maybeMany(transition.conditions),
+        conditions: maybeMany(transition.conditions) ?? [],
         notifiers: [
           ...(input.defaultNotifiers ?? []),
           ...(maybeMany(transition.notifiers) ?? []),

src/components/workflow/dto/serialized-workflow.dto.ts

@@ -171,10 +171,10 @@ export class SerializedWorkflow extends DataObject {
                 relatedStates:
                   transition.to.relatedStates?.map(serializeState) ?? [],
               },
-        conditions: (transition.conditions ?? []).map((condition) => ({
+        conditions: transition.conditions.map((condition) => ({
           label: condition.description,
         })),
-        notifiers: (transition.notifiers ?? []).map((notifier) => ({
+        notifiers: transition.notifiers.map((notifier) => ({
           label: notifier.description,
         })),
         permissions: getPermissions(transition),

src/components/workflow/transitions/types.ts

@@ -26,7 +26,7 @@ export type InternalTransition<
     name: Names;
     key: ID;
     from?: ReadonlySet<State>;
-    conditions?: ReadonlyArray<TransitionCondition<Context>>;
-    notifiers?: ReadonlyArray<TransitionNotifier<Context>>;
+    conditions: ReadonlyArray<TransitionCondition<Context>>;
+    notifiers: ReadonlyArray<TransitionNotifier<Context>>;
   }>
 >;

src/components/workflow/workflow.flowchart.ts

@@ -75,9 +75,10 @@ export const WorkflowFlowchart = <W extends Workflow>(workflow: () => W) => {
               : `--> ${dynamicToId(t.to)}`;
           const endHalf = `${endId}{{ ${t.label} }}:::${t.type} ${to}`;
 
-          const conditions = t.conditions
-            ? '--"' + t.conditions.map((c) => c.description).join('\\n') + '"'
-            : '';
+          const conditions =
+            t.conditions.length > 0
+              ? '--"' + t.conditions.map((c) => c.description).join('\\n') + '"'
+              : '';
           const from = (t.from ? [...t.from].map(useState) : ['*(*)']).join(
             ' & ',
           );

src/components/workflow/workflow.service.ts

@@ -59,7 +59,7 @@ export const WorkflowService = <W extends Workflow>(workflow: () => W) => {
       );
 
       // Resolve conditions & filter as needed
-      const conditions = available.flatMap((t) => t.conditions ?? []);
+      const conditions = available.flatMap((t) => t.conditions);
       const resolvedConditions = new Map(
         await Promise.all(
           [...new Set(conditions)].map(
@@ -69,8 +69,7 @@ export const WorkflowService = <W extends Workflow>(workflow: () => W) => {
         ),
       );
       available = available.flatMap((t) => {
-        const conditions =
-          t.conditions?.map((c) => resolvedConditions.get(c)!) ?? [];
+        const conditions = t.conditions.map((c) => resolvedConditions.get(c)!);
         if (conditions.some((c) => c.status === 'OMIT')) {
           return [];
         }