Skip to content

Commit 5249bd6

Browse files
committed
Only sync progress reports on engagement update when there is a date change
Previously every engagement update was listing engagements when we knew ahead of time that the reports were in sync because there were no date changes
1 parent 71e2328 commit 5249bd6

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

src/components/periodic-report/handlers/sync-progress-report-to-engagement.handler.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,14 @@ export class SyncProgressReportToEngagementDateRange
5858
// Project dates haven't changed, so do nothing.
5959
return;
6060
}
61+
if (
62+
event instanceof EngagementUpdatedEvent &&
63+
event.input.startDateOverride === undefined &&
64+
event.input.endDateOverride === undefined
65+
) {
66+
// Engagement dates haven't changed, so do nothing.
67+
return;
68+
}
6169

6270
if (
6371
(event instanceof EngagementCreatedEvent && event.engagement.changeset) ||

0 commit comments

Comments
 (0)